[java-idp-plugin-webauthn] branch main updated: Revert "JWEBAUTHN-60 - Ensure cleanup hook is called"

Phil Smart philip.smart at jisc.ac.uk
Fri Aug 22 09:50:19 UTC 2025


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=fe1da42c1edbf90af85b0b427b8a6bccbfa00dcd

The following commit(s) were added to refs/heads/main by this push:
     new fe1da42  Revert "JWEBAUTHN-60 - Ensure cleanup hook is called"
fe1da42 is described below

commit fe1da42c1edbf90af85b0b427b8a6bccbfa00dcd
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Aug 22 10:49:46 2025 +0100

    Revert "JWEBAUTHN-60 - Ensure cleanup hook is called"
    
    This reverts commit 69160a82687b5b566097427f8fff459052ebcb4d.
---
 .../webauthn/impl/ValidateWebAuthnAssertion.java   | 24 ----------------------
 1 file changed, 24 deletions(-)

diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/ValidateWebAuthnAssertion.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/ValidateWebAuthnAssertion.java
index e18fe75..c2f6af0 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/ValidateWebAuthnAssertion.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/ValidateWebAuthnAssertion.java
@@ -20,7 +20,6 @@ import java.util.function.Function;
 import java.util.function.Predicate;
 
 import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
 import javax.security.auth.Subject;
 
 import org.opensaml.messaging.context.navigate.ChildContextLookup;
@@ -77,9 +76,6 @@ public class ValidateWebAuthnAssertion extends AbstractAuditingValidationAction
     /** The WebAuthn client to use.*/
     @NonnullAfterInit private WebAuthnAuthenticationClient webAuthnClient;  
     
-    /** A cleanup hook to execute after processing. */
-    @Nullable private Consumer<ProfileRequestContext> cleanupHook;
-    
     /** The credential repository to validate assertion responses against.*/
     @NonnullAfterInit private WebAuthnCredentialRepository credentialRepository;
     
@@ -115,16 +111,6 @@ public class ValidateWebAuthnAssertion extends AbstractAuditingValidationAction
         }
         super.doInitialize();
     }
-    /**
-     * Set the cleanup hook to execute after processing.
-     * 
-     * @param hook cleanup hook
-     */
-    @Override
-    public void setCleanupHook(@Nullable final Consumer<ProfileRequestContext> hook) {
-        checkSetterPreconditions();
-        cleanupHook = hook;
-    }
     
     /**
      * Set the credential repository used to store WebAuthn credentials.
@@ -360,16 +346,6 @@ public class ValidateWebAuthnAssertion extends AbstractAuditingValidationAction
         }
     }
     
-    /** {@inheritDoc} */
-    @Override
-    protected void doPostExecute(@Nonnull final ProfileRequestContext profileRequestContext) {
-        super.doPostExecute(profileRequestContext);
-        
-        if (cleanupHook != null) {
-            cleanupHook.accept(profileRequestContext);
-        }
-    }
-    
     /**
      * A default cleanup hook that removes the {@link WebAuthnAuthenticationContext} from the tree.
      */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list