[java-idp-plugin-duo] branch main updated: GEN-356 - Plugin jar manifest errors

Phil Smart philip.smart at jisc.ac.uk
Fri Aug 22 09:19:56 UTC 2025


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-duo.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-duo.git;a=commit;h=7878c62a58b87f0241087d0873d1f3c7085ea1ab

The following commit(s) were added to refs/heads/main by this push:
     new 7878c62a GEN-356 - Plugin jar manifest errors
7878c62a is described below

commit 7878c62a58b87f0241087d0873d1f3c7085ea1ab
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Aug 22 10:19:54 2025 +0100

    GEN-356 - Plugin jar manifest errors
    
            - Move Maven jar plugin config to parent
    
    https://shibboleth.atlassian.net/browse/GEN-356
---
 idp-duo-api/pom.xml                | 27 ---------------------------
 idp-duo-impl/pom.xml               | 31 -------------------------------
 idp-duo-nimbus-client-impl/pom.xml | 20 +-------------------
 idp-duo-sdk-client-impl/pom.xml    | 20 +-------------------
 pom.xml                            |  4 +++-
 5 files changed, 5 insertions(+), 97 deletions(-)

diff --git a/idp-duo-api/pom.xml b/idp-duo-api/pom.xml
index 88aa9304..75bead97 100644
--- a/idp-duo-api/pom.xml
+++ b/idp-duo-api/pom.xml
@@ -101,31 +101,4 @@
         </dependency>
 
     </dependencies>
-
-    <build>
-        <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-jar-plugin</artifactId>
-                <configuration>
-                    <archive>
-                        <manifestEntries>
-                            <Main-Class>net.shibboleth.idp.plugin.authn.duo.Version</Main-Class>
-                        </manifestEntries>
-                        <manifestSections>
-                            <manifestSection>
-                                <name>net/shibboleth/idp/plugin/authn/duo/</name>
-                                <manifestEntries>
-                                    <Implementation-Title>${project.artifactId}</Implementation-Title>
-                                    <Implementation-Version>${project.version}</Implementation-Version>
-                                    <Implementation-Vendor>shibboleth.net</Implementation-Vendor>
-                                </manifestEntries>
-                            </manifestSection>
-                        </manifestSections>
-                    </archive>
-                </configuration>
-            </plugin>
-        </plugins>
-    </build>
-
 </project>
\ No newline at end of file
diff --git a/idp-duo-impl/pom.xml b/idp-duo-impl/pom.xml
index 680928b8..475d5409 100644
--- a/idp-duo-impl/pom.xml
+++ b/idp-duo-impl/pom.xml
@@ -252,35 +252,4 @@
 
     </dependencies>
 
-    <build>
-        <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-compiler-plugin</artifactId>
-            </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-jar-plugin</artifactId>
-                <configuration>
-                    <archive>                      
-                        <manifestSections>
-                            <manifestSection>
-                                <name>net/shibboleth/idp/plugin/authn/duo/impl/</name>
-                                <manifestEntries>
-                                    <Implementation-Title>${project.artifactId}</Implementation-Title>
-                                    <Implementation-Version>${project.version}</Implementation-Version>
-                                    <Implementation-Vendor>shibboleth.net</Implementation-Vendor>
-                                </manifestEntries>
-                            </manifestSection>
-                        </manifestSections>
-                    </archive>
-                    <excludes>
-                        <exclude>system/**</exclude>
-                        <exclude>conf/**</exclude>
-                        <exclude>credentials/**</exclude>
-                    </excludes>
-                </configuration>
-            </plugin>            
-        </plugins>
-    </build>
 </project>
\ No newline at end of file
diff --git a/idp-duo-nimbus-client-impl/pom.xml b/idp-duo-nimbus-client-impl/pom.xml
index 8dd7db64..fb20d645 100644
--- a/idp-duo-nimbus-client-impl/pom.xml
+++ b/idp-duo-nimbus-client-impl/pom.xml
@@ -117,25 +117,7 @@
                         </configuration>
                     </execution>
                 </executions>
-            </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-jar-plugin</artifactId>
-                <configuration>
-                    <archive>                      
-                        <manifestSections>
-                            <manifestSection>
-                                <name>net/shibboleth/idp/plugin/authn/duo/nimbus/</name>
-                                <manifestEntries>
-                                    <Implementation-Title>${project.artifactId}</Implementation-Title>
-                                    <Implementation-Version>${project.version}</Implementation-Version>
-                                    <Implementation-Vendor>shibboleth.net</Implementation-Vendor>
-                                </manifestEntries>
-                            </manifestSection>
-                        </manifestSections>
-                    </archive>
-                </configuration>
-            </plugin>
+            </plugin>            
         </plugins>
     </build>
 
diff --git a/idp-duo-sdk-client-impl/pom.xml b/idp-duo-sdk-client-impl/pom.xml
index d5fb469c..5012bd74 100644
--- a/idp-duo-sdk-client-impl/pom.xml
+++ b/idp-duo-sdk-client-impl/pom.xml
@@ -137,25 +137,7 @@
                         </configuration>
                     </execution>
                 </executions>
-            </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-jar-plugin</artifactId>
-                <configuration>
-                    <archive>                       
-                        <manifestSections>
-                            <manifestSection>
-                                <name>net/shibboleth/idp/plugin/authn/duo/sdk/</name>
-                                <manifestEntries>
-                                    <Implementation-Title>${project.artifactId}</Implementation-Title>
-                                    <Implementation-Version>${project.version}</Implementation-Version>
-                                    <Implementation-Vendor>shibboleth.net</Implementation-Vendor>
-                                </manifestEntries>
-                            </manifestSection>
-                        </manifestSections>
-                    </archive>
-                </configuration>
-            </plugin>
+            </plugin>            
         </plugins>
     </build>
 
diff --git a/pom.xml b/pom.xml
index 1691772e..257eeb5e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -149,9 +149,11 @@
                 <artifactId>maven-jar-plugin</artifactId>
                 <configuration>
                     <archive>
-                        <index>true</index>
                         <manifestEntries>
                             <Automatic-Module-Name>${automatic.module.name}</Automatic-Module-Name>
+                            <Implementation-Title>${project.artifactId}</Implementation-Title>
+                            <Implementation-Version>${project.version}</Implementation-Version>
+                            <Implementation-Vendor>shibboleth.net</Implementation-Vendor>
                             <Sealed>true</Sealed>
                         </manifestEntries>
                     </archive>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list