[java-plugin-shibd] branch main updated: Switch to no agent authn as a default.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-plugin-shibd.

View the commit online:
http://git.shibboleth.net/view/?p=java-plugin-shibd.git;a=commit;h=9a9340694a03b861d7c0ffd4970e4f19023a29d3

The following commit(s) were added to refs/heads/main by this push:
     new 9a93406  Switch to no agent authn as a default.
9a93406 is described below

commit 9a9340694a03b861d7c0ffd4970e4f19023a29d3
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Aug 14 14:25:21 2025 -0400

    Switch to no agent authn as a default.
---
 .../main/resources/net/shibboleth/idp/module/conf/sp/sp.properties    | 4 ++--
 .../src/main/resources/net/shibboleth/sp/conf/agents-system.xml       | 2 +-
 .../src/test/resources/net/shibboleth/idp/module/conf/sp/agents.xml   | 2 +-
 sp-server-impl/src/main/java/net/shibboleth/sp/impl/BasicAgent.java   | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/sp-conf-impl/src/main/resources/net/shibboleth/idp/module/conf/sp/sp.properties b/sp-conf-impl/src/main/resources/net/shibboleth/idp/module/conf/sp/sp.properties
index b275a8d..0ee09c9 100644
--- a/sp-conf-impl/src/main/resources/net/shibboleth/idp/module/conf/sp/sp.properties
+++ b/sp-conf-impl/src/main/resources/net/shibboleth/idp/module/conf/sp/sp.properties
@@ -53,8 +53,8 @@ sp.service.agents.checkInterval = PT5M
 
 # Default agent IP address filter
 #sp.authn.allowedAddressRanges = 127.0.0.1/32, ::1/128
-# Set to empty value to skip shared secret authentication
-#sp.agent.authn.method = basic
+# Set to basic for shared secret authentication
+#sp.agent.authn.method =
 # Set false to globally disable cookie-based authentication by agents
 #sp.agent.authn.cached = true
 #sp.agent.authn.cacheDuration = PT1H
diff --git a/sp-conf-impl/src/main/resources/net/shibboleth/sp/conf/agents-system.xml b/sp-conf-impl/src/main/resources/net/shibboleth/sp/conf/agents-system.xml
index f73d7e3..2425f94 100644
--- a/sp-conf-impl/src/main/resources/net/shibboleth/sp/conf/agents-system.xml
+++ b/sp-conf-impl/src/main/resources/net/shibboleth/sp/conf/agents-system.xml
@@ -26,7 +26,7 @@
 
     <bean id="shibboleth.sp.Agent" parent="shibboleth.sp.Application" abstract="true" 
         class="net.shibboleth.sp.impl.BasicAgent"
-        p:authenticationMethod="%{sp.agent.authn.method:basic}"
+        p:authenticationMethod="%{sp.agent.authn.method:}"
         p:allowedAddressRanges-ref="DefaultAllowedAddressRanges"
         p:supportsCachedAuthentication="%{sp.agent.authn.cached:true}" />
 
diff --git a/sp-conf-impl/src/test/resources/net/shibboleth/idp/module/conf/sp/agents.xml b/sp-conf-impl/src/test/resources/net/shibboleth/idp/module/conf/sp/agents.xml
index 128fa21..b0d12c8 100644
--- a/sp-conf-impl/src/test/resources/net/shibboleth/idp/module/conf/sp/agents.xml
+++ b/sp-conf-impl/src/test/resources/net/shibboleth/idp/module/conf/sp/agents.xml
@@ -23,7 +23,7 @@
 
     <!-- ============ Agents and their Applications ============ -->
 
-    <bean p:id="testsp.example.org" parent="shibboleth.sp.Agent" p:sharedSecrets="foo" />
+    <bean p:id="testsp.example.org" parent="shibboleth.sp.Agent" p:authenticationMethod="basic" p:sharedSecrets="foo" />
     
 
     <!-- ============ Profile defaults ============ -->
diff --git a/sp-server-impl/src/main/java/net/shibboleth/sp/impl/BasicAgent.java b/sp-server-impl/src/main/java/net/shibboleth/sp/impl/BasicAgent.java
index b0b1a2b..527ba83 100644
--- a/sp-server-impl/src/main/java/net/shibboleth/sp/impl/BasicAgent.java
+++ b/sp-server-impl/src/main/java/net/shibboleth/sp/impl/BasicAgent.java
@@ -64,7 +64,7 @@ public class BasicAgent extends BasicApplication implements Agent {
     public BasicAgent() {
         supportsCachedAuthentication = true;
         allowedAddressRanges = CollectionSupport.emptySet();
-        authenticationMethod = AUTH_METHOD_BASIC;
+        authenticationMethod  = null;
         sharedSecrets = CollectionSupport.emptySet();
         applicationMap = CollectionSupport.emptyMap();
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.