[cpp-sp] branch main updated: Bypass SecretSource init if auth type is none.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=410872c92b07ebda65ad3ba89a475ecb8652a518

The following commit(s) were added to refs/heads/main by this push:
     new 410872c9 Bypass SecretSource init if auth type is none.
410872c9 is described below

commit 410872c92b07ebda65ad3ba89a475ecb8652a518
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Aug 11 18:28:54 2025 -0400

    Bypass SecretSource init if auth type is none.
---
 shibsp/remoting/impl/AbstractHTTPRemotingService.cpp | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp b/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp
index 1b28862c..b39524d8 100644
--- a/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp
+++ b/shibsp/remoting/impl/AbstractHTTPRemotingService.cpp
@@ -61,10 +61,6 @@ AbstractHTTPRemotingService::AbstractHTTPRemotingService(ptree& pt)
     BoostPropertySet props;
     props.load(pt);
 
-    m_secretSource.reset(AgentConfig::getConfig().SecretSourceManager.newPlugin(
-        props.getString(SECRET_SOURCE_TYPE_PROP_NAME, SECRET_SOURCE_TYPE_PROP_DEFAULT), pt, false)
-        );
-
     m_userAgent = props.getString(USER_AGENT_PROP_NAME, "");
     m_baseURL = props.getString(BASE_URL_PROP_NAME, BASE_URL_PROP_DEFAULT);    
     m_authMethod = getAuthMethod(props.getString(AUTH_METHOD_PROP_NAME, AUTH_METHOD_PROP_DEFAULT));
@@ -72,6 +68,13 @@ AbstractHTTPRemotingService::AbstractHTTPRemotingService(ptree& pt)
     m_timeout = props.getUnsignedInt(TIMEOUT_PROP_NAME, TIMEOUT_PROP_DEFAULT);
     m_revocationCheck = props.getBool(REVOCATION_CHECK_PROP_NAME, REVOCATION_CHECK_DEFAULT);
 
+    if (m_authMethod != agent_auth_none) {
+        m_secretSource.reset(AgentConfig::getConfig().SecretSourceManager.newPlugin(
+            props.getString(SECRET_SOURCE_TYPE_PROP_NAME, SECRET_SOURCE_TYPE_PROP_DEFAULT), pt, false)
+            );
+    }
+
+
     m_caFile = props.getString(CA_FILE_PROP_NAME, CA_FILE_PROP_DEFAULT);
     if (!m_caFile.empty()) {
         AgentConfig::getConfig().getPathResolver().resolve(m_caFile, PathResolver::SHIBSP_CFG_FILE);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.