[java-idp-oidc] 03/04: JOIDC-222 - Support for OpenID Federation
Henri Mikkonen
henri.mikkonen at iki.fi
Fri Aug 8 12:18:25 UTC 2025
This is an automated email from the git hooks/post-receive script.
hjmikkon pushed a commit to branch dev/JOIDC-222
in repository java-idp-oidc.
View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=8c3069bcd184ee611e938eafb64562348e360664
commit 8c3069bcd184ee611e938eafb64562348e360664
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Fri Aug 8 12:54:19 2025 +0300
JOIDC-222 - Support for OpenID Federation
https://shibboleth.atlassian.net/browse/JOIDC-222
JavaDoc fixes
---
.../oidc/op/oidfed/config/RelyingPartyConfigurationSupport.java | 1 +
.../oidfed/metadata/DefaultProvidedTrustChainValidationStrategy.java | 1 +
.../oidc/op/oidfed/metadata/DefaultTrustChainFetchingStrategy.java | 4 ++--
.../op/oidfed/profile/impl/AbstractBuildEntityStatementAction.java | 1 +
.../oidfed/profile/impl/BuildResolveEntityErrorResponseFromEvent.java | 2 +-
.../op/oidfed/profile/impl/FormOutboundResolveEntityResponse.java | 4 ++--
.../idp/plugin/oidc/op/oidfed/profile/impl/ResolveTrustMarks.java | 3 ++-
.../oidc/op/profile/impl/AbstractOIDCClientRegistrationAction.java | 2 +-
8 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/config/RelyingPartyConfigurationSupport.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/config/RelyingPartyConfigurationSupport.java
index 2655d226..f40f80a5 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/config/RelyingPartyConfigurationSupport.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/config/RelyingPartyConfigurationSupport.java
@@ -19,6 +19,7 @@ import java.util.Collection;
import javax.annotation.Nonnull;
import net.shibboleth.profile.relyingparty.BasicRelyingPartyConfiguration;
+import net.shibboleth.profile.relyingparty.RelyingPartyConfiguration;
import net.shibboleth.shared.logic.Constraint;
/**
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultProvidedTrustChainValidationStrategy.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultProvidedTrustChainValidationStrategy.java
index 7e348ac6..d6bbcd74 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultProvidedTrustChainValidationStrategy.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultProvidedTrustChainValidationStrategy.java
@@ -23,6 +23,7 @@ import javax.annotation.Nonnull;
import javax.annotation.Nullable;
import org.opensaml.profile.context.ProfileRequestContext;
+import org.opensaml.security.trust.TrustEngine;
import org.slf4j.Logger;
import com.fasterxml.jackson.databind.ObjectMapper;
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultTrustChainFetchingStrategy.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultTrustChainFetchingStrategy.java
index d92c5476..8ed67602 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultTrustChainFetchingStrategy.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/metadata/DefaultTrustChainFetchingStrategy.java
@@ -301,9 +301,9 @@ public class DefaultTrustChainFetchingStrategy extends AbstractIdentifiableIniti
* Recursively populates the given list of trust chains until the last entity statement in each chain doesn't
* contain any authority hints.
*
- * @param entities the list of trust chains to be populated.
+ * @param entities the list of trust chains being populated.
* @param preSelectedChain the pre-selected trust chain (containing entity IDs as String).
- * @return
+ * @return the list of trust chains being populated
*/
@Nonnull @NonnullElements private List<List<EntityStatement>> populateChain(
@Nonnull @NonnullElements final List<List<EntityStatement>> entities,
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/AbstractBuildEntityStatementAction.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/AbstractBuildEntityStatementAction.java
index b810b7dd..bda20702 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/AbstractBuildEntityStatementAction.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/AbstractBuildEntityStatementAction.java
@@ -37,6 +37,7 @@ import com.fasterxml.jackson.databind.ObjectMapper;
import com.nimbusds.jwt.JWT;
import com.nimbusds.jwt.JWTClaimsSet;
import com.nimbusds.jwt.PlainJWT;
+import com.nimbusds.openid.connect.sdk.federation.entities.EntityStatement;
import net.shibboleth.idp.plugin.oidc.op.encoding.impl.ResponseUtil;
import net.shibboleth.idp.plugin.oidc.op.oidfed.profile.navigate.AuthorityHintsLookupFunction;
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/BuildResolveEntityErrorResponseFromEvent.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/BuildResolveEntityErrorResponseFromEvent.java
index 53006b02..3562968f 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/BuildResolveEntityErrorResponseFromEvent.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/BuildResolveEntityErrorResponseFromEvent.java
@@ -48,7 +48,7 @@ import net.shibboleth.shared.resolver.CriteriaSet;
/**
* This action reads an event from the configured {@link EventContext} lookup strategy, constructs a JSON error response
* message and attaches it as the outbound message. If {@link RelyingPartyResolveEntityContext} is found, it's exploited
- * for storing the response message in the configured {@link this#responseCache}.
+ * for storing the response message in the configured {@link #responseCache}.
*/
public class BuildResolveEntityErrorResponseFromEvent extends AbstractBuildErrorResponseFromEvent<JSONErrorResponse> {
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/FormOutboundResolveEntityResponse.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/FormOutboundResolveEntityResponse.java
index 4ceb9033..ccdc1d8b 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/FormOutboundResolveEntityResponse.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/FormOutboundResolveEntityResponse.java
@@ -52,8 +52,8 @@ import net.shibboleth.shared.resolver.CriteriaSet;
/**
* This action builds a response for the OpenID federation resolve entity request. The response contains an
- * {@link EntityStatement}. The response is put in the {@link this#responseCache} using the lifetime resolved via
- * {@link this#cachedResponseLifetimeLookupStrategy}.
+ * {@link EntityStatement}. The response is put in the {@link #responseCache} using the lifetime resolved via
+ * {@link #cachedResponseLifetimeLookupStrategy}.
*
* @since 4.3.0
*/
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/ResolveTrustMarks.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/ResolveTrustMarks.java
index 9757b225..5f2da394 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/ResolveTrustMarks.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/profile/impl/ResolveTrustMarks.java
@@ -171,7 +171,7 @@ public class ResolveTrustMarks extends AbstractProfileAction {
/**
* Set the condition to solely take trusted trust mark issuers into account.
*
- * @param condition
+ * @param condition condition to set
*/
public void setTrustedTrustMarkIssuersOnlyCondition(@Nonnull final Predicate<ProfileRequestContext> condition) {
checkSetterPreconditions();
@@ -441,6 +441,7 @@ public class ResolveTrustMarks extends AbstractProfileAction {
* entity configuration and (2) the trust engine for validating the trust mark signature.
*
* @param jwt the trust mark to be verified
+ * @param trustedOwners the trusted trust mark owners
* @param profileRequestContext the profile request context
* @return true if trust mark verification was successful, false otherwise
*/
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/AbstractOIDCClientRegistrationAction.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/AbstractOIDCClientRegistrationAction.java
index 8e53926f..b6fc2b33 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/AbstractOIDCClientRegistrationAction.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/AbstractOIDCClientRegistrationAction.java
@@ -88,7 +88,7 @@ public abstract class AbstractOIDCClientRegistrationAction extends AbstractProfi
/**
* Get the {@link OIDCClientRegistrationResponseContext}. Cannot be null after
- * {@link this#doPreExecute(ProfileRequestContext)} has returned true.
+ * {@link #doPreExecute(ProfileRequestContext)} has returned true.
*
* @return registration context
*/
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list