[java-identity-provider] 01/02: IDP-2394 Consistent return codes for plugin installation failures?

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=017bdb0748963f60bfbe41201dfffff8634cbac7

commit 017bdb0748963f60bfbe41201dfffff8634cbac7
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Wed Aug 6 19:47:34 2025 +0100

    IDP-2394 Consistent return codes for plugin installation failures?
    
    https://shibboleth.atlassian.net/browse/IDP-2394
    
    Use an API level constant to warn that a module hasn't been enabled during
    plugin installation.
---
 .../shibboleth/idp/installer/plugin/impl/PluginInstallerCLI.java   | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstallerCLI.java b/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstallerCLI.java
index 95fd45671..5a21aa204 100644
--- a/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstallerCLI.java
+++ b/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstallerCLI.java
@@ -64,9 +64,6 @@ public final class PluginInstallerCLI extends AbstractIdPHomeAwareCommandLine<Pl
     /** Class logger. */
     private Logger log;
     
-    /** Return code indicating an module mismatch, {@value} . */
-    public static final int RC_MODULE = 3;
-
     /** A Plugin Installer to use. */
     @Nullable private PluginInstaller installer;
 
@@ -350,7 +347,7 @@ public final class PluginInstallerCLI extends AbstractIdPHomeAwareCommandLine<Pl
     /** List all installed plugins (or just one if provided).
      * @param fullList whether to do full deatils
      * @param pluginId the pluginId or null.
-     * @return {@link #RC_MODULE} if we hit a module issue, otherwise {@link AbstractCommandLine#RC_OK}  
+     * @return {@link AbstractCommandLine#RC_MODULE} if we hit a module issue, otherwise {@link AbstractCommandLine#RC_OK}
      */
     private int doList(final boolean fullList, @Nullable final String pluginId) {
         boolean list = false;
@@ -368,7 +365,7 @@ public final class PluginInstallerCLI extends AbstractIdPHomeAwareCommandLine<Pl
                 for (final String module:plugin.getRequiredModules()) {
                                         if (!modules.contains(module)) {
                                                 getLogger().error("Plugin {} requires non-enabled module {}", plugin.getPluginId(), module);
-                                                result = RC_MODULE;
+                                                result = AbstractCommandLine.RC_MODULE;
                                         }
                 }
                 if (fullList) {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.