[java-shib-shared] branch main updated: IDP-2394 Consistent return codes for plugin installation failures?

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-shared.git;a=commit;h=4d311cf04b21ca3fd4ff08c86077b59377c9cf81

The following commit(s) were added to refs/heads/main by this push:
     new 4d311cf0 IDP-2394 Consistent return codes for plugin installation failures?
4d311cf0 is described below

commit 4d311cf04b21ca3fd4ff08c86077b59377c9cf81
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Wed Aug 6 19:44:47 2025 +0100

    IDP-2394 Consistent return codes for plugin installation failures?
    
    https://shibboleth.atlassian.net/browse/IDP-2394
    
    Define as an API AbstractCommandLine.RC_MODULE
    
    This is (currently) only used when the plugin installer finds that something needs
    a non-enabled module.
---
 .../java/net/shibboleth/shared/cli/AbstractCommandLine.java   | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/shib-cli/src/main/java/net/shibboleth/shared/cli/AbstractCommandLine.java b/shib-cli/src/main/java/net/shibboleth/shared/cli/AbstractCommandLine.java
index 164b4a7e..c860046c 100644
--- a/shib-cli/src/main/java/net/shibboleth/shared/cli/AbstractCommandLine.java
+++ b/shib-cli/src/main/java/net/shibboleth/shared/cli/AbstractCommandLine.java
@@ -59,15 +59,18 @@ public abstract class AbstractCommandLine<T extends CommandLineArguments> {
     /** Name of system property for command line argument class. */
     @Nonnull @NotEmpty public static final String ARGS_PROPERTY = "net.shibboleth.shared.cli.arguments";
 
-    /** Return code indicating command completed successfully, {@value} . */
+    /** Return code indicating command completed successfully, {@value}. */
     public static final int RC_OK = 0;
 
-    /** Return code indicating an initialization error, {@value} . */
+    /** Return code indicating an initialization error, {@value}. */
     public static final int RC_INIT = 1;
 
-    /** Return code indicating an error reading files, {@value} . */
+    /** Return code indicating an error reading files, {@value}. */
     public static final int RC_IO = 2;
 
+    /** Return code indicating an module mismatch, for instance during plugin installation {@value}. */
+    public static final int RC_MODULE = 3;
+
     /** Return code indicating an unknown error occurred, {@value} . */
     public static final int RC_UNKNOWN = -1;
 
@@ -133,7 +136,7 @@ public abstract class AbstractCommandLine<T extends CommandLineArguments> {
 
     /** Optional Context initialized. */
     @Nullable private ApplicationContextInitializer<? super FilesystemGenericApplicationContext> contextInitializer;
-    
+
     /**
      * Sets whether JCommander parses options case-sensitively or not.
      * 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.