[cpp-sp] branch main updated: Windows: Visual Studio compile

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=b3d3d42148d5af71730ec7c21d2f83bdef8f7551

The following commit(s) were added to refs/heads/main by this push:
     new b3d3d421 Windows: Visual Studio compile
b3d3d421 is described below

commit b3d3d42148d5af71730ec7c21d2f83bdef8f7551
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Mon Apr 28 14:35:06 2025 +0100

    Windows: Visual Studio compile
    
    Fix a few missed returns and missing methods in tests classes.
---
 shibsp/impl/AgentConfig.cpp                  | 1 +
 shibsp/session/impl/AbstractSessionCache.cpp | 1 +
 tests/impl/XMLAccessControlTests.cpp         | 7 +++++++
 tests/impl/XMLRequestMapperTests.cpp         | 4 ++++
 4 files changed, 13 insertions(+)

diff --git a/shibsp/impl/AgentConfig.cpp b/shibsp/impl/AgentConfig.cpp
index 6cfbeffb..037884a0 100644
--- a/shibsp/impl/AgentConfig.cpp
+++ b/shibsp/impl/AgentConfig.cpp
@@ -70,6 +70,7 @@ namespace shibsp {
         bool init(const char* inst_prefix=nullptr, const char* config_file=nullptr, bool rethrow=false);
         bool start() {
             call_once(m_startonce, &AgentInternalConfig::_start, this);
+            return true;
         }
         void term();
 
diff --git a/shibsp/session/impl/AbstractSessionCache.cpp b/shibsp/session/impl/AbstractSessionCache.cpp
index 30431f63..a7f2a1e6 100644
--- a/shibsp/session/impl/AbstractSessionCache.cpp
+++ b/shibsp/session/impl/AbstractSessionCache.cpp
@@ -67,6 +67,7 @@ AbstractSessionCache::~AbstractSessionCache()
 
 bool AbstractSessionCache::start()
 {
+    return false;
 }
 
 BasicSession::BasicSession(AbstractSessionCache& cache, DDF& obj)
diff --git a/tests/impl/XMLAccessControlTests.cpp b/tests/impl/XMLAccessControlTests.cpp
index ba021018..f7f58558 100644
--- a/tests/impl/XMLAccessControlTests.cpp
+++ b/tests/impl/XMLAccessControlTests.cpp
@@ -77,6 +77,7 @@ public:
 class DummyRequest : public AbstractSPRequest {
 public:
     DummyRequest() : AbstractSPRequest(SHIBSP_LOGCAT ".DummyRequest") {}
+    ~DummyRequest() {}
     RequestMapper::Settings getRequestSettings() const { return make_pair(&m_map, nullptr); }
     const char* getMethod() const { return nullptr; }
     const char* getScheme() const { return nullptr; }
@@ -96,6 +97,12 @@ public:
     long returnDecline() { return 200; }
     long returnOK() { return 200; }
 
+    bool isUseHeaders() const { return true; }
+    bool isUseVariables() const { return false; }
+
+    void clearHeader(const char* name) {}
+
+
     string m_user;
     DummyRequestMap m_map;
 };
diff --git a/tests/impl/XMLRequestMapperTests.cpp b/tests/impl/XMLRequestMapperTests.cpp
index 07c3a379..908038d9 100644
--- a/tests/impl/XMLRequestMapperTests.cpp
+++ b/tests/impl/XMLRequestMapperTests.cpp
@@ -96,6 +96,10 @@ public:
     long returnDecline() { return 200; }
     long returnOK() { return 200; }
 
+    bool isUseHeaders() const {return true;}
+    bool isUseVariables() const { return false; }
+    void clearHeader(const char* name) {}
+
     string m_scheme;
     string m_hostname;
     int m_port;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.