[java-opensaml] branch main updated: Do the obvious thing and simplify the new method I botched.

Scott Cantor cantor.2 at osu.edu
Thu Apr 24 16:30:31 UTC 2025


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=04a186aa6fb3d5d6e2517fcbc78e4200dd98580f

The following commit(s) were added to refs/heads/main by this push:
     new 04a186aa6 Do the obvious thing and simplify the new method I botched.
04a186aa6 is described below

commit 04a186aa6fb3d5d6e2517fcbc78e4200dd98580f
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Apr 24 12:30:29 2025 -0400

    Do the obvious thing and simplify the new method I botched.
---
 .../saml/common/binding/SAMLBindingSupport.java    | 33 ++--------------------
 1 file changed, 2 insertions(+), 31 deletions(-)

diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/SAMLBindingSupport.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/SAMLBindingSupport.java
index f2fd88571..6cf020a08 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/SAMLBindingSupport.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/SAMLBindingSupport.java
@@ -113,38 +113,9 @@ public final class SAMLBindingSupport {
      * @since 5.2.0
      */
     @Nullable public static URI getEndpointURLOrNull(@Nonnull final MessageContext messageContext) {
-        final SAMLPeerEntityContext peerContext = messageContext.getSubcontext(SAMLPeerEntityContext.class);
-        if (peerContext == null) {
-            return null;
-        }
-        
-        final SAMLEndpointContext endpointContext = peerContext.getSubcontext(SAMLEndpointContext.class);
-        if (endpointContext == null) {
-            return null;
-        }
-        
-        final Endpoint endpoint = endpointContext.getEndpoint();
-        if (endpoint == null) {
-            return null;
-        }
-
-        final Object message = messageContext.getMessage();
-        if ((message instanceof org.opensaml.saml.saml2.core.StatusResponseType 
-                || message instanceof org.opensaml.saml.saml1.core.Response) 
-                && !Strings.isNullOrEmpty(endpoint.getResponseLocation())) {
-            try {
-                return new URI(endpoint.getResponseLocation());
-            } catch (final URISyntaxException e) {
-                return null;
-            }
-        }
-        
-        if (Strings.isNullOrEmpty(endpoint.getLocation())) {
-            return null;
-        }
         try {
-            return new URI(endpoint.getLocation());
-        } catch (final URISyntaxException e) {
+            return getEndpointURL(messageContext);
+        } catch (final BindingException e) {
             return null;
         }
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list