[java-idp-oidc] branch dev/JOIDC-222 updated: JOIDC-222 - Support for OpenID Federation

[Henri Mikkonen]

This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch dev/JOIDC-222
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=469ff3a8064c552c92550ee6c5c35029d6a5a5b9

The following commit(s) were added to refs/heads/dev/JOIDC-222 by this push:
     new 469ff3a8 JOIDC-222 - Support for OpenID Federation
469ff3a8 is described below

commit 469ff3a8064c552c92550ee6c5c35029d6a5a5b9
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Wed Apr 23 16:39:35 2025 +0300

    JOIDC-222 - Support for OpenID Federation
    
    https://shibboleth.atlassian.net/browse/JOIDC-222
    
    Fixed the resolve entity request parameter name.
---
 .../oidc/op/oidfed/decoding/impl/ResolveEntityRequestDecoder.java   | 4 ++--
 .../plugin/oidc/op/profile/flow/oidfed/ResolveEntityFlowTest.java   | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/decoding/impl/ResolveEntityRequestDecoder.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/decoding/impl/ResolveEntityRequestDecoder.java
index 11668fac..c83878e9 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/decoding/impl/ResolveEntityRequestDecoder.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oidfed/decoding/impl/ResolveEntityRequestDecoder.java
@@ -71,12 +71,12 @@ public class ResolveEntityRequestDecoder extends BaseOAuth2RequestDecoder<Resolv
             if (subject == null) {
                 throw new MessageDecodingException("No single sub value in the request");
             }
-            final List<String> trustAnchors = Optional.ofNullable(parameters.get("trust_anchors"))
+            final List<String> trustAnchors = Optional.ofNullable(parameters.get("trust_anchor"))
                     .filter(Objects::nonNull)
                     .filter(list -> list.size() > 0)
                     .orElse(null);
             if (trustAnchors == null) {
-                throw new MessageDecodingException("No trust_anchors included in the request");
+                throw new MessageDecodingException("No trust_anchor included in the request");
             }
             final String entityType = Optional.ofNullable(parameters.get("entity_type"))
                     .filter(Objects::nonNull)
diff --git a/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/flow/oidfed/ResolveEntityFlowTest.java b/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/flow/oidfed/ResolveEntityFlowTest.java
index bdb6fa75..2cb4669d 100644
--- a/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/flow/oidfed/ResolveEntityFlowTest.java
+++ b/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/flow/oidfed/ResolveEntityFlowTest.java
@@ -45,7 +45,7 @@ public class ResolveEntityFlowTest extends AbstractFederationFlowTest {
     @Test
     public void testInvalidSubject() throws Exception {
         request.setMethod("GET");
-        request.setQueryString("sub=mockClientId&trust_anchors=" + anchorId + "&entity_type=openid_relying_party");
+        request.setQueryString("sub=mockClientId&trust_anchor=" + anchorId + "&entity_type=openid_relying_party");
         final FlowExecutionResult result = flowExecutor.launchExecution(FLOW_ID, null, externalContext);
         assertErrorCode(result, "invalid_subject");
     }
@@ -55,7 +55,7 @@ public class ResolveEntityFlowTest extends AbstractFederationFlowTest {
         request.setMethod("GET");
         final String clientId = uniqueClientId();
         configureMockHttpClient(clientId);
-        request.setQueryString("sub=" + clientId + "&trust_anchors=mockAnchors&entity_type=openid_relying_party");
+        request.setQueryString("sub=" + clientId + "&trust_anchor=mockAnchors&entity_type=openid_relying_party");
         final FlowExecutionResult result = flowExecutor.launchExecution(FLOW_ID, null, externalContext);
         assertErrorCode(result, "invalid_trust_anchor");
     }
@@ -65,7 +65,7 @@ public class ResolveEntityFlowTest extends AbstractFederationFlowTest {
         request.setMethod("GET");
         final String clientId = uniqueClientId();
         configureMockHttpClient(clientId);
-        request.setQueryString("sub=" + clientId + "&trust_anchors=" + anchorId + "&entity_type=openid_relying_party");
+        request.setQueryString("sub=" + clientId + "&trust_anchor=" + anchorId + "&entity_type=openid_relying_party");
         final FlowExecutionResult result = flowExecutor.launchExecution(FLOW_ID, null, externalContext);
         final ResolveEntityResponse parsedResponse =
                 parseSuccessResponse(result, ResolveEntityResponse.class);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.