[java-shib-attribute] 03/03: JSATTR-44 IdPAttribute.hashCode() and IdPAttribute.equals() diverge

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-shib-attribute.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-attribute.git;a=commit;h=63d09a99a6e4de44411d801d4bc544b2d295b574

commit 63d09a99a6e4de44411d801d4bc544b2d295b574
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Fri Apr 18 14:55:41 2025 +0100

    JSATTR-44 IdPAttribute.hashCode() and IdPAttribute.equals() diverge
    
    https://shibboleth.atlassian.net/browse/JSATTR-44
    
    Add supressed test.
---
 .../net/shibboleth/idp/attribute/AttributeTest.java    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/shib-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeTest.java b/shib-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeTest.java
index 23f16dbde..9636f1c1b 100644
--- a/shib-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeTest.java
+++ b/shib-attribute-api/src/test/java/net/shibboleth/idp/attribute/AttributeTest.java
@@ -258,4 +258,22 @@ public class AttributeTest extends OpenSAMLInitBaseTestCase{
             }
         }
     }
+
+    @Test(enabled=false) public void testHashEquals() {
+        final IdPAttribute attrib1 = new IdPAttribute("foo");
+        final IdPAttribute attrib2 = new IdPAttribute("foo");
+
+        attrib1.setValues(CollectionSupport.listOf(StringAttributeValue.valueOf("String1"),StringAttributeValue.valueOf("String2")));
+        attrib2.setValues(CollectionSupport.listOf(StringAttributeValue.valueOf("String3"),StringAttributeValue.valueOf("String4")));
+
+        assertTrue(attrib1.equals(attrib2));
+
+        final HashSet<IdPAttribute> set = new HashSet<>();
+        set.add(attrib1);
+        set.add(attrib2);
+        assertEquals(set.size(), 1);
+
+        assertEquals(attrib1.hashCode(), attrib2.hashCode());
+
+    }
 }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.