[java-shib-shared] branch main updated: Bypass new disabling logic for testing purposes.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-shared.git;a=commit;h=98d5a7a12a6c76d204c4a066bbde2a6a8315b18c

The following commit(s) were added to refs/heads/main by this push:
     new 98d5a7a1 Bypass new disabling logic for testing purposes.
98d5a7a1 is described below

commit 98d5a7a12a6c76d204c4a066bbde2a6a8315b18c
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Apr 9 16:18:08 2025 -0400

    Bypass new disabling logic for testing purposes.
---
 .../spring/servlet/impl/SameSiteCookieHeaderFilterTest.java | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/shib-networking-spring/src/test/java/net/shibboleth/shared/spring/servlet/impl/SameSiteCookieHeaderFilterTest.java b/shib-networking-spring/src/test/java/net/shibboleth/shared/spring/servlet/impl/SameSiteCookieHeaderFilterTest.java
index f249fc32..0838b048 100644
--- a/shib-networking-spring/src/test/java/net/shibboleth/shared/spring/servlet/impl/SameSiteCookieHeaderFilterTest.java
+++ b/shib-networking-spring/src/test/java/net/shibboleth/shared/spring/servlet/impl/SameSiteCookieHeaderFilterTest.java
@@ -91,6 +91,7 @@ public class SameSiteCookieHeaderFilterTest {
     /** Test a null init value, which should not trigger an exception.*/
     @Test public void testNullInitValues() {
         SameSiteCookieHeaderFilter filter = new SameSiteCookieHeaderFilter();
+        filter.setDisableBasedOnServletAPI(false);
         filter.setSameSiteCookies(null);
         filter.setDefaultValue(null);
     }
@@ -98,6 +99,7 @@ public class SameSiteCookieHeaderFilterTest {
     /** Test an empty cookie name is not added to the internal map.*/
     @Test public void testEmptyCookieNameInitValue() {
         SameSiteCookieHeaderFilter filter = new SameSiteCookieHeaderFilter();
+        filter.setDisableBasedOnServletAPI(false);
         Map<SameSiteValue,List<String>> cookies = new HashMap<>();
         List<String> noneCookies = CollectionSupport.singletonList("");
         cookies.put(SameSiteValue.None, noneCookies);
@@ -109,6 +111,7 @@ public class SameSiteCookieHeaderFilterTest {
     /** Test the correct number of cookies are added to the internal filter cookie map.*/
     @Test public void testInitValues() {
         SameSiteCookieHeaderFilter filter = new SameSiteCookieHeaderFilter();
+        filter.setDisableBasedOnServletAPI(false);
         Map<SameSiteValue,List<String>> cookies = new HashMap<>();
         List<String> noneCookies = CollectionSupport.listOf("JSESSIONID","shib_idp_session","shib_idp_session_ss","existing_same_site");
         List<String> laxCookies = CollectionSupport.singletonList("another-cookie-lax");
@@ -124,6 +127,7 @@ public class SameSiteCookieHeaderFilterTest {
     /** Test failure on duplicated cookie names*/
     @Test(expectedExceptions=IllegalArgumentException.class) public void testDuplicateInitValues() {
         SameSiteCookieHeaderFilter filter = new SameSiteCookieHeaderFilter();
+        filter.setDisableBasedOnServletAPI(false);
         Map<SameSiteValue,List<String>> cookies = new HashMap<>();
         List<String> noneCookies = CollectionSupport.listOf("JSESSIONID","shib_idp_session","shib_idp_session_ss","existing_same_site");
         List<String> laxCookies = CollectionSupport.singletonList("JSESSIONID");
@@ -142,6 +146,7 @@ public class SameSiteCookieHeaderFilterTest {
     @Test public void testEmptySameSiteCookieMap() throws IOException, ServletException {
         
         SameSiteCookieHeaderFilter filter = new SameSiteCookieHeaderFilter();
+        filter.setDisableBasedOnServletAPI(false);
         filter.setSameSiteCookies(null);
         
         Servlet redirectServlet = new TestRedirectServlet();
@@ -166,6 +171,7 @@ public class SameSiteCookieHeaderFilterTest {
     @Test public void testEmptySameSiteCookieMapAndNullDefault() throws IOException, ServletException {
         
         SameSiteCookieHeaderFilter filter = new SameSiteCookieHeaderFilter();
+        filter.setDisableBasedOnServletAPI(false);
         filter.setSameSiteCookies(null);
         filter.setDefaultValue(SameSiteValue.Null);
         
@@ -191,6 +197,7 @@ public class SameSiteCookieHeaderFilterTest {
     @Test public void testEmptySameSiteCookieMapWithDefault() throws IOException, ServletException {
         
         SameSiteCookieHeaderFilter filter = new SameSiteCookieHeaderFilter();
+        filter.setDisableBasedOnServletAPI(false);
         filter.setSameSiteCookies(null);
         filter.setDefaultValue(SameSiteValue.Strict);
         
@@ -219,6 +226,7 @@ public class SameSiteCookieHeaderFilterTest {
     @Test public void testRedirectResponseSameSiteNone() throws IOException, ServletException {
        
         SameSiteCookieHeaderFilter filter = new SameSiteCookieHeaderFilter();
+        filter.setDisableBasedOnServletAPI(false);
         Map<SameSiteValue,List<String>> cookies = new HashMap<>();
         List<String> noneCookies = CollectionSupport.listOf("JSESSIONID","shib_idp_session","shib_idp_session_ss","existing_same_site");
         cookies.put(SameSiteValue.None, noneCookies);
@@ -245,6 +253,7 @@ public class SameSiteCookieHeaderFilterTest {
     @Test public void testRedirectResponseSameSiteNoneWithDefault() throws IOException, ServletException {
        
         SameSiteCookieHeaderFilter filter = new SameSiteCookieHeaderFilter();
+        filter.setDisableBasedOnServletAPI(false);
         Map<SameSiteValue,List<String>> cookies = new HashMap<>();
         List<String> noneCookies = CollectionSupport.listOf("shib_idp_session","shib_idp_session_ss","existing_same_site");
         cookies.put(SameSiteValue.None, noneCookies);
@@ -272,6 +281,7 @@ public class SameSiteCookieHeaderFilterTest {
     @Test public void testRedirectResponseSameSiteLax() throws IOException, ServletException {
        
         SameSiteCookieHeaderFilter filter = new SameSiteCookieHeaderFilter();
+        filter.setDisableBasedOnServletAPI(false);
         Map<SameSiteValue,List<String>> cookies = new HashMap<>();
         List<String> noneCookies = CollectionSupport.listOf("JSESSIONID","shib_idp_session","shib_idp_session_ss");
         cookies.put(SameSiteValue.Lax, noneCookies);
@@ -299,6 +309,7 @@ public class SameSiteCookieHeaderFilterTest {
     @Test public void testRedirectResponseSameSiteStrict() throws IOException, ServletException {
         
         SameSiteCookieHeaderFilter filter = new SameSiteCookieHeaderFilter();
+        filter.setDisableBasedOnServletAPI(false);
         Map<SameSiteValue,List<String>> cookies = new HashMap<>();
         List<String> noneCookies = CollectionSupport.listOf("JSESSIONID","shib_idp_session","shib_idp_session_ss");
         cookies.put(SameSiteValue.Strict, noneCookies);
@@ -326,6 +337,7 @@ public class SameSiteCookieHeaderFilterTest {
     @Test public void testGetOutputStreamResponse() throws IOException, ServletException {
         
         SameSiteCookieHeaderFilter filter = new SameSiteCookieHeaderFilter();
+        filter.setDisableBasedOnServletAPI(false);
         Map<SameSiteValue,List<String>> cookies = new HashMap<>();
         List<String> noneCookies = CollectionSupport.listOf("JSESSIONID","shib_idp_session","shib_idp_session_ss","existing_same_site");
         cookies.put(SameSiteValue.None, noneCookies);
@@ -352,6 +364,7 @@ public class SameSiteCookieHeaderFilterTest {
     @Test public void testPrintWriterResponse() throws IOException, ServletException {
         
         SameSiteCookieHeaderFilter filter = new SameSiteCookieHeaderFilter();
+        filter.setDisableBasedOnServletAPI(false);
         Map<SameSiteValue,List<String>> cookies = new HashMap<>();
         List<String> noneCookies = CollectionSupport.listOf("JSESSIONID","shib_idp_session","shib_idp_session_ss","existing_same_site");
         cookies.put(SameSiteValue.None, noneCookies);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.