[java-idp-plugin-webauthn] branch main updated: Improve property names

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=b009925c465bc5b136176ba68d5686ff91ad1b9b

The following commit(s) were added to refs/heads/main by this push:
     new b009925  Improve property names
b009925 is described below

commit b009925c465bc5b136176ba68d5686ff91ad1b9b
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Tue Sep 17 11:52:44 2024 +0100

    Improve property names
---
 .../admin/webauthn-registration/webauthn-registration-beans.xml    | 6 +++---
 .../idp/plugin/authn/webauthn/conf/authn/webauthn.properties       | 7 +++----
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/admin/webauthn-registration/webauthn-registration-beans.xml b/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/admin/webauthn-registration/webauthn-registration-beans.xml
index d87d209..f50e985 100644
--- a/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/admin/webauthn-registration/webauthn-registration-beans.xml
+++ b/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/admin/webauthn-registration/webauthn-registration-beans.xml
@@ -84,9 +84,9 @@
     <bean id="shibboleth.authn.webauthn.SubjectContextUsernameLookupStrategy" lazy-init="true" scope="singleton"
         class="net.shibboleth.idp.plugin.authn.webauthn.context.navigate.UsernameLookupFromSubjectContext" />
     
-    <bean id="shibboleth.authn.webauthn.AttributeContextUserNameLookupStrategy" lazy-init="true" scope="singleton"
+    <bean id="shibboleth.authn.webauthn.AttributeContextWebAuthnNameLookupStrategy" lazy-init="true" scope="singleton"
         class="net.shibboleth.idp.plugin.authn.webauthn.context.navigate.AttributeContextStringLookupStrategy"
-        p:attributeId="%{idp.authn.webauthn.registration.username.attributeId:#{null}}"/>
+        p:attributeId="%{idp.authn.webauthn.registration.name.attributeId:#{null}}"/>
     
     <bean id="AddAttestationConveyancePreference" scope="prototype" parent="AbstractWebAuthnRegistrationAction"
         class="net.shibboleth.idp.plugin.authn.webauthn.admin.impl.AddAttestationConveyancePreference"
@@ -120,7 +120,7 @@
     
     <bean id="AddUserName" parent="AbstractWebAuthnRegistrationAction" scope="prototype"
         class="net.shibboleth.idp.plugin.authn.webauthn.admin.impl.AddUserName"
-         p:userNameLookupStrategy="#{getObject('%{idp.authn.webauthn.registration.username.strategy:shibboleth.authn.webauthn.SubjectContextUsernameLookupStrategy}')}"/>
+         p:userNameLookupStrategy="#{getObject('%{idp.authn.webauthn.registration.name.strategy:shibboleth.authn.webauthn.SubjectContextUsernameLookupStrategy}')}"/>
     
     <bean id="AddDisplayName" parent="AbstractWebAuthnRegistrationAction" scope="prototype"
         class="net.shibboleth.idp.plugin.authn.webauthn.admin.impl.AddDisplayName"
diff --git a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
index 2f88a73..909b47d 100644
--- a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
+++ b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
@@ -52,11 +52,10 @@ idp.authn.webauthn.supportedPrincipals = \
 # The flow logging ID
 #idp.authn.webauthn.admin.registration.logging = WebAuthnCredentialRegistration
 
-# The bean name of the user.name lookup strategy. Think carefully before you change this bean, you nearly always
-# want to use the principal name in the subject context.
-#idp.authn.webauthn.registration.username.strategy = shibboleth.authn.webauthn.SubjectContextUsernameLookupStrategy
+# The bean name of the WebAuthn user.name lookup strategy.
+#idp.authn.webauthn.registration.name.strategy = shibboleth.authn.webauthn.SubjectContextUsernameLookupStrategy
 # If using the attribute context lookup strategy, which attribute should the user.name be taken from
-#idp.authn.webauthn.registration.username.attributeId = WebAuthnUsername
+#idp.authn.webauthn.registration.name.attributeId = WebAuthnUsername
 
 # The bean name of the user.id generator or lookup strategy
 #idp.authn.webauthn.registration.userid.strategy = shibboleth.authn.webauthn.RandomUserIdGenerator

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.