[java-idp-oidc] branch main updated: Clarify intro comment about registry service.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=d18d00adcde4c4dd8614a8fa8279cbc384244bba

The following commit(s) were added to refs/heads/main by this push:
     new d18d00ad Clarify intro comment about registry service.
d18d00ad is described below

commit d18d00adcde4c4dd8614a8fa8279cbc384244bba
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Sep 11 11:39:17 2024 -0400

    Clarify intro comment about registry service.
---
 .../plugin/oidc/op/conf/examples/oidc-attribute-resolver.xml   | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/idp-oidc-extension-impl/src/main/resources/net/shibboleth/idp/plugin/oidc/op/conf/examples/oidc-attribute-resolver.xml b/idp-oidc-extension-impl/src/main/resources/net/shibboleth/idp/plugin/oidc/op/conf/examples/oidc-attribute-resolver.xml
index f299e417..8a278f78 100644
--- a/idp-oidc-extension-impl/src/main/resources/net/shibboleth/idp/plugin/oidc/op/conf/examples/oidc-attribute-resolver.xml
+++ b/idp-oidc-extension-impl/src/main/resources/net/shibboleth/idp/plugin/oidc/op/conf/examples/oidc-attribute-resolver.xml
@@ -6,8 +6,12 @@
                         urn:mace:shibboleth:2.0:resolver:oidc http://shibboleth.net/schema/oidc/shibboleth-attribute-encoder-oidc.xsd">
 
     <!--
-    Some of the examples assume conf/attributes/oidc-claim-rules.xml is loaded
-    into the registry service.
+    Some of the examples assume conf/attributes/oidc-claim-rules.xml is
+    loaded into the registry service.
+    
+    Additionally, the "sub" claim examples below all assume that the file
+    including them is also loaded into that service to process the
+    AttributeEncoder elements shown in these examples.
     -->
 
     <!--
@@ -29,12 +33,14 @@
     <AttributeDefinition id="subjectPublic" xsi:type="Scoped" scope="%{idp.scope}"
             activationConditionRef="shibboleth.oidc.Conditions.PublicRequired">
         <InputAttributeDefinition ref="uid" />
+        <!-- Only works if you load the containing file into the registry service. -->
         <AttributeEncoder xsi:type="oidc:OIDCScopedString" name="sub" />
     </AttributeDefinition>
 
     <AttributeDefinition id="subjectPairwise" xsi:type="Scoped" scope="%{idp.scope}"
             activationConditionRef="shibboleth.oidc.Conditions.PairwiseRequired">
         <InputDataConnector ref="computedSubjectId" attributeNames="subjectId"/>
+        <!-- Only works if you load the containing file into the registry service. -->
         <AttributeEncoder xsi:type="oidc:OIDCScopedString" name="sub" />
     </AttributeDefinition>
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.