[cpp-opensaml] branch main updated: Bump version to 3.3.0, and fix unused param warnings.

Scott Cantor cantor.2 at osu.edu
Tue Sep 10 14:30:29 UTC 2024


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository cpp-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-opensaml.git;a=commit;h=f8789bf666c32090ce9799cb9675b4acedc5445e

The following commit(s) were added to refs/heads/main by this push:
     new f8789bf  Bump version to 3.3.0, and fix unused param warnings.
f8789bf is described below

commit f8789bf666c32090ce9799cb9675b4acedc5445e
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Sep 10 10:30:12 2024 -0400

    Bump version to 3.3.0, and fix unused param warnings.
---
 config_win32.h                                       |  6 +++---
 configure.ac                                         |  2 +-
 opensaml.spec.in                                     | 15 +++++++++------
 saml/Makefile.am                                     |  2 +-
 saml/binding/impl/MessageDecoder.cpp                 |  8 ++++----
 saml/saml.rc                                         | 20 ++++++++++----------
 saml/saml1/binding/impl/SAML1ArtifactDecoder.cpp     |  2 +-
 saml/saml1/binding/impl/SAML1ArtifactEncoder.cpp     |  6 +++---
 saml/saml1/binding/impl/SAML1MessageDecoder.cpp      |  2 +-
 saml/saml1/binding/impl/SAML1POSTDecoder.cpp         |  2 +-
 saml/saml1/binding/impl/SAML1POSTEncoder.cpp         |  4 ++--
 saml/saml1/binding/impl/SAML1SOAPDecoder.cpp         |  4 ++--
 saml/saml1/binding/impl/SAML1SOAPEncoder.cpp         |  8 ++++----
 saml/saml1/binding/impl/SAMLArtifactType0001.cpp     |  2 +-
 saml/saml1/binding/impl/SAMLArtifactType0002.cpp     |  2 +-
 saml/saml1/core/impl/AssertionsImpl.cpp              |  2 +-
 saml/saml1/core/impl/ProtocolsImpl.cpp               |  2 +-
 saml/saml2/binding/impl/SAML2ArtifactType0004.cpp    |  2 +-
 saml/saml2/binding/impl/SAML2ECPEncoder.cpp          |  6 +++---
 saml/saml2/binding/impl/SAML2MessageDecoder.cpp      |  2 +-
 saml/saml2/binding/impl/SAML2POSTEncoder.cpp         |  4 ++--
 saml/saml2/binding/impl/SAML2RedirectEncoder.cpp     |  6 +++---
 saml/saml2/binding/impl/SAML2SOAPDecoder.cpp         |  4 ++--
 saml/saml2/binding/impl/SAML2SOAPEncoder.cpp         |  8 ++++----
 saml/saml2/core/impl/Assertions20Impl.cpp            |  2 +-
 saml/saml2/core/impl/Protocols20Impl.cpp             |  2 +-
 .../metadata/impl/EntityAttributesEntityMatcher.cpp  |  2 +-
 .../saml2/metadata/impl/EntityRoleMetadataFilter.cpp |  4 ++--
 saml/saml2/metadata/impl/ExcludeMetadataFilter.cpp   |  4 ++--
 saml/saml2/metadata/impl/FolderMetadataProvider.cpp  |  2 +-
 saml/saml2/metadata/impl/IncludeMetadataFilter.cpp   |  4 ++--
 .../metadata/impl/LocalDynamicMetadataProvider.cpp   |  3 +--
 saml/saml2/metadata/impl/MetadataImpl.cpp            |  8 ++++----
 saml/saml2/metadata/impl/MetadataProvider.cpp        |  2 +-
 saml/saml2/metadata/impl/NameEntityMatcher.cpp       |  2 +-
 saml/saml2/metadata/impl/NullMetadataProvider.cpp    |  6 +++---
 .../impl/RegistrationAuthorityEntityMatcher.cpp      |  2 +-
 .../impl/RequireValidUntilMetadataFilter.cpp         |  4 ++--
 saml/saml2/metadata/impl/SignatureMetadataFilter.cpp |  2 --
 saml/saml2/profile/impl/SAML2AssertionPolicy.cpp     |  2 +-
 saml/version.h                                       |  4 ++--
 samlsign/samlsign.cpp                                |  4 ++--
 samlsign/samlsign.rc                                 | 12 ++++++------
 43 files changed, 96 insertions(+), 96 deletions(-)

diff --git a/config_win32.h b/config_win32.h
index ec24c89..56d2b84 100644
--- a/config_win32.h
+++ b/config_win32.h
@@ -81,13 +81,13 @@
 #define PACKAGE_NAME "opensaml"
 
 /* Define to the full name and version of this package. */
-#define PACKAGE_STRING "opensaml 3.2.1"
+#define PACKAGE_STRING "opensaml 3.3.0"
 
 /* Define to the one symbol short name of this package. */
 #define PACKAGE_TARNAME "opensaml"
 
 /* Define to the version of this package. */
-#define PACKAGE_VERSION "3.2.1"
+#define PACKAGE_VERSION "3.3.0"
 
 /* Define to the necessary symbol if this constant uses a non-standard name on
    your system. */
@@ -100,7 +100,7 @@
 /* #undef TM_IN_SYS_TIME */
 
 /* Version number of package */
-#define VERSION "3.2.1"
+#define VERSION "3.3.0"
 
 /* Define to empty if `const' does not conform to ANSI C. */
 /* #undef const */
diff --git a/configure.ac b/configure.ac
index 66d83dd..21d0a54 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,5 @@
 AC_PREREQ([2.50])
-AC_INIT([opensaml],[3.2.1],[https://issues.shibboleth.net/],[opensaml])
+AC_INIT([opensaml],[3.3.0],[https://issues.shibboleth.net/],[opensaml])
 AC_CONFIG_SRCDIR(saml)
 AC_CONFIG_AUX_DIR(build-aux)
 AC_CONFIG_MACRO_DIR(m4)
diff --git a/opensaml.spec.in b/opensaml.spec.in
index de703ee..e0951b0 100644
--- a/opensaml.spec.in
+++ b/opensaml.spec.in
@@ -45,13 +45,13 @@ that support the SAML 1.0, 1.1, and 2.0 specifications.
 
 This package contains the utility programs.
 
-%package -n libsaml12
+%package -n libsaml13
 Summary:    OpenSAML SAML library
 Group:      Development/Libraries/C and C++
 Provides:   @PACKAGE_NAME@ = %{version}-%{release}
 Obsoletes:  @PACKAGE_NAME@ < %{version}-%{release}
 
-%description -n libsaml12
+%description -n libsaml13
 OpenSAML is an open source implementation of the OASIS Security Assertion
 Markup Language Specification. It contains a set of open source C++ classes
 that support the SAML 1.0, 1.1, and 2.0 specifications.
@@ -61,7 +61,7 @@ This package contains just the shared library.
 %package -n libsaml-devel
 Summary:	OpenSAML development Headers
 Group:		Development/Libraries/C and C++
-Requires:	libsaml12 = %{version}-%{release}
+Requires:	libsaml13 = %{version}-%{release}
 Provides:	@PACKAGE_NAME at -devel = %{version}-%{release}
 Obsoletes:	@PACKAGE_NAME at -devel < %{version}-%{release}
 Requires: libxerces-c-devel >= 3.2
@@ -110,15 +110,15 @@ This package includes XML schemas and related files.
 %clean
 [ "$RPM_BUILD_ROOT" != "/" ] && %{__rm} -rf $RPM_BUILD_ROOT
 
-%post -n libsaml12 -p /sbin/ldconfig
+%post -n libsaml13 -p /sbin/ldconfig
 
-%postun -n libsaml12 -p /sbin/ldconfig
+%postun -n libsaml13 -p /sbin/ldconfig
 
 %files -n @PACKAGE_NAME at -bin
 %defattr(-,root,root,-)
 %{_bindir}/samlsign
 
-%files -n libsaml12
+%files -n libsaml13
 %defattr(-,root,root,-)
 %{_libdir}/libsaml.so.*
 %exclude %{_libdir}/libsaml.la
@@ -136,6 +136,9 @@ This package includes XML schemas and related files.
 %doc %{pkgdocdir}
 
 %changelog
+* Mon Sep 9 2024 Scott Cantor <cantor.2 at osu.edu> - 3.3.0-1
+- Version and lib bump
+
 * Wed Dec 2 2020 Scott Cantor <cantor.2 at osu.edu> - 3.2.0-1
 - Version and lib bump
 
diff --git a/saml/Makefile.am b/saml/Makefile.am
index 3ce4eee..39d3cef 100644
--- a/saml/Makefile.am
+++ b/saml/Makefile.am
@@ -183,7 +183,7 @@ libsaml_la_SOURCES = \
 
 # this is different from the project version
 # http://sources.redhat.com/autobook/autobook/autobook_91.html
-libsaml_la_LDFLAGS = -version-info 12:1:0
+libsaml_la_LDFLAGS = -version-info 13:0:0
 libsaml_la_CPPFLAGS = \
     $(BOOST_CPPFLAGS)
 libsaml_la_CXXFLAGS = \
diff --git a/saml/binding/impl/MessageDecoder.cpp b/saml/binding/impl/MessageDecoder.cpp
index d2d60d9..15d0fe1 100644
--- a/saml/binding/impl/MessageDecoder.cpp
+++ b/saml/binding/impl/MessageDecoder.cpp
@@ -128,10 +128,10 @@ XMLObject* MessageDecoder::decode(
 }
 
 XMLObject* MessageDecoder::decode(
-    std::string& relayState,
-    const xmltooling::GenericRequest& genericRequest,
-    xmltooling::GenericResponse* genericResponse,
-    SecurityPolicy& policy
+    std::string&,
+    const xmltooling::GenericRequest&,
+    xmltooling::GenericResponse*,
+    SecurityPolicy&
     ) const
 {
     throw BindingException("Unimplemented decode method");
diff --git a/saml/saml.rc b/saml/saml.rc
index b7a75c3..f1d19c8 100644
--- a/saml/saml.rc
+++ b/saml/saml.rc
@@ -28,8 +28,8 @@ LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
 //
 
 VS_VERSION_INFO VERSIONINFO
- FILEVERSION 3,2,1,5
- PRODUCTVERSION 3,2,1,5
+ FILEVERSION 3,3,0,0
+ PRODUCTVERSION 3,3,0,0
  FILEFLAGSMASK 0x3fL
 #ifdef _DEBUG
  FILEFLAGS 0x1L
@@ -47,22 +47,22 @@ BEGIN
             VALUE "Comments", "\0"
             VALUE "CompanyName", "Shibboleth Consortium\0"
             VALUE "FileDescription", "OpenSAML Library\0"
-            VALUE "FileVersion", "3, 2, 1, 5\0"
+            VALUE "FileVersion", "3, 3, 0, 0\0"
 #ifdef _DEBUG
-            VALUE "InternalName", "saml3_2D\0"
+            VALUE "InternalName", "saml3_3D\0"
 #else
-            VALUE "InternalName", "saml3_2\0"
+            VALUE "InternalName", "saml3_3\0"
 #endif
-            VALUE "LegalCopyright", "Copyright 2023 Various\0"
+            VALUE "LegalCopyright", "Copyright 2001-2024 Various\0"
             VALUE "LegalTrademarks", "\0"
 #ifdef _DEBUG
-            VALUE "OriginalFilename", "saml3_2D.dll\0"
+            VALUE "OriginalFilename", "saml3_3.dll\0"
 #else
-            VALUE "OriginalFilename", "saml3_2.dll\0"
+            VALUE "OriginalFilename", "saml3_3.dll\0"
 #endif
             VALUE "PrivateBuild", "\0"
-            VALUE "ProductName", "OpenSAML 3.2.1\0"
-            VALUE "ProductVersion", "3, 2, 1, 5\0"
+            VALUE "ProductName", "OpenSAML 3.3.0\0"
+            VALUE "ProductVersion", "3, 3, 0, 0\0"
             VALUE "SpecialBuild", "\0"
         END
     END
diff --git a/saml/saml1/binding/impl/SAML1ArtifactDecoder.cpp b/saml/saml1/binding/impl/SAML1ArtifactDecoder.cpp
index d131668..f4ac504 100644
--- a/saml/saml1/binding/impl/SAML1ArtifactDecoder.cpp
+++ b/saml/saml1/binding/impl/SAML1ArtifactDecoder.cpp
@@ -74,7 +74,7 @@ namespace opensaml {
 XMLObject* SAML1ArtifactDecoder::decode(
     string& relayState,
     const GenericRequest& genericRequest,
-    GenericResponse* genericResponse,
+    GenericResponse*,
     SecurityPolicy& policy
     ) const
 {
diff --git a/saml/saml1/binding/impl/SAML1ArtifactEncoder.cpp b/saml/saml1/binding/impl/SAML1ArtifactEncoder.cpp
index 085fe3c..52b6326 100644
--- a/saml/saml1/binding/impl/SAML1ArtifactEncoder.cpp
+++ b/saml/saml1/binding/impl/SAML1ArtifactEncoder.cpp
@@ -89,9 +89,9 @@ long SAML1ArtifactEncoder::encode(
     const EntityDescriptor* recipient,
     const char* relayState,
     const ArtifactGenerator* artifactGenerator,
-    const Credential* credential,
-    const XMLCh* signatureAlg,
-    const XMLCh* digestAlg
+    const Credential*,
+    const XMLCh*,
+    const XMLCh*
     ) const
 {
 #ifdef _DEBUG
diff --git a/saml/saml1/binding/impl/SAML1MessageDecoder.cpp b/saml/saml1/binding/impl/SAML1MessageDecoder.cpp
index 4a37db9..603a9cd 100644
--- a/saml/saml1/binding/impl/SAML1MessageDecoder.cpp
+++ b/saml/saml1/binding/impl/SAML1MessageDecoder.cpp
@@ -56,7 +56,7 @@ const XMLCh* SAML1MessageDecoder::getProtocolFamily() const
 }
 
 void SAML1MessageDecoder::extractMessageDetails(
-    const XMLObject& message, const GenericRequest& req, const XMLCh* protocol, SecurityPolicy& policy
+    const XMLObject& message, const GenericRequest&, const XMLCh* protocol, SecurityPolicy& policy
     ) const
 {
     // Only handle SAML 1.x protocol messages.
diff --git a/saml/saml1/binding/impl/SAML1POSTDecoder.cpp b/saml/saml1/binding/impl/SAML1POSTDecoder.cpp
index 83a17eb..e408f46 100644
--- a/saml/saml1/binding/impl/SAML1POSTDecoder.cpp
+++ b/saml/saml1/binding/impl/SAML1POSTDecoder.cpp
@@ -77,7 +77,7 @@ namespace opensaml {
 XMLObject* SAML1POSTDecoder::decode(
     string& relayState,
     const GenericRequest& genericRequest,
-    GenericResponse* genericResponse,
+    GenericResponse*,
     SecurityPolicy& policy
     ) const
 {
diff --git a/saml/saml1/binding/impl/SAML1POSTEncoder.cpp b/saml/saml1/binding/impl/SAML1POSTEncoder.cpp
index 068e282..b208074 100644
--- a/saml/saml1/binding/impl/SAML1POSTEncoder.cpp
+++ b/saml/saml1/binding/impl/SAML1POSTEncoder.cpp
@@ -113,9 +113,9 @@ long SAML1POSTEncoder::encode(
     GenericResponse& genericResponse,
     XMLObject* xmlObject,
     const char* destination,
-    const EntityDescriptor* recipient,
+    const EntityDescriptor*,
     const char* relayState,
-    const ArtifactGenerator* artifactGenerator,
+    const ArtifactGenerator*,
     const Credential* credential,
     const XMLCh* signatureAlg,
     const XMLCh* digestAlg
diff --git a/saml/saml1/binding/impl/SAML1SOAPDecoder.cpp b/saml/saml1/binding/impl/SAML1SOAPDecoder.cpp
index 8aaf548..5525490 100644
--- a/saml/saml1/binding/impl/SAML1SOAPDecoder.cpp
+++ b/saml/saml1/binding/impl/SAML1SOAPDecoder.cpp
@@ -73,9 +73,9 @@ namespace opensaml {
 };
 
 XMLObject* SAML1SOAPDecoder::decode(
-    string& relayState,
+    string&,
     const GenericRequest& genericRequest,
-    GenericResponse* genericResponse,
+    GenericResponse*,
     SecurityPolicy& policy
     ) const
 {
diff --git a/saml/saml1/binding/impl/SAML1SOAPEncoder.cpp b/saml/saml1/binding/impl/SAML1SOAPEncoder.cpp
index d86149d..9da4048 100644
--- a/saml/saml1/binding/impl/SAML1SOAPEncoder.cpp
+++ b/saml/saml1/binding/impl/SAML1SOAPEncoder.cpp
@@ -85,10 +85,10 @@ namespace opensaml {
 long SAML1SOAPEncoder::encode(
     GenericResponse& genericResponse,
     XMLObject* xmlObject,
-    const char* destination,
-    const EntityDescriptor* recipient,
-    const char* relayState,
-    const ArtifactGenerator* artifactGenerator,
+    const char*,
+    const EntityDescriptor*,
+    const char*,
+    const ArtifactGenerator*,
     const Credential* credential,
     const XMLCh* signatureAlg,
     const XMLCh* digestAlg
diff --git a/saml/saml1/binding/impl/SAMLArtifactType0001.cpp b/saml/saml1/binding/impl/SAMLArtifactType0001.cpp
index d8110f8..3010b61 100644
--- a/saml/saml1/binding/impl/SAMLArtifactType0001.cpp
+++ b/saml/saml1/binding/impl/SAMLArtifactType0001.cpp
@@ -68,7 +68,7 @@ SAMLArtifactType0001::SAMLArtifactType0001(const string& sourceid)
     m_raw.append(sourceid,0,SOURCEID_LENGTH);
     char buf[HANDLE_LENGTH];
     SAMLConfig::getConfig().generateRandomBytes(buf,HANDLE_LENGTH);
-    for (int i=0; i<HANDLE_LENGTH; i++)
+    for (unsigned int i=0; i<HANDLE_LENGTH; i++)
         m_raw+=buf[i];
 }
 
diff --git a/saml/saml1/binding/impl/SAMLArtifactType0002.cpp b/saml/saml1/binding/impl/SAMLArtifactType0002.cpp
index 1276f7f..234a0a5 100644
--- a/saml/saml1/binding/impl/SAMLArtifactType0002.cpp
+++ b/saml/saml1/binding/impl/SAMLArtifactType0002.cpp
@@ -66,7 +66,7 @@ SAMLArtifactType0002::SAMLArtifactType0002(const string& sourceLocation)
     m_raw+=(char)0x2;
     char buf[HANDLE_LENGTH];
     SAMLConfig::getConfig().generateRandomBytes(buf,HANDLE_LENGTH);
-    for (int i=0; i<HANDLE_LENGTH; i++)
+    for (unsigned int i=0; i<HANDLE_LENGTH; i++)
         m_raw+=buf[i];
     m_raw+=sourceLocation;
 }
diff --git a/saml/saml1/core/impl/AssertionsImpl.cpp b/saml/saml1/core/impl/AssertionsImpl.cpp
index 2547218..592207d 100644
--- a/saml/saml1/core/impl/AssertionsImpl.cpp
+++ b/saml/saml1/core/impl/AssertionsImpl.cpp
@@ -757,7 +757,7 @@ namespace opensaml {
                 MARSHALL_STRING_ATTRIB(AttributeNamespace,ATTRIBUTENAMESPACE,nullptr);
             }
 
-            void processChildElement(XMLObject* childXMLObject, const DOMElement* root) {
+            void processChildElement(XMLObject* childXMLObject, const DOMElement*) {
                 getAttributeValues().push_back(childXMLObject);
             }
 
diff --git a/saml/saml1/core/impl/ProtocolsImpl.cpp b/saml/saml1/core/impl/ProtocolsImpl.cpp
index 45f7961..5c214dc 100644
--- a/saml/saml1/core/impl/ProtocolsImpl.cpp
+++ b/saml/saml1/core/impl/ProtocolsImpl.cpp
@@ -590,7 +590,7 @@ namespace opensaml {
             IMPL_XMLOBJECT_CHILDREN(UnknownXMLObject,m_children.end());
 
         protected:
-            void processChildElement(XMLObject* childXMLObject, const DOMElement* root) {
+            void processChildElement(XMLObject* childXMLObject, const DOMElement*) {
                 getUnknownXMLObjects().push_back(childXMLObject);
             }
         };
diff --git a/saml/saml2/binding/impl/SAML2ArtifactType0004.cpp b/saml/saml2/binding/impl/SAML2ArtifactType0004.cpp
index aa2786f..1f023ac 100644
--- a/saml/saml2/binding/impl/SAML2ArtifactType0004.cpp
+++ b/saml/saml2/binding/impl/SAML2ArtifactType0004.cpp
@@ -68,7 +68,7 @@ SAML2ArtifactType0004::SAML2ArtifactType0004(const string& sourceid, int index)
     m_raw.append(sourceid,0,SOURCEID_LENGTH);
     char buf[HANDLE_LENGTH];
     SAMLConfig::getConfig().generateRandomBytes(buf,HANDLE_LENGTH);
-    for (int i=0; i<HANDLE_LENGTH; i++)
+    for (unsigned int i=0; i<HANDLE_LENGTH; i++)
         m_raw+=buf[i];
 }
 
diff --git a/saml/saml2/binding/impl/SAML2ECPEncoder.cpp b/saml/saml2/binding/impl/SAML2ECPEncoder.cpp
index 1f3741a..5f3a886 100644
--- a/saml/saml2/binding/impl/SAML2ECPEncoder.cpp
+++ b/saml/saml2/binding/impl/SAML2ECPEncoder.cpp
@@ -112,10 +112,10 @@ SAML2ECPEncoder::SAML2ECPEncoder(const DOMElement* e)
 long SAML2ECPEncoder::encode(
     GenericResponse& genericResponse,
     XMLObject* xmlObject,
-    const char* destination,
-    const EntityDescriptor* recipient,
+    const char*,
+    const EntityDescriptor*,
     const char* relayState,
-    const ArtifactGenerator* artifactGenerator,
+    const ArtifactGenerator*,
     const Credential* credential,
     const XMLCh* signatureAlg,
     const XMLCh* digestAlg
diff --git a/saml/saml2/binding/impl/SAML2MessageDecoder.cpp b/saml/saml2/binding/impl/SAML2MessageDecoder.cpp
index 76bae6a..efbc18c 100644
--- a/saml/saml2/binding/impl/SAML2MessageDecoder.cpp
+++ b/saml/saml2/binding/impl/SAML2MessageDecoder.cpp
@@ -118,7 +118,7 @@ void SAML2MessageDecoder::extractCorrelationID(
 }
 
 void SAML2MessageDecoder::extractMessageDetails(
-    const XMLObject& message, const GenericRequest& request, const XMLCh* protocol, SecurityPolicy& policy
+    const XMLObject& message, const GenericRequest&, const XMLCh* protocol, SecurityPolicy& policy
     ) const
 {
     // Only handle SAML 2.0 messages.
diff --git a/saml/saml2/binding/impl/SAML2POSTEncoder.cpp b/saml/saml2/binding/impl/SAML2POSTEncoder.cpp
index ed84214..43ef047 100644
--- a/saml/saml2/binding/impl/SAML2POSTEncoder.cpp
+++ b/saml/saml2/binding/impl/SAML2POSTEncoder.cpp
@@ -119,9 +119,9 @@ long SAML2POSTEncoder::encode(
     GenericResponse& genericResponse,
     XMLObject* xmlObject,
     const char* destination,
-    const EntityDescriptor* recipient,
+    const EntityDescriptor*,
     const char* relayState,
-    const ArtifactGenerator* artifactGenerator,
+    const ArtifactGenerator*,
     const Credential* credential,
     const XMLCh* signatureAlg,
     const XMLCh* digestAlg
diff --git a/saml/saml2/binding/impl/SAML2RedirectEncoder.cpp b/saml/saml2/binding/impl/SAML2RedirectEncoder.cpp
index 2e867d3..154363c 100644
--- a/saml/saml2/binding/impl/SAML2RedirectEncoder.cpp
+++ b/saml/saml2/binding/impl/SAML2RedirectEncoder.cpp
@@ -85,12 +85,12 @@ long SAML2RedirectEncoder::encode(
     GenericResponse& genericResponse,
     XMLObject* xmlObject,
     const char* destination,
-    const EntityDescriptor* recipient,
+    const EntityDescriptor*,
     const char* relayState,
-    const ArtifactGenerator* artifactGenerator,
+    const ArtifactGenerator*,
     const Credential* credential,
     const XMLCh* signatureAlg,
-    const XMLCh* digestAlg
+    const XMLCh*
     ) const
 {
 #ifdef _DEBUG
diff --git a/saml/saml2/binding/impl/SAML2SOAPDecoder.cpp b/saml/saml2/binding/impl/SAML2SOAPDecoder.cpp
index 812342b..478dd52 100644
--- a/saml/saml2/binding/impl/SAML2SOAPDecoder.cpp
+++ b/saml/saml2/binding/impl/SAML2SOAPDecoder.cpp
@@ -73,9 +73,9 @@ namespace opensaml {
 };
 
 XMLObject* SAML2SOAPDecoder::decode(
-    string& relayState,
+    string&,
     const GenericRequest& genericRequest,
-    GenericResponse* genericResponse,
+    GenericResponse*,
     SecurityPolicy& policy
     ) const
 {
diff --git a/saml/saml2/binding/impl/SAML2SOAPEncoder.cpp b/saml/saml2/binding/impl/SAML2SOAPEncoder.cpp
index a8785b0..fc4cef0 100644
--- a/saml/saml2/binding/impl/SAML2SOAPEncoder.cpp
+++ b/saml/saml2/binding/impl/SAML2SOAPEncoder.cpp
@@ -81,10 +81,10 @@ namespace opensaml {
 long SAML2SOAPEncoder::encode(
     GenericResponse& genericResponse,
     XMLObject* xmlObject,
-    const char* destination,
-    const EntityDescriptor* recipient,
-    const char* relayState,
-    const ArtifactGenerator* artifactGenerator,
+    const char*,
+    const EntityDescriptor*,
+    const char*,
+    const ArtifactGenerator*,
     const Credential* credential,
     const XMLCh* signatureAlg,
     const XMLCh* digestAlg
diff --git a/saml/saml2/core/impl/Assertions20Impl.cpp b/saml/saml2/core/impl/Assertions20Impl.cpp
index e002e5b..9173d7c 100644
--- a/saml/saml2/core/impl/Assertions20Impl.cpp
+++ b/saml/saml2/core/impl/Assertions20Impl.cpp
@@ -1202,7 +1202,7 @@ namespace opensaml {
                 marshallExtensionAttributes(domElement);
             }
 
-            void processChildElement(XMLObject* childXMLObject, const DOMElement* root) {
+            void processChildElement(XMLObject* childXMLObject, const DOMElement*) {
                 getAttributeValues().push_back(childXMLObject);
             }
 
diff --git a/saml/saml2/core/impl/Protocols20Impl.cpp b/saml/saml2/core/impl/Protocols20Impl.cpp
index 85a5ec8..a572028 100644
--- a/saml/saml2/core/impl/Protocols20Impl.cpp
+++ b/saml/saml2/core/impl/Protocols20Impl.cpp
@@ -195,7 +195,7 @@ namespace opensaml {
             IMPL_XMLOBJECT_CHILDREN(UnknownXMLObject,m_children.end());
 
         protected:
-            void processChildElement(XMLObject* childXMLObject, const DOMElement* root) {
+            void processChildElement(XMLObject* childXMLObject, const DOMElement*) {
                 getUnknownXMLObjects().push_back(childXMLObject);
             }
         };
diff --git a/saml/saml2/metadata/impl/EntityAttributesEntityMatcher.cpp b/saml/saml2/metadata/impl/EntityAttributesEntityMatcher.cpp
index d70422f..671475c 100644
--- a/saml/saml2/metadata/impl/EntityAttributesEntityMatcher.cpp
+++ b/saml/saml2/metadata/impl/EntityAttributesEntityMatcher.cpp
@@ -66,7 +66,7 @@ namespace opensaml {
             Category& m_log;
         };
 
-        EntityMatcher* SAML_DLLLOCAL EntityAttributesEntityMatcherFactory(const DOMElement* const & e, bool deprecationSupport)
+        EntityMatcher* SAML_DLLLOCAL EntityAttributesEntityMatcherFactory(const DOMElement* const & e, bool)
         {
             return new EntityAttributesEntityMatcher(e);
         }
diff --git a/saml/saml2/metadata/impl/EntityRoleMetadataFilter.cpp b/saml/saml2/metadata/impl/EntityRoleMetadataFilter.cpp
index aff30cc..0547611 100644
--- a/saml/saml2/metadata/impl/EntityRoleMetadataFilter.cpp
+++ b/saml/saml2/metadata/impl/EntityRoleMetadataFilter.cpp
@@ -58,7 +58,7 @@ namespace opensaml {
             bool m_idp, m_sp, m_authn, m_attr, m_pdp, m_authnq, m_attrq, m_authzq;
         };
 
-        MetadataFilter* SAML_DLLLOCAL EntityRoleMetadataFilterFactory(const DOMElement* const & e, bool deprecationSupport)
+        MetadataFilter* SAML_DLLLOCAL EntityRoleMetadataFilterFactory(const DOMElement* const & e, bool)
         {
             return new EntityRoleMetadataFilter(e);
         }
@@ -102,7 +102,7 @@ EntityRoleMetadataFilter::EntityRoleMetadataFilter(const DOMElement* e)
     }
 }
 
-void EntityRoleMetadataFilter::doFilter(const MetadataFilterContext* ctx, XMLObject& xmlObject) const
+void EntityRoleMetadataFilter::doFilter(const MetadataFilterContext*, XMLObject& xmlObject) const
 {
     EntitiesDescriptor* group = dynamic_cast<EntitiesDescriptor*>(&xmlObject);
     if (group) {
diff --git a/saml/saml2/metadata/impl/ExcludeMetadataFilter.cpp b/saml/saml2/metadata/impl/ExcludeMetadataFilter.cpp
index 50e82f9..9939189 100644
--- a/saml/saml2/metadata/impl/ExcludeMetadataFilter.cpp
+++ b/saml/saml2/metadata/impl/ExcludeMetadataFilter.cpp
@@ -58,7 +58,7 @@ namespace opensaml {
             scoped_ptr<EntityMatcher> m_matcher;
         }; 
 
-        MetadataFilter* SAML_DLLLOCAL ExcludeMetadataFilterFactory(const DOMElement* const & e, bool deprecationSupport)
+        MetadataFilter* SAML_DLLLOCAL ExcludeMetadataFilterFactory(const DOMElement* const & e, bool)
         {
             return new ExcludeMetadataFilter(e);
         }
@@ -86,7 +86,7 @@ ExcludeMetadataFilter::ExcludeMetadataFilter(const DOMElement* e, bool deprecati
     }
 }
 
-void ExcludeMetadataFilter::doFilter(const MetadataFilterContext* ctx, XMLObject& xmlObject) const
+void ExcludeMetadataFilter::doFilter(const MetadataFilterContext*, XMLObject& xmlObject) const
 {
     EntitiesDescriptor* group = dynamic_cast<EntitiesDescriptor*>(&xmlObject);
     if (group) {
diff --git a/saml/saml2/metadata/impl/FolderMetadataProvider.cpp b/saml/saml2/metadata/impl/FolderMetadataProvider.cpp
index c450e84..6235748 100644
--- a/saml/saml2/metadata/impl/FolderMetadataProvider.cpp
+++ b/saml/saml2/metadata/impl/FolderMetadataProvider.cpp
@@ -60,7 +60,7 @@ namespace opensaml {
         static const XMLCh _type[] =                UNICODE_LITERAL_4(t,y,p,e);
         static const XMLCh _XML[] =                 UNICODE_LITERAL_3(X,M,L);
     
-        static void FolderCallback(const char* pathname, struct stat& stat_buf, void* data) {
+        static void FolderCallback(const char* pathname, struct stat&, void* data) {
             // data is a pair of DOM elements, the config root and the mocked up Chaining child
             pair<const DOMElement*,DOMElement*>* p = reinterpret_cast<pair<const DOMElement*,DOMElement*>*>(data);
             auto_ptr_XMLCh entry(pathname);
diff --git a/saml/saml2/metadata/impl/IncludeMetadataFilter.cpp b/saml/saml2/metadata/impl/IncludeMetadataFilter.cpp
index 3e553d0..764e6a8 100644
--- a/saml/saml2/metadata/impl/IncludeMetadataFilter.cpp
+++ b/saml/saml2/metadata/impl/IncludeMetadataFilter.cpp
@@ -60,7 +60,7 @@ namespace opensaml {
             scoped_ptr<EntityMatcher> m_matcher;
         };
 
-        MetadataFilter* SAML_DLLLOCAL IncludeMetadataFilterFactory(const DOMElement* const & e, bool deprecationSupport)
+        MetadataFilter* SAML_DLLLOCAL IncludeMetadataFilterFactory(const DOMElement* const & e, bool)
         {
             return new IncludeMetadataFilter(e);
         }
@@ -88,7 +88,7 @@ IncludeMetadataFilter::IncludeMetadataFilter(const DOMElement* e, bool deprecati
     }
 }
 
-void IncludeMetadataFilter::doFilter(const MetadataFilterContext* ctx, XMLObject& xmlObject) const
+void IncludeMetadataFilter::doFilter(const MetadataFilterContext*, XMLObject& xmlObject) const
 {
     EntitiesDescriptor* group = dynamic_cast<EntitiesDescriptor*>(&xmlObject);
     if (group) {
diff --git a/saml/saml2/metadata/impl/LocalDynamicMetadataProvider.cpp b/saml/saml2/metadata/impl/LocalDynamicMetadataProvider.cpp
index ec05115..cc8c38c 100644
--- a/saml/saml2/metadata/impl/LocalDynamicMetadataProvider.cpp
+++ b/saml/saml2/metadata/impl/LocalDynamicMetadataProvider.cpp
@@ -51,7 +51,6 @@ using namespace xmltooling::logging;
 using namespace xmltooling;
 using namespace std;
 
-static const XMLCh id[] =                   UNICODE_LITERAL_2(i,d);
 static const XMLCh sourceDirectory[] =      UNICODE_LITERAL_15(s,o,u,r,c,e,D,i,r,e,c,t,o,r,y);
 
 namespace opensaml {
@@ -75,7 +74,7 @@ namespace opensaml {
             string m_sourceDirectory;
         };
 
-        MetadataProvider* SAML_DLLLOCAL LocalDynamicMetadataProviderFactory(const DOMElement* const & e, bool deprecationSupport)
+        MetadataProvider* SAML_DLLLOCAL LocalDynamicMetadataProviderFactory(const DOMElement* const & e, bool)
         {
             return new LocalDynamicMetadataProvider(e);
         }
diff --git a/saml/saml2/metadata/impl/MetadataImpl.cpp b/saml/saml2/metadata/impl/MetadataImpl.cpp
index 681f6a6..98647be 100644
--- a/saml/saml2/metadata/impl/MetadataImpl.cpp
+++ b/saml/saml2/metadata/impl/MetadataImpl.cpp
@@ -1065,7 +1065,7 @@ namespace opensaml {
             IMPL_XMLOBJECT_CHILDREN(UnknownXMLObject,m_children.end());
 
         protected:
-            void processChildElement(XMLObject* childXMLObject, const DOMElement* root) {
+            void processChildElement(XMLObject* childXMLObject, const DOMElement*) {
                 getUnknownXMLObjects().push_back(childXMLObject);
             }
         };
@@ -1288,7 +1288,7 @@ namespace opensaml {
                 marshallExtensionAttributes(domElement);
             }
 
-            void processChildElement(XMLObject* childXMLObject, const DOMElement* root) {
+            void processChildElement(XMLObject* childXMLObject, const DOMElement*) {
                 getAttributeValues().push_back(childXMLObject);
             }
 
@@ -2235,7 +2235,7 @@ namespace opensaml {
                 MARSHALL_STRING_ATTRIB(Algorithm,ALGORITHM,nullptr);
             }
 
-            void processChildElement(XMLObject* childXMLObject, const DOMElement* root) {
+            void processChildElement(XMLObject* childXMLObject, const DOMElement*) {
                 // Unknown child.
                 getUnknownXMLObjects().push_back(childXMLObject);
             }
@@ -2289,7 +2289,7 @@ namespace opensaml {
                 MARSHALL_INTEGER_ATTRIB(MaxKeySize,MAXKEYSIZE,nullptr);
             }
 
-            void processChildElement(XMLObject* childXMLObject, const DOMElement* root) {
+            void processChildElement(XMLObject* childXMLObject, const DOMElement*) {
                 // Unknown child.
                 getUnknownXMLObjects().push_back(childXMLObject);
             }
diff --git a/saml/saml2/metadata/impl/MetadataProvider.cpp b/saml/saml2/metadata/impl/MetadataProvider.cpp
index b2aa2a6..fcfd886 100644
--- a/saml/saml2/metadata/impl/MetadataProvider.cpp
+++ b/saml/saml2/metadata/impl/MetadataProvider.cpp
@@ -208,7 +208,7 @@ void MetadataProvider::doFilters(const MetadataFilterContext* ctx, XMLObject& xm
     }
 }
 
-void MetadataProvider::outputStatus(ostream& os) const
+void MetadataProvider::outputStatus(ostream&) const
 {
 }
 
diff --git a/saml/saml2/metadata/impl/NameEntityMatcher.cpp b/saml/saml2/metadata/impl/NameEntityMatcher.cpp
index 7596642..4815a6f 100644
--- a/saml/saml2/metadata/impl/NameEntityMatcher.cpp
+++ b/saml/saml2/metadata/impl/NameEntityMatcher.cpp
@@ -51,7 +51,7 @@ namespace opensaml {
             const XMLCh* m_name;
         };
 
-        EntityMatcher* SAML_DLLLOCAL NameEntityMatcherFactory(const DOMElement* const & e, bool deprecationSupport)
+        EntityMatcher* SAML_DLLLOCAL NameEntityMatcherFactory(const DOMElement* const & e, bool)
         {
             return new NameEntityMatcher(e);
         }
diff --git a/saml/saml2/metadata/impl/NullMetadataProvider.cpp b/saml/saml2/metadata/impl/NullMetadataProvider.cpp
index e6cd543..c171f5d 100644
--- a/saml/saml2/metadata/impl/NullMetadataProvider.cpp
+++ b/saml/saml2/metadata/impl/NullMetadataProvider.cpp
@@ -41,7 +41,7 @@ namespace opensaml {
         class SAML_DLLLOCAL NullMetadataProvider : public AbstractDynamicMetadataProvider
         {
         public:
-            NullMetadataProvider(const DOMElement* e) : AbstractDynamicMetadataProvider(true, e), MetadataProvider(e) {
+            NullMetadataProvider(const DOMElement* e) : MetadataProvider(e), AbstractDynamicMetadataProvider(true, e) {
                 e = XMLHelper::getFirstChildElement(e, samlconstants::SAML20MD_NS, EntityDescriptor::LOCAL_NAME);
                 if (e)
                     m_template.reset(dynamic_cast<EntityDescriptor*>(XMLObjectBuilder::buildOneFromElement(const_cast<DOMElement*>(e))));
@@ -58,14 +58,14 @@ namespace opensaml {
             scoped_ptr<EntityDescriptor> m_template;
         }; 
 
-        MetadataProvider* SAML_DLLLOCAL NullMetadataProviderFactory(const DOMElement* const & e, bool deprecationSupport)
+        MetadataProvider* SAML_DLLLOCAL NullMetadataProviderFactory(const DOMElement* const & e, bool)
         {
             return new NullMetadataProvider(e);
         }
     };
 };
 
-EntityDescriptor* NullMetadataProvider::resolve(const MetadataProvider::Criteria& criteria, string& cacheTag) const
+EntityDescriptor* NullMetadataProvider::resolve(const MetadataProvider::Criteria& criteria, string&) const
 {
     // Resolving for us just means fabricating a new dummy element.
     EntityDescriptor* entity = m_template.get() ? m_template->cloneEntityDescriptor() : EntityDescriptorBuilder::buildEntityDescriptor();
diff --git a/saml/saml2/metadata/impl/RegistrationAuthorityEntityMatcher.cpp b/saml/saml2/metadata/impl/RegistrationAuthorityEntityMatcher.cpp
index 0f851df..83ba0ad 100644
--- a/saml/saml2/metadata/impl/RegistrationAuthorityEntityMatcher.cpp
+++ b/saml/saml2/metadata/impl/RegistrationAuthorityEntityMatcher.cpp
@@ -59,7 +59,7 @@ namespace opensaml {
             Category& m_log;
         };
 
-        EntityMatcher* SAML_DLLLOCAL RegistrationAuthorityEntityMatcherFactory(const DOMElement* const & e, bool deprecationSupport)
+        EntityMatcher* SAML_DLLLOCAL RegistrationAuthorityEntityMatcherFactory(const DOMElement* const & e, bool)
         {
             return new RegistrationAuthorityEntityMatcher(e);
         }
diff --git a/saml/saml2/metadata/impl/RequireValidUntilMetadataFilter.cpp b/saml/saml2/metadata/impl/RequireValidUntilMetadataFilter.cpp
index 41c63a4..b03c55d 100644
--- a/saml/saml2/metadata/impl/RequireValidUntilMetadataFilter.cpp
+++ b/saml/saml2/metadata/impl/RequireValidUntilMetadataFilter.cpp
@@ -52,7 +52,7 @@ namespace opensaml {
             time_t m_maxValidityInterval;
         }; 
 
-        MetadataFilter* SAML_DLLLOCAL RequireValidUntilMetadataFilterFactory(const DOMElement* const & e, bool deprecationSupport)
+        MetadataFilter* SAML_DLLLOCAL RequireValidUntilMetadataFilterFactory(const DOMElement* const & e, bool)
         {
             return new RequireValidUntilMetadataFilter(e);
         }
@@ -67,7 +67,7 @@ RequireValidUntilMetadataFilter::RequireValidUntilMetadataFilter(const DOMElemen
 {
 }
 
-void RequireValidUntilMetadataFilter::doFilter(const MetadataFilterContext* ctx, XMLObject& xmlObject) const
+void RequireValidUntilMetadataFilter::doFilter(const MetadataFilterContext*, XMLObject& xmlObject) const
 {
     const TimeBoundSAMLObject* tbo = dynamic_cast<const TimeBoundSAMLObject*>(&xmlObject);
     if (!tbo)
diff --git a/saml/saml2/metadata/impl/SignatureMetadataFilter.cpp b/saml/saml2/metadata/impl/SignatureMetadataFilter.cpp
index 97fa2ac..7d0fc2a 100644
--- a/saml/saml2/metadata/impl/SignatureMetadataFilter.cpp
+++ b/saml/saml2/metadata/impl/SignatureMetadataFilter.cpp
@@ -84,8 +84,6 @@ static const XMLCh _TrustEngine[] =         UNICODE_LITERAL_11(T,r,u,s,t,E,n,g,i
 static const XMLCh _CredentialResolver[] =  UNICODE_LITERAL_18(C,r,e,d,e,n,t,i,a,l,R,e,s,o,l,v,e,r);
 static const XMLCh type[] =                 UNICODE_LITERAL_4(t,y,p,e);
 static const XMLCh certificate[] =          UNICODE_LITERAL_11(c,e,r,t,i,f,i,c,a,t,e);
-static const XMLCh Certificate[] =          UNICODE_LITERAL_11(C,e,r,t,i,f,i,c,a,t,e);
-static const XMLCh Path[] =                 UNICODE_LITERAL_4(P,a,t,h);
 static const XMLCh verifyBackup[] =         UNICODE_LITERAL_12(v,e,r,i,f,y,B,a,c,k,u,p);
 static const XMLCh verifyRoles[] =          UNICODE_LITERAL_11(v,e,r,i,f,y,R,o,l,e,s);
 static const XMLCh verifyName[] =           UNICODE_LITERAL_10(v,e,r,i,f,y,N,a,m,e);
diff --git a/saml/saml2/profile/impl/SAML2AssertionPolicy.cpp b/saml/saml2/profile/impl/SAML2AssertionPolicy.cpp
index 120f7bb..c8ffb1d 100644
--- a/saml/saml2/profile/impl/SAML2AssertionPolicy.cpp
+++ b/saml/saml2/profile/impl/SAML2AssertionPolicy.cpp
@@ -48,7 +48,7 @@ void SAML2AssertionPolicy::reset(bool messageOnly)
     SAML2AssertionPolicy::_reset(messageOnly);
 }
 
-void SAML2AssertionPolicy::_reset(bool messageOnly)
+void SAML2AssertionPolicy::_reset(bool)
 {
     m_confirmation = nullptr;
 }
diff --git a/saml/version.h b/saml/version.h
index ca38d26..39a62b1 100644
--- a/saml/version.h
+++ b/saml/version.h
@@ -43,8 +43,8 @@
  */
 
 #define OPENSAML_VERSION_MAJOR 3
-#define OPENSAML_VERSION_MINOR 2
-#define OPENSAML_VERSION_REVISION 1
+#define OPENSAML_VERSION_MINOR 3
+#define OPENSAML_VERSION_REVISION 0
 
 /** DO NOT MODIFY BELOW THIS LINE */
 
diff --git a/samlsign/samlsign.cpp b/samlsign/samlsign.cpp
index 6135fc6..c0935bf 100644
--- a/samlsign/samlsign.cpp
+++ b/samlsign/samlsign.cpp
@@ -112,9 +112,9 @@ public:
     Lockable* lock() {return this;}
     void unlock() {}
 
-    const Credential* resolve(const CredentialCriteria* criteria=nullptr) const {return nullptr;}
+    const Credential* resolve(const CredentialCriteria*) const {return nullptr;}
     vector<const Credential*>::size_type resolve(
-        vector<const Credential*>& results, const CredentialCriteria* criteria=nullptr
+        vector<const Credential*>&, const CredentialCriteria*
         ) const {return 0;}
 };
 
diff --git a/samlsign/samlsign.rc b/samlsign/samlsign.rc
index 604d5c8..fab3c5e 100644
--- a/samlsign/samlsign.rc
+++ b/samlsign/samlsign.rc
@@ -28,8 +28,8 @@ LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
 //
 
 VS_VERSION_INFO VERSIONINFO
- FILEVERSION 3,2,1,5
- PRODUCTVERSION 3,2,1,5
+ FILEVERSION 3,3,0,0
+ PRODUCTVERSION 3,3,0,0
  FILEFLAGSMASK 0x3fL
 #ifdef _DEBUG
  FILEFLAGS 0x1L
@@ -47,14 +47,14 @@ BEGIN
             VALUE "Comments", "\0"
             VALUE "CompanyName", "Shibboleth Consortium\0"
             VALUE "FileDescription", "OpenSAML Signature Utility\0"
-            VALUE "FileVersion", "3, 2, 1, 5\0"
+            VALUE "FileVersion", "3, 3, 0, 0\0"
             VALUE "InternalName", "samlsign\0"
-            VALUE "LegalCopyright", "Copyright 2023 Various\0"
+            VALUE "LegalCopyright", "Copyright 2001-2024 Various\0"
             VALUE "LegalTrademarks", "\0"
             VALUE "OriginalFilename", "samlsign.exe\0"
             VALUE "PrivateBuild", "\0"
-            VALUE "ProductName", "OpenSAML 3.2.1\0"
-            VALUE "ProductVersion", "3, 2, 1, 5\0"
+            VALUE "ProductName", "OpenSAML 3.3.0\0"
+            VALUE "ProductVersion", "3, 3, 0, 0\0"
             VALUE "SpecialBuild", "\0"
         END
     END

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list