[java-idp-plugin-webauthn] branch main updated: Fix test

Phil Smart philip.smart at jisc.ac.uk
Tue Sep 10 12:21:48 UTC 2024


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=3712a22c2db43c29ac232c98347d3abaa4a29de5

The following commit(s) were added to refs/heads/main by this push:
     new 3712a22  Fix test
3712a22 is described below

commit 3712a22c2db43c29ac232c98347d3abaa4a29de5
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Tue Sep 10 13:21:45 2024 +0100

    Fix test
---
 .../idp/plugin/authn/webauthn/flow/TestAdminManagementFlow.java  | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/webauthn-impl/src/test/java/net/shibboleth/idp/plugin/authn/webauthn/flow/TestAdminManagementFlow.java b/webauthn-impl/src/test/java/net/shibboleth/idp/plugin/authn/webauthn/flow/TestAdminManagementFlow.java
index 842c529..27890ee 100644
--- a/webauthn-impl/src/test/java/net/shibboleth/idp/plugin/authn/webauthn/flow/TestAdminManagementFlow.java
+++ b/webauthn-impl/src/test/java/net/shibboleth/idp/plugin/authn/webauthn/flow/TestAdminManagementFlow.java
@@ -26,6 +26,7 @@ import org.springframework.webflow.context.ExternalContextHolder;
 import org.springframework.webflow.core.collection.LocalAttributeMap;
 import org.springframework.webflow.engine.impl.FlowExecutionImpl;
 import org.springframework.webflow.executor.FlowExecutionResult;
+import org.testng.annotations.Test;
 
 import com.yubico.webauthn.data.AuthenticatorAssertionResponse;
 import com.yubico.webauthn.data.ByteArray;
@@ -70,7 +71,7 @@ public class TestAdminManagementFlow extends AbstractWebAuthnFlowTest{
     }
     
     @SuppressWarnings("null")
-    //@Test
+    @Test
     public void testManagementFlow_RemoveCredential() throws Exception {
         //Register a credential for use and to delete.
         final CredentialRegistration registration = 
@@ -100,14 +101,12 @@ public class TestAdminManagementFlow extends AbstractWebAuthnFlowTest{
         setHttpFormRequest("POST", Map.of(ExtractKeyRemovalInformationFromFormRequest.DEFAULT_PARAMETER_NAME, 
                 registration.getCredentialIdBase64Url()));
         externalContext.setEventId("deleteKey");
-        result.getSecond().setCurrentState("ManagementView");
-        result.getSecond().resume(externalContext);
-        
         // Add c14n context to simulate c14n flows
         c14n = getProfileRequestContextFromConversation(result.getSecond())
                 .ensureSubcontext(SubjectCanonicalizationContext.class);
         c14n.setPrincipalName(USERNAME);
-        
+        result.getSecond().setCurrentState("ManagementView");
+        result.getSecond().resume(externalContext);
         assertCurrentStateEquals("ManagementView", result.getSecond());
         
         // Now end flow

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list