[java-identity-provider] branch main updated: IDP-2340 Plugin installer doesn't perform (or display) module file changes in certain conditions

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=52e41c0564adda2ffab93ad738af72f2a02c6c5a

The following commit(s) were added to refs/heads/main by this push:
     new 52e41c056 IDP-2340 Plugin installer doesn't perform (or display) module file changes in certain conditions
52e41c056 is described below

commit 52e41c0564adda2ffab93ad738af72f2a02c6c5a
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Mon Oct 28 13:31:24 2024 +0000

    IDP-2340 Plugin installer doesn't perform (or display) module file changes in certain conditions
    
    https://shibboleth.atlassian.net/browse/IDP-2340
    
    Add some logging
---
 .../net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java     | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java b/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java
index 5e133e64d..525ddae2d 100644
--- a/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java
+++ b/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstaller.java
@@ -465,6 +465,7 @@ public final class PluginInstaller extends AbstractInitializableComponent implem
             try {
                 final IdPModule module = modules.next();
                 if (module.isEnabled(getModuleContext())) {
+                    LOG.debug("Found Enabled Module {}",module.getId());
                     enablededModules.add(module.getId());
                 }
             } catch (final ServiceConfigurationError e) {
@@ -620,8 +621,11 @@ public final class PluginInstaller extends AbstractInitializableComponent implem
             for (final IdPModule module: getDescription().getEnableOnInstall()) {
                 moduleId = module.getId();
                 if (!module.isEnabled(getModuleContext())) {
+                    LOG.debug("Enabling Module {}", moduleId);
                     captureChanges(module.enable(getModuleContext()));
                     rollBack.getModulesEnabled().add(module);
+                } else {
+                    LOG.debug("Module {} is already enabled, so not enabling", moduleId);
                 }
             }
         } catch (final ModuleException e) {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.