[java-idp-oidc] 20/35: Refer to the classes already existing in java-oidc-common

Henri Mikkonen henri.mikkonen at iki.fi
Thu Oct 24 14:01:45 UTC 2024


This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch dev/JOIDC-222
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=3bcf1c5b5a212c0b9aef22c025c0bb6a89b52238

commit 3bcf1c5b5a212c0b9aef22c025c0bb6a89b52238
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Wed Oct 9 18:15:05 2024 +0300

    Refer to the classes already existing in java-oidc-common
    
    - Deprecate the following duplicate classes from OP-api:
      - JSONSuccessResponse
      - JSONErrorResponse
    - Delete the following duplicate classes from OP-impl:
      - KeySetSuccessResponse
      - BuildJSONErrorResponseFromEvent
---
 .../oidc/op/messaging/JSONErrorResponse.java       |   5 +
 .../oidc/op/messaging/JSONSuccessResponse.java     |   5 +
 .../oidc/op/messaging/JSONErrorResponseTest.java   |   1 +
 .../oidc/op/messaging/JSONSuccessResponseTest.java |   1 +
 .../plugin/oidc/op/encoding/impl/ResponseUtil.java |   2 +-
 .../op/messaging/impl/KeySetSuccessResponse.java   |  47 -------
 .../impl/OpenIDConfigurationSuccessResponse.java   |   2 +-
 .../impl/BuildJSONErrorResponseFromEvent.java      |  36 ------
 .../oidc-abstract-api-info-beans.xml               |   2 +-
 .../oidc/configuration/configuration-beans.xml     |   9 --
 .../impl/BuildJSONErrorResponseFromEventTest.java  | 135 ---------------------
 .../impl/FormOutboundDiscoveryResponseTest.java    |   2 +-
 12 files changed, 16 insertions(+), 231 deletions(-)

diff --git a/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONErrorResponse.java b/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONErrorResponse.java
index afa55a85..2486a96b 100644
--- a/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONErrorResponse.java
+++ b/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONErrorResponse.java
@@ -24,8 +24,11 @@ import com.nimbusds.oauth2.sdk.http.HTTPResponse;
 
 import net.minidev.json.JSONObject;
 import net.shibboleth.shared.logic.Constraint;
+import net.shibboleth.shared.primitive.DeprecationSupport;
+import net.shibboleth.shared.primitive.DeprecationSupport.ObjectType;
 
 /** Class for creating JSON Error response for requests expecting JSON response. */
+ at Deprecated(since="4.2.0", forRemoval=true)
 public class JSONErrorResponse implements ErrorResponse {
 
     /** Error object. */
@@ -55,6 +58,8 @@ public class JSONErrorResponse implements ErrorResponse {
      */
     public JSONErrorResponse(@Nonnull final ErrorObject errorObject, @Nullable final String cacheControlValue,
             @Nullable final String pragmaValue) {
+        DeprecationSupport.warn(ObjectType.CLASS, getClass().getName(), null,
+                "Use the class in net.shibboleth.oidc.profile.messaging'");
         Constraint.isNotNull(errorObject, "content cannot be null");
         error = errorObject;
         cacheControl = cacheControlValue;
diff --git a/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONSuccessResponse.java b/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONSuccessResponse.java
index 2cdfd317..07464691 100644
--- a/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONSuccessResponse.java
+++ b/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONSuccessResponse.java
@@ -24,8 +24,11 @@ import com.nimbusds.oauth2.sdk.http.HTTPResponse;
 
 import net.minidev.json.JSONObject;
 import net.shibboleth.shared.logic.Constraint;
+import net.shibboleth.shared.primitive.DeprecationSupport;
+import net.shibboleth.shared.primitive.DeprecationSupport.ObjectType;
 
 /** Class for creating JSON Success response. */
+ at Deprecated(since="4.2.0", forRemoval=true)
 public class JSONSuccessResponse implements SuccessResponse {
 
     /** JSON content. */
@@ -56,6 +59,8 @@ public class JSONSuccessResponse implements SuccessResponse {
      */
     public JSONSuccessResponse(@Nonnull final JSONObject contentObject, @Nullable final String cacheControlValue,
             @Nullable final String pragmaValue) {
+        DeprecationSupport.warn(ObjectType.CLASS, getClass().getName(), null,
+                "Use the class in net.shibboleth.oidc.profile.messaging'");
         Constraint.isNotNull(contentObject, "content cannot be null");
         content = contentObject;
         cacheControl = cacheControlValue;
diff --git a/idp-oidc-extension-api/src/test/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONErrorResponseTest.java b/idp-oidc-extension-api/src/test/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONErrorResponseTest.java
index d6ef5e52..aa62a19d 100644
--- a/idp-oidc-extension-api/src/test/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONErrorResponseTest.java
+++ b/idp-oidc-extension-api/src/test/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONErrorResponseTest.java
@@ -26,6 +26,7 @@ import net.minidev.json.parser.ParseException;
 
 /** Tests for {@link JSONErrorResponse}. */
 @SuppressWarnings("null")
+ at Deprecated(since="4.2.0", forRemoval=true)
 public class JSONErrorResponseTest {
 
     private JSONErrorResponse response;
diff --git a/idp-oidc-extension-api/src/test/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONSuccessResponseTest.java b/idp-oidc-extension-api/src/test/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONSuccessResponseTest.java
index eeb0f12f..1e4bb7e6 100644
--- a/idp-oidc-extension-api/src/test/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONSuccessResponseTest.java
+++ b/idp-oidc-extension-api/src/test/java/net/shibboleth/idp/plugin/oidc/op/messaging/JSONSuccessResponseTest.java
@@ -24,6 +24,7 @@ import net.minidev.json.parser.ParseException;
 
 /** Tests for JSONSuccessResponse. */
 @SuppressWarnings("null")
+ at Deprecated(since="4.2.0", forRemoval=true)
 public class JSONSuccessResponseTest {
 
     JSONSuccessResponse response;
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/encoding/impl/ResponseUtil.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/encoding/impl/ResponseUtil.java
index 2ff37364..15e72f90 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/encoding/impl/ResponseUtil.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/encoding/impl/ResponseUtil.java
@@ -58,9 +58,9 @@ import com.nimbusds.openid.connect.sdk.token.OIDCTokens;
 
 import jakarta.servlet.http.HttpServletResponse;
 import net.shibboleth.idp.plugin.oidc.op.decoding.impl.RequestUtil;
-import net.shibboleth.idp.plugin.oidc.op.messaging.JSONSuccessResponse;
 import net.shibboleth.idp.plugin.oidc.op.oauth2.messaging.impl.OAuth2RevocationErrorResponse;
 import net.shibboleth.idp.plugin.oidc.op.oauth2.messaging.impl.OAuth2RevocationSuccessResponse;
+import net.shibboleth.oidc.profile.messaging.JSONSuccessResponse;
 
 /** Response logging helper class. */
 public final class ResponseUtil {
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/KeySetSuccessResponse.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/KeySetSuccessResponse.java
deleted file mode 100644
index c2f424c2..00000000
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/KeySetSuccessResponse.java
+++ /dev/null
@@ -1,47 +0,0 @@
-/*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package net.shibboleth.idp.plugin.oidc.op.messaging.impl;
-
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
-
-import net.minidev.json.JSONObject;
-import net.shibboleth.idp.plugin.oidc.op.messaging.JSONSuccessResponse;
-
-/** KeySet success message class. */
-public class KeySetSuccessResponse extends JSONSuccessResponse {
-
-    /**
-     * Constructor.
-     *
-     * @param contentObject JSON content. MUST not be null.
-     */
-    public KeySetSuccessResponse(@Nonnull final JSONObject contentObject) {
-        super(contentObject);
-    }
-
-    /**
-     * Constructor.
-     * 
-     * @param contentObject JSON content. MUST not be null.
-     * @param cacheControlValue cache control value
-     * @param pragmaValue pragma value
-     */
-    public KeySetSuccessResponse(@Nonnull final JSONObject contentObject, @Nullable final String cacheControlValue,
-            @Nullable final String pragmaValue) {
-        super(contentObject, cacheControlValue, pragmaValue);
-    }
-
-}
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/OpenIDConfigurationSuccessResponse.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/OpenIDConfigurationSuccessResponse.java
index aaa40e92..946f3870 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/OpenIDConfigurationSuccessResponse.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/impl/OpenIDConfigurationSuccessResponse.java
@@ -18,7 +18,7 @@ import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
 import net.minidev.json.JSONObject;
-import net.shibboleth.idp.plugin.oidc.op.messaging.JSONSuccessResponse;
+import net.shibboleth.oidc.profile.messaging.JSONSuccessResponse;
 
 /** OpenID Configuration success message class. */
 public class OpenIDConfigurationSuccessResponse extends JSONSuccessResponse {
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/BuildJSONErrorResponseFromEvent.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/BuildJSONErrorResponseFromEvent.java
deleted file mode 100644
index 6e66e996..00000000
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/BuildJSONErrorResponseFromEvent.java
+++ /dev/null
@@ -1,36 +0,0 @@
-/*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package net.shibboleth.idp.plugin.oidc.op.profile.impl;
-
-import org.opensaml.profile.context.EventContext;
-import org.opensaml.profile.context.ProfileRequestContext;
-import com.nimbusds.oauth2.sdk.ErrorObject;
-
-import net.shibboleth.idp.plugin.oidc.op.messaging.JSONErrorResponse;
-
-/**
- * This action reads an event from the configured {@link EventContext} lookup strategy, constructs a json error response
- * message and attaches it as the outbound message.
- */
-public class BuildJSONErrorResponseFromEvent extends AbstractBuildErrorResponseFromEvent<JSONErrorResponse> {
-
-    /** {@inheritDoc} */
-    @Override
-    protected JSONErrorResponse buildErrorResponse(final ErrorObject error,
-            final ProfileRequestContext profileRequestContext) {
-        return new JSONErrorResponse(error);
-    }
-
-}
diff --git a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/abstract-api-info/oidc-abstract-api-info-beans.xml b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/abstract-api-info/oidc-abstract-api-info-beans.xml
index 885838cf..2d80fe55 100644
--- a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/abstract-api-info/oidc-abstract-api-info-beans.xml
+++ b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/abstract-api-info/oidc-abstract-api-info-beans.xml
@@ -14,7 +14,7 @@
         class="net.shibboleth.idp.plugin.oidc.op.profile.impl.InitializeOutboundResponseMessageContext" scope="prototype" />
 
     <bean id="BuildErrorResponseFromEvent"
-        class="net.shibboleth.idp.plugin.oidc.op.profile.impl.BuildJSONErrorResponseFromEvent" scope="prototype"
+        class="net.shibboleth.oidc.profile.impl.BuildJSONErrorResponseFromEvent" scope="prototype"
         p:defaultStatusCode="500" p:defaultCode="server_error"
         p:httpServletResponseSupplier-ref="shibboleth.HttpServletResponseSupplier">
         <property name="eventContextLookupStrategy">
diff --git a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/configuration/configuration-beans.xml b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/configuration/configuration-beans.xml
index 58ab20ea..986aacc8 100644
--- a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/configuration/configuration-beans.xml
+++ b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/configuration/configuration-beans.xml
@@ -16,15 +16,6 @@
     <util:constant id="shibboleth.metrics.ProfileCounter"
         static-field="net.shibboleth.oidc.profile.config.impl.DefaultOIDCProviderInformationConfiguration.PROFILE_COUNTER" />
 
-    <bean id="BuildErrorResponseFromEvent"
-        class="net.shibboleth.idp.plugin.oidc.op.profile.impl.BuildJSONErrorResponseFromEvent" scope="prototype"
-        p:defaultStatusCode="500" p:defaultCode="server_error"
-        p:httpServletResponseSupplier-ref="shibboleth.HttpServletResponseSupplier">
-        <property name="eventContextLookupStrategy">
-            <bean class="net.shibboleth.idp.profile.context.navigate.WebFlowCurrentEventLookupFunction" />
-        </property>
-    </bean>
-
     <bean id="FormOutboundMessage" class="net.shibboleth.idp.plugin.oidc.op.profile.impl.FormOutboundDiscoveryResponse"
         scope="prototype" p:metadataResolver-ref="#{'%{idp.oidc.discovery.resolver:shibboleth.oidc.DefaultOpenIdConfigurationResolver}'.trim()}" />
 
diff --git a/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/BuildJSONErrorResponseFromEventTest.java b/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/BuildJSONErrorResponseFromEventTest.java
deleted file mode 100644
index 2dfd8cfe..00000000
--- a/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/BuildJSONErrorResponseFromEventTest.java
+++ /dev/null
@@ -1,135 +0,0 @@
-/*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package net.shibboleth.idp.plugin.oidc.op.profile.impl;
-
-import java.util.HashMap;
-import java.util.Map;
-import java.util.function.Function;
-
-import javax.annotation.Nonnull;
-
-import org.mockito.Mockito;
-import org.opensaml.profile.context.EventContext;
-import org.opensaml.profile.context.ProfileRequestContext;
-import org.springframework.webflow.execution.RequestContext;
-import org.testng.Assert;
-import org.testng.annotations.BeforeMethod;
-import org.testng.annotations.Test;
-
-import com.nimbusds.oauth2.sdk.ErrorObject;
-
-import net.shibboleth.idp.plugin.oidc.op.messaging.JSONErrorResponse;
-import net.shibboleth.idp.profile.context.navigate.WebflowRequestContextProfileRequestContextLookup;
-import net.shibboleth.idp.profile.testing.RequestContextBuilder;
-import net.shibboleth.shared.collection.CollectionSupport;
-import net.shibboleth.shared.component.ComponentInitializationException;
-
-/**
- * Unit tests for {@link BuildJSONErrorResponseFromEvent}.
- */
-public class BuildJSONErrorResponseFromEventTest {
-    
-    protected RequestContext requestCtx;
-    protected ProfileRequestContext profileRequestCtx;
-    
-    String eventId = "mockEventId";
-    
-    protected BuildJSONErrorResponseFromEvent initializeAction(@Nonnull Map<String, ErrorObject> mappedErrors, String eventId)
-            throws ComponentInitializationException {
-        BuildJSONErrorResponseFromEvent action = new BuildJSONErrorResponseFromEvent();
-        if (eventId != null) {
-            @SuppressWarnings("unchecked")
-            Function<ProfileRequestContext, EventContext> function = Mockito.mock(Function.class);
-            EventContext eventContext = new EventContext();
-            eventContext.setEvent(eventId);
-            Mockito.when(function.apply((ProfileRequestContext)Mockito.any())).thenReturn(eventContext);
-            action.setEventContextLookupStrategy(function);
-        }
-        action.setMappedErrors(mappedErrors);
-        action.initialize();
-        return action;
-    }
-    
-    protected BuildJSONErrorResponseFromEvent initializeAction(String eventId) throws ComponentInitializationException {
-        return initializeAction(new HashMap<String, ErrorObject>(), eventId);
-    }    
-    
-    protected BuildJSONErrorResponseFromEvent initializeAction() throws ComponentInitializationException {
-        return initializeAction(new HashMap<String, ErrorObject>(), null);
-    }
-
-    @BeforeMethod
-    protected void setUpContext() throws ComponentInitializationException {
-        requestCtx = new RequestContextBuilder().setInboundMessage(null).buildRequestContext();
-        profileRequestCtx = new WebflowRequestContextProfileRequestContextLookup().apply(requestCtx);
-    }
-    
-    @Test
-    public void doPreExecute_shouldReturnFalseWithoutOutboundMessageContext() throws ComponentInitializationException {
-        BuildJSONErrorResponseFromEvent action = initializeAction();
-        profileRequestCtx.setOutboundMessageContext(null);
-        Assert.assertFalse(action.doPreExecute(profileRequestCtx));
-    }
-
-    @Test
-    public void doPreExecute_shouldReturnTrueWithOutboundMessageContext() throws ComponentInitializationException {
-        BuildJSONErrorResponseFromEvent action = initializeAction();
-        assert profileRequestCtx != null;
-        Assert.assertTrue(action.doPreExecute(profileRequestCtx));
-    }
-    
-    @Test
-    public void execute_shouldNotSetMessageWhenNoEventContext() throws ComponentInitializationException {
-        BuildJSONErrorResponseFromEvent action = initializeAction();
-        action.execute(requestCtx);
-        Assert.assertNull(profileRequestCtx.ensureOutboundMessageContext().getMessage());
-    }
-
-    @Test
-    public void execute_shouldSetMessageWhenEventContext() throws ComponentInitializationException {
-        BuildJSONErrorResponseFromEvent action = initializeAction(eventId);
-        action.execute(requestCtx);
-        Object rawMessage = profileRequestCtx.ensureOutboundMessageContext().getMessage();
-        Assert.assertNotNull(rawMessage);
-        Assert.assertTrue(rawMessage instanceof JSONErrorResponse);
-        JSONErrorResponse response = (JSONErrorResponse) rawMessage;
-        assert response != null;
-        ErrorObject error = response.getErrorObject();
-        Assert.assertEquals(error.getCode(), AbstractBuildErrorResponseFromEvent.DEFAULT_ERROR_CODE);
-        Assert.assertEquals(error.getDescription(), eventId);
-        Assert.assertEquals(error.getHTTPStatusCode(), AbstractBuildErrorResponseFromEvent.DEFAULT_HTTP_STATUS_CODE);
-    }
-    
-    @Test
-    public void execute_shouldSetCustomMessageWhenConfiguredAndEventContext() throws ComponentInitializationException {
-        String errorCode = "mockCode";
-        String errorDescription = "mockDescription";
-        int errorStatusCode = 503;
-        assert eventId != null;
-        BuildJSONErrorResponseFromEvent action = initializeAction(CollectionSupport.singletonMap(eventId, 
-                new ErrorObject(errorCode, errorDescription, errorStatusCode)), eventId);
-        action.execute(requestCtx);
-        Object rawMessage = profileRequestCtx.ensureOutboundMessageContext().getMessage();
-        Assert.assertNotNull(rawMessage);
-        Assert.assertTrue(rawMessage instanceof JSONErrorResponse);
-        JSONErrorResponse response = (JSONErrorResponse) rawMessage;
-        assert response != null;
-        ErrorObject error = response.getErrorObject();
-        Assert.assertEquals(error.getCode(), errorCode);
-        Assert.assertEquals(error.getDescription(), errorDescription);
-        Assert.assertEquals(error.getHTTPStatusCode(), errorStatusCode);
-    }
-
-}
diff --git a/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/FormOutboundDiscoveryResponseTest.java b/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/FormOutboundDiscoveryResponseTest.java
index ea4932bf..2d90b668 100644
--- a/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/FormOutboundDiscoveryResponseTest.java
+++ b/idp-oidc-extension-impl/src/test/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/FormOutboundDiscoveryResponseTest.java
@@ -41,7 +41,6 @@ import com.nimbusds.openid.connect.sdk.op.OIDCProviderMetadata;
 
 import jakarta.servlet.http.HttpServletRequest;
 import jakarta.servlet.http.HttpServletResponse;
-import net.shibboleth.idp.plugin.oidc.op.messaging.JSONSuccessResponse;
 import net.shibboleth.idp.plugin.oidc.op.metadata.impl.DynamicFilesystemProviderMetadataResolver;
 import net.shibboleth.idp.plugin.oidc.op.metadata.impl.FilesystemProviderMetadataResolver;
 import net.shibboleth.idp.plugin.oidc.op.metadata.resolver.MetadataValueResolver;
@@ -49,6 +48,7 @@ import net.shibboleth.idp.plugin.oidc.op.metadata.resolver.ProviderMetadataResol
 import net.shibboleth.idp.profile.context.navigate.WebflowRequestContextProfileRequestContextLookup;
 import net.shibboleth.idp.profile.testing.ActionTestingSupport;
 import net.shibboleth.idp.profile.testing.RequestContextBuilder;
+import net.shibboleth.oidc.profile.messaging.JSONSuccessResponse;
 import net.shibboleth.shared.component.ComponentInitializationException;
 import net.shibboleth.shared.primitive.NonnullSupplier;
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list