[java-idp-oidc] 10/35: JOIDC-227 - OIDC RP-init Logout vm Uncaught runtime exception

Henri Mikkonen henri.mikkonen at iki.fi
Thu Oct 24 14:01:35 UTC 2024


This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch dev/JOIDC-222
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=d7ad6e628d014262ca65fc7ee85750b00d2e9050

commit d7ad6e628d014262ca65fc7ee85750b00d2e9050
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Wed Sep 25 13:52:50 2024 +0300

    JOIDC-227 - OIDC RP-init Logout vm Uncaught runtime exception
    
    https://shibboleth.atlassian.net/browse/JOIDC-227
    
    Use '<on-render>' instead of '<on-entry>' within LogoutCompleteView.
---
 .../net/shibboleth/idp/flows/oidc/end-session/end-session-flow.xml    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/end-session/end-session-flow.xml b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/end-session/end-session-flow.xml
index 5f0f5e8e..784b86ce 100644
--- a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/end-session/end-session-flow.xml
+++ b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/end-session/end-session-flow.xml
@@ -185,7 +185,7 @@
 
     <view-state id="LogoutCompleteView" view="logout-complete">
         <attribute name="csrf_excluded" value="true" type="boolean"/>
-        <on-entry>
+        <on-render>
             <evaluate expression="environment" result="viewScope.environment" />
             <evaluate expression="opensamlProfileRequestContext" result="viewScope.profileRequestContext" />
             <evaluate expression="opensamlProfileRequestContext.getSubcontext(T(net.shibboleth.idp.session.context.LogoutContext))" result="viewScope.logoutContext" />
@@ -198,7 +198,7 @@
             <evaluate expression="flowRequestContext.getExternalContext().getNativeRequest()" result="viewScope.request" />
             <evaluate expression="flowRequestContext.getExternalContext().getNativeResponse()" result="viewScope.response" />
             <evaluate expression="flowRequestContext.getActiveFlow().getApplicationContext().containsBean('shibboleth.CustomViewContext') ? flowRequestContext.getActiveFlow().getApplicationContext().getBean('shibboleth.CustomViewContext') : null" result="viewScope.custom" />
-        </on-entry>
+        </on-render>
 
         <transition on="proceed" to="BuildResponseMessage" />
     </view-state>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list