[java-shib-metadata] 02/02: Some cleanup.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-shib-metadata.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-metadata.git;a=commit;h=6f0201476c7d2d8280bc9dadada04b2c8644c634

commit 6f0201476c7d2d8280bc9dadada04b2c8644c634
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed Oct 23 12:48:59 2024 -0400

    Some cleanup.
---
 .../spring/metadata/AbstractDynamicMetadataProviderParser.java       | 2 +-
 .../spring/metadata/AbstractReloadingMetadataProviderParser.java     | 5 +----
 .../net/shibboleth/spring/metadata/filter/PredicateFilterParser.java | 4 ++--
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/AbstractDynamicMetadataProviderParser.java b/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/AbstractDynamicMetadataProviderParser.java
index 685ff1ba..cda65370 100644
--- a/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/AbstractDynamicMetadataProviderParser.java
+++ b/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/AbstractDynamicMetadataProviderParser.java
@@ -44,7 +44,7 @@ public abstract class AbstractDynamicMetadataProviderParser extends AbstractMeta
     
     /** Constructor. */
     public AbstractDynamicMetadataProviderParser() {
-        // Will warn later if not set.
+        // Will fail later if not set.
         parserPoolRef =
                 getCustomProperty(AbstractDynamicMetadataProviderParser.class.getName() + ".ParserPool.bean", null);
     }
diff --git a/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/AbstractReloadingMetadataProviderParser.java b/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/AbstractReloadingMetadataProviderParser.java
index c71bc8d5..c1b66456 100644
--- a/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/AbstractReloadingMetadataProviderParser.java
+++ b/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/AbstractReloadingMetadataProviderParser.java
@@ -33,15 +33,12 @@ import org.w3c.dom.Element;
  */
 public abstract class AbstractReloadingMetadataProviderParser extends AbstractMetadataProviderParser {
 
-    /** The reference to the system parser pool that we set up. */
-    @Nonnull @NotEmpty private static final String DEFAULT_PARSER_POOL_REF = "shibboleth.ParserPool";
-
     /** Bean ID for defaulted {@link ParserPool} instance. */
     @Nullable private final String parserPoolRef;
     
     /** Constructor. */
     public AbstractReloadingMetadataProviderParser() {
-        // Will warn later if not set.
+        // Will fail later if not set.
         parserPoolRef =
                 getCustomProperty(AbstractReloadingMetadataProviderParser.class.getName() + ".ParserPool.bean", null);
     }
diff --git a/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/PredicateFilterParser.java b/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/PredicateFilterParser.java
index 265a6cf5..f2fe6c2b 100644
--- a/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/PredicateFilterParser.java
+++ b/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/PredicateFilterParser.java
@@ -104,7 +104,7 @@ public class PredicateFilterParser extends AbstractMetadataFilterParser {
         }
     }
 
-// Checkstyle: CyclomaticComplexity OFF
+// Checkstyle: CyclomaticComplexity|MethodLength OFF
     /**
      * Parser custom element content into a {@link java.util.function.Predicate} to pass to the filter constructor.
      * 
@@ -187,7 +187,7 @@ public class PredicateFilterParser extends AbstractMetadataFilterParser {
         }
     }
 
-// Checkstyle: CyclomaticComplexity ON
+// Checkstyle: CyclomaticComplexity|MethodLength ON
 
     /**
      * Parse Entity elements into a builder for an {@link EntityIdPredicate}.

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.