[java-idp-oidc] branch main updated: JOIDC-225 - Relocate and improve lookup functions for request message contents

Henri Mikkonen henri.mikkonen at iki.fi
Tue Oct 22 13:36:25 UTC 2024


This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch main
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=b3baf6186ec97d5fef29450a1a49960bc6924c34

The following commit(s) were added to refs/heads/main by this push:
     new b3baf618 JOIDC-225 - Relocate and improve lookup functions for request message contents
b3baf618 is described below

commit b3baf6186ec97d5fef29450a1a49960bc6924c34
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Tue Oct 22 16:36:03 2024 +0300

    JOIDC-225 - Relocate and improve lookup functions for request message contents
    
    https://shibboleth.atlassian.net/browse/JOIDC-225
    
    Deprecated DefaultRequestCodeVerifierLookupFunction in the API -module
    - For some reason it was forgotten from the previous round
---
 .../context/navigate/DefaultRequestCodeVerifierLookupFunction.java      | 1 +
 .../context/navigate/DefaultRequestCodeVerifierLookupFunction.java      | 2 +-
 .../net/shibboleth/idp/plugin/oidc/op/profile/impl/ValidatePKCE.java    | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/context/navigate/DefaultRequestCodeVerifierLookupFunction.java b/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/context/navigate/DefaultRequestCodeVerifierLookupFunction.java
index 7aa6a764..becc8f44 100644
--- a/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/context/navigate/DefaultRequestCodeVerifierLookupFunction.java
+++ b/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/context/navigate/DefaultRequestCodeVerifierLookupFunction.java
@@ -24,6 +24,7 @@ import com.nimbusds.oauth2.sdk.TokenRequest;
  * A function that returns code verifier value of the token request via a lookup function. This default lookup locates
  * code verifier from request if available. If information is not available, null is returned.
  */
+ at Deprecated(since="4.2.0", forRemoval=true)
 public class DefaultRequestCodeVerifierLookupFunction extends AbstractTokenRequestLookupFunction<String> {
 
     /** {@inheritDoc} */
diff --git a/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/context/navigate/DefaultRequestCodeVerifierLookupFunction.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/context/navigate/DefaultRequestCodeVerifierLookupFunction.java
similarity index 94%
copy from idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/context/navigate/DefaultRequestCodeVerifierLookupFunction.java
copy to idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/context/navigate/DefaultRequestCodeVerifierLookupFunction.java
index 7aa6a764..a9e05171 100644
--- a/idp-oidc-extension-api/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/context/navigate/DefaultRequestCodeVerifierLookupFunction.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/messaging/context/navigate/DefaultRequestCodeVerifierLookupFunction.java
@@ -12,7 +12,7 @@
  * limitations under the License.
  */
 
-package net.shibboleth.idp.plugin.oidc.op.profile.context.navigate;
+package net.shibboleth.idp.plugin.oidc.op.messaging.context.navigate;
 
 import java.util.List;
 
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/ValidatePKCE.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/ValidatePKCE.java
index b4cd49cc..241b7d8c 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/ValidatePKCE.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/ValidatePKCE.java
@@ -28,7 +28,7 @@ import org.slf4j.Logger;
 import com.nimbusds.jose.util.Base64URL;
 
 import net.shibboleth.idp.plugin.oidc.op.messaging.context.OIDCAuthenticationResponseContext;
-import net.shibboleth.idp.plugin.oidc.op.profile.context.navigate.DefaultRequestCodeVerifierLookupFunction;
+import net.shibboleth.idp.plugin.oidc.op.messaging.context.navigate.DefaultRequestCodeVerifierLookupFunction;
 import net.shibboleth.idp.plugin.oidc.op.token.support.AuthorizeCodeClaimsSet;
 import net.shibboleth.idp.plugin.oidc.op.token.support.TokenClaimsSet;
 import net.shibboleth.oidc.profile.config.logic.AllowPKCEPlainPredicate;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list