[java-plugin-shibd-saml] branch main updated: Fix failing instanceof check.

Scott Cantor cantor.2 at osu.edu
Tue Oct 15 15:37:54 UTC 2024


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-plugin-shibd-saml.

View the commit online:
http://git.shibboleth.net/view/?p=java-plugin-shibd-saml.git;a=commit;h=6ff910f24deb5e11f42942a898d1f1b75a2ce293

The following commit(s) were added to refs/heads/main by this push:
     new 6ff910f  Fix failing instanceof check.
6ff910f is described below

commit 6ff910f24deb5e11f42942a898d1f1b75a2ce293
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Oct 15 11:37:51 2024 -0400

    Fix failing instanceof check.
---
 .../nameid/transcoding/AbstractSAML2NameIDTranscoder.java      | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/sp-saml-api/src/main/java/net/shibboleth/sp/saml/saml2/nameid/transcoding/AbstractSAML2NameIDTranscoder.java b/sp-saml-api/src/main/java/net/shibboleth/sp/saml/saml2/nameid/transcoding/AbstractSAML2NameIDTranscoder.java
index 984acdf..750314f 100644
--- a/sp-saml-api/src/main/java/net/shibboleth/sp/saml/saml2/nameid/transcoding/AbstractSAML2NameIDTranscoder.java
+++ b/sp-saml-api/src/main/java/net/shibboleth/sp/saml/saml2/nameid/transcoding/AbstractSAML2NameIDTranscoder.java
@@ -143,12 +143,13 @@ public abstract class AbstractSAML2NameIDTranscoder<EncodedType extends IdPAttri
     @Nonnull protected String getNameQualifier(@Nullable final ProfileRequestContext profileRequestContext,
             @Nonnull final NameID input, final boolean useDefaultQualifier) {
         
-        if (input.getNameQualifier() instanceof String qual) {
+        String qual = input.getNameQualifier();
+        if (qual != null) {
             return qual;
         }
         
         if (useDefaultQualifier) {
-            final String qual = identityProviderNameLookupStrategy.apply(profileRequestContext);
+            qual = identityProviderNameLookupStrategy.apply(profileRequestContext);
             if (qual != null) {
                 return qual;
             }
@@ -169,12 +170,13 @@ public abstract class AbstractSAML2NameIDTranscoder<EncodedType extends IdPAttri
     @Nonnull protected String getSPNameQualifier(@Nullable final ProfileRequestContext profileRequestContext,
             @Nonnull final NameID input, final boolean useDefaultQualifier) {
         
-        if (input.getSPNameQualifier() instanceof String qual) {
+        String qual = input.getSPNameQualifier(); 
+        if (qual != null) {
             return qual;
         }
         
         if (useDefaultQualifier) {
-            final String qual = serviceProviderNameLookupStrategy.apply(profileRequestContext);
+            qual = serviceProviderNameLookupStrategy.apply(profileRequestContext);
             if (qual != null) {
                 return qual;
             }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list