[java-shib-shared] branch main updated: Disable a test check, which fails now because of the new client type.

[Brent Putman]

This is an automated email from the git hooks/post-receive script.

putmanb pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-shared.git;a=commit;h=bfe4496f93e4e9fb0504f787a152f115728ac107

The following commit(s) were added to refs/heads/main by this push:
     new bfe4496f Disable a test check, which fails now because of the new client type.
bfe4496f is described below

commit bfe4496f93e4e9fb0504f787a152f115728ac107
Author: Brent Putman <putmanb at georgetown.edu>
AuthorDate: Thu Nov 7 18:47:16 2024 -0500

    Disable a test check, which fails now because of the new client type.
    
    The "outer" client produced from the builder is now the
    RequestTimeLimitingHttpClient.
    
    Maybe explore exposing the wrapped clients in these impls so at least
    tests can recurse and check if the right type is present in the object
    graph.
---
 .../java/net/shibboleth/shared/httpclient/HttpClientBuilderTest.java   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/shib-networking/src/test/java/net/shibboleth/shared/httpclient/HttpClientBuilderTest.java b/shib-networking/src/test/java/net/shibboleth/shared/httpclient/HttpClientBuilderTest.java
index ee29ec1f..071071d6 100644
--- a/shib-networking/src/test/java/net/shibboleth/shared/httpclient/HttpClientBuilderTest.java
+++ b/shib-networking/src/test/java/net/shibboleth/shared/httpclient/HttpClientBuilderTest.java
@@ -80,7 +80,8 @@ public class HttpClientBuilderTest {
         
         final HttpClient client = builder.buildClient();
         Assert.assertNotNull(client);
-        Assert.assertTrue(ContextHandlingHttpClient.class.isInstance(client));
+        // Disable this for now.  The "outer" client produced by the builder is now RequestTimeLimitingHttpClient
+        //Assert.assertTrue(ContextHandlingHttpClient.class.isInstance(client));
         
     }
     

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.