[java-shib-shared] branch main updated: JSSH-54: HttpClientBuilder RequestConfig default for responseTimeout

[Brent Putman]

This is an automated email from the git hooks/post-receive script.

putmanb pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-shared.git;a=commit;h=41b1e98b834efe8eea098566a29ac4ae19075a62

The following commit(s) were added to refs/heads/main by this push:
     new 41b1e98b JSSH-54: HttpClientBuilder RequestConfig default for responseTimeout
41b1e98b is described below

commit 41b1e98b834efe8eea098566a29ac4ae19075a62
Author: Brent Putman <putmanb at georgetown.edu>
AuthorDate: Wed Nov 6 18:38:54 2024 -0500

    JSSH-54: HttpClientBuilder RequestConfig default for responseTimeout
    
    Update default to 60 seconds, based on corrected understanding of what
    this setting actually does.
---
 .../java/net/shibboleth/shared/httpclient/HttpClientBuilder.java    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/shib-networking/src/main/java/net/shibboleth/shared/httpclient/HttpClientBuilder.java b/shib-networking/src/main/java/net/shibboleth/shared/httpclient/HttpClientBuilder.java
index 2b5050c7..65d2b11d 100644
--- a/shib-networking/src/main/java/net/shibboleth/shared/httpclient/HttpClientBuilder.java
+++ b/shib-networking/src/main/java/net/shibboleth/shared/httpclient/HttpClientBuilder.java
@@ -110,7 +110,7 @@ public class HttpClientBuilder {
     @Nonnull private Duration connectionRequestTimeout;
     
     /** Determines the timeout until arrival of a response from the opposite endpoint.
-     * Default value: (0 seconds) */
+     * Default value: (60 seconds) */
     @Nonnull private Duration responseTimeout;
     
     /**
@@ -231,7 +231,7 @@ public class HttpClientBuilder {
         socketLocalAddress = null;
         socketBufferSize = 8192;
         socketTimeout = Duration.ofSeconds(60);
-        responseTimeout = Duration.ofSeconds(0);
+        responseTimeout = Duration.ofSeconds(60);
         connectionTimeout = Duration.ofSeconds(60);
         connectionRequestTimeout = Duration.ofSeconds(60);
         connectionDisregardTLSCertificate = false;
@@ -276,7 +276,7 @@ public class HttpClientBuilder {
         socketLocalAddress = null;
         socketBufferSize = 8192;
         socketTimeout = Duration.ofSeconds(60);
-        responseTimeout = Duration.ofSeconds(0);
+        responseTimeout = Duration.ofSeconds(60);
         connectionTimeout = Duration.ofSeconds(60);
         connectionRequestTimeout = Duration.ofSeconds(60);
         connectionDisregardTLSCertificate = false;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.