[java-shib-shared] branch main updated: JSSH-47 SpringServiceableComponent fails on ID-less component

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-shared.git;a=commit;h=f6b0545f372d4746868a88124b48fd893ff419cb

The following commit(s) were added to refs/heads/main by this push:
     new f6b0545f JSSH-47 SpringServiceableComponent fails on ID-less component
f6b0545f is described below

commit f6b0545f372d4746868a88124b48fd893ff419cb
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Wed May 15 14:14:10 2024 +0100

    JSSH-47 SpringServiceableComponent fails on ID-less component
    
    https://shibboleth.atlassian.net/browse/JSSH-47
    
    We need to be looking for IdentifiedComponent, NOT identifiableComponent.
    The latter has the setter method and we just dont care about that.
---
 .../shared/spring/service/impl/SpringServiceableComponent.java        | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/shib-service/src/main/java/net/shibboleth/shared/spring/service/impl/SpringServiceableComponent.java b/shib-service/src/main/java/net/shibboleth/shared/spring/service/impl/SpringServiceableComponent.java
index db374a26..7dc4c938 100644
--- a/shib-service/src/main/java/net/shibboleth/shared/spring/service/impl/SpringServiceableComponent.java
+++ b/shib-service/src/main/java/net/shibboleth/shared/spring/service/impl/SpringServiceableComponent.java
@@ -16,7 +16,7 @@ package net.shibboleth.shared.spring.service.impl;
 
 import javax.annotation.Nonnull;
 
-import net.shibboleth.shared.component.IdentifiableComponent;
+import net.shibboleth.shared.component.IdentifiedComponent;
 import net.shibboleth.shared.primitive.LoggerFactory;
 import net.shibboleth.shared.service.ServiceableComponent;
 import net.shibboleth.shared.spring.service.AbstractServiceableComponent;
@@ -40,7 +40,7 @@ public class SpringServiceableComponent<T> extends AbstractServiceableComponent<
     public SpringServiceableComponent(@Nonnull final T what) {
         theComponent = what;
         String id = null;
-        if (what instanceof IdentifiableComponent c) {
+        if (what instanceof IdentifiedComponent c) {
             id = c.getId();
         }
     	if (id != null) {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.