[java-idp-plugin-webauthn] branch main updated: Cleanups

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=fb7a346d7544663fd6032cd62f6aef6181c65649

The following commit(s) were added to refs/heads/main by this push:
     new fb7a346  Cleanups
fb7a346 is described below

commit fb7a346d7544663fd6032cd62f6aef6181c65649
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Wed Jun 26 16:40:51 2024 +0100

    Cleanups
---
 .../idp/plugin/authn/webauthn/impl/ExtractUsernameFromForm.java         | 2 --
 .../idp/plugin/authn/webauthn/metadata/FidoMetadataServiceFactory.java  | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/ExtractUsernameFromForm.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/ExtractUsernameFromForm.java
index 36120f7..24cc75f 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/ExtractUsernameFromForm.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/ExtractUsernameFromForm.java
@@ -38,8 +38,6 @@ import net.shibboleth.shared.primitive.StringSupport;
 /**
  * An action to populate a username into the {@link BaseWebAuthnContext}.
  * 
- * TODO FINISH. Really maybe should be similar to CheckPasswordlessEnrollment from Duo
- * 
  * @event {@link AuthnEventIds#UNKNOWN_USERNAME}
  * @pre <pre>ProfileRequestContext.getSubcontext(AuthenticationContext.class) != null</pre>
  * @post <pre>BaseWebAuthnContext.getUsername() == null</pre>
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/metadata/FidoMetadataServiceFactory.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/metadata/FidoMetadataServiceFactory.java
index 0ea2ff9..e509f19 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/metadata/FidoMetadataServiceFactory.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/metadata/FidoMetadataServiceFactory.java
@@ -280,6 +280,7 @@ public class FidoMetadataServiceFactory extends AbstractIdentifiableInitializabl
      */
     public synchronized void setCrls(@Nullable final List<Resource> revocationLists) {
         checkSetterPreconditions();
+        log.trace("Setting FIDO CRLs '{}'", revocationLists);
         if (revocationLists != null) {
             crls = CollectionSupport.copyToList(revocationLists);
         } else {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.