[java-identity-provider] branch maint-5.1 updated: IDP-2300 LDAP auth pool closure

[Daniel Fisher]

This is an automated email from the git hooks/post-receive script.

dfisher pushed a commit to branch maint-5.1
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=af26971671f389745d8e41b0166174e32d7fdf25

The following commit(s) were added to refs/heads/maint-5.1 by this push:
     new af2697167 IDP-2300 LDAP auth pool closure
af2697167 is described below

commit af26971671f389745d8e41b0166174e32d7fdf25
Author: Daniel Fisher <dfisher at vt.edu>
AuthorDate: Mon Jul 29 13:26:29 2024 -0400

    IDP-2300 LDAP auth pool closure
    
    If the LDAP authentication pools are closed more than once, errors will be emitted.
    Remove the close invocation from LDAPCredentialValidator#doDestroy
    
    https://shibboleth.atlassian.net/browse/IDP-2300
---
 .../java/net/shibboleth/idp/authn/impl/LDAPCredentialValidator.java     | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/LDAPCredentialValidator.java b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/LDAPCredentialValidator.java
index 464beb1db..4d75219f1 100644
--- a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/LDAPCredentialValidator.java
+++ b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/LDAPCredentialValidator.java
@@ -126,9 +126,11 @@ public class LDAPCredentialValidator extends AbstractUsernamePasswordCredentialV
     /** {@inheritDoc} */
     @Override
     protected void doDestroy() {
+        /* authenticator is closed by LDAPAuthenticationFactoryBean#destroyInstance
         if (authenticator != null) {
             authenticator.close();
         }
+        */
         super.doDestroy();
     }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.