[java-shib-shared] branch main updated: JSSH-52 - Chaining filter does not auto-wire filters in order

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-shared.git;a=commit;h=c0fd4e7943740e307161108a43ad2ef869bea39f

The following commit(s) were added to refs/heads/main by this push:
     new c0fd4e79 JSSH-52 - Chaining filter does not auto-wire filters in order
c0fd4e79 is described below

commit c0fd4e7943740e307161108a43ad2ef869bea39f
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Jul 25 11:13:34 2024 -0400

    JSSH-52 - Chaining filter does not auto-wire filters in order
    
    https://shibboleth.atlassian.net/browse/JSSH-52
    
    Auto-wiring spot needs to be a List and not a Collection.
---
 .../net/shibboleth/shared/spring/servlet/impl/ChainingFilter.java     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/servlet/impl/ChainingFilter.java b/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/servlet/impl/ChainingFilter.java
index 471c01f9..8cd3a375 100644
--- a/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/servlet/impl/ChainingFilter.java
+++ b/shib-networking-spring/src/main/java/net/shibboleth/shared/spring/servlet/impl/ChainingFilter.java
@@ -15,7 +15,6 @@
 package net.shibboleth.shared.spring.servlet.impl;
 
 import java.io.IOException;
-import java.util.Collection;
 import java.util.Iterator;
 import java.util.List;
 
@@ -52,7 +51,7 @@ public class ChainingFilter implements Filter {
      * @param filterChain auto-wired chain of filters to run
      */
     @Autowired
-    public ChainingFilter(@Nullable final Collection<ChainableFilter> filterChain) {
+    public ChainingFilter(@Nullable final List<ChainableFilter> filterChain) {
         if (filterChain != null) {
             filters = List.copyOf(filterChain);
         } else {
@@ -69,6 +68,7 @@ public class ChainingFilter implements Filter {
     }
 
     /** {@inheritDoc} */
+    
     public void doFilter(final ServletRequest request, final ServletResponse response, final FilterChain chain)
             throws IOException, ServletException {
         

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.