[java-idp-integration-tests] 02/04: Cleanup Maven POM

[Tom Zeller]

This is an automated email from the git hooks/post-receive script.

tzeller pushed a commit to branch main
in repository java-idp-integration-tests.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-integration-tests.git;a=commit;h=b72f0547095f7afe0221fb4c7ca30af04791d19e

commit b72f0547095f7afe0221fb4c7ca30af04791d19e
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Tue Jul 9 18:30:10 2024 -0500

    Cleanup Maven POM
    
    Move all dependency versions to properties and add comments
---
 pom.xml | 55 ++++++++++++++++++++++++++++++++++++-------------------
 1 file changed, 36 insertions(+), 19 deletions(-)

diff --git a/pom.xml b/pom.xml
index 3b82b41..3a9636a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -17,42 +17,51 @@
     <version>0.0.1-SNAPSHOT</version>
 
     <properties>
-        <!-- IdP -->
+        <!-- Version of IdP used for test validation -->
         <idp.version>5.1.3-SNAPSHOT</idp.version>
 
-        <!--  Version of IdP to be tested -->
+        <!-- Version of IdP to be tested -->
         <idp-to-be-tested.version>${idp.version}</idp-to-be-tested.version>
 
-        <!-- Version of Jetty Base to be tested -->
-        <idp-jetty-base.version>11.0.0-SNAPSHOT</idp-jetty-base.version>
-
-        <!-- Default version of Jetty to be tested -->
+        <!-- Jetty -->
         <jetty.version>11.0.21</jetty.version>
+        <idp-jetty-base.version>11.0.0-SNAPSHOT</idp-jetty-base.version>
 
         <!-- Tomcat -->
-        <idp-tomcat-base.type>tgz</idp-tomcat-base.type>
-        <idp-tomcat-base.version>10.1.0-SNAPSHOT</idp-tomcat-base.version>
         <tomcat.version>10.1.24</tomcat.version>
+        <idp-tomcat-base.version>10.1.0-SNAPSHOT</idp-tomcat-base.version>
+        <idp-tomcat-base.type>tgz</idp-tomcat-base.type>
 
-        <!-- Testbed -->
+        <!-- IdP testbed -->
         <testbed.version>5.1.0-SNAPSHOT</testbed.version>
         <testbed.classifier>classes</testbed.classifier>
 
         <!-- OpenSAML -->
         <opensaml.version>5.1.3-SNAPSHOT</opensaml.version>
 
+        <!-- Selenium -->
         <selenium.version>4.21.0</selenium.version>
 
+        <!-- AWS SDK -->
+        <aws.java.sdk.version>2.26.4</aws.java.sdk.version>
+        
+        <!-- Testcontainers.com -->
+        <testcontainers.version>1.19.5</testcontainers.version>
+        
+        <!-- Apache Commons Net -->
+        <commons-net.version>3.5</commons-net.version>
+
+        <!-- Directory where the IdP and Servlet container are unpacked -->
         <test-distributions.directory>${project.basedir}/test-distributions</test-distributions.directory>
+
+        <!-- Directory where the IdP distribution is unpacked -->
         <idp-to-be-tested.directory>${test-distributions.directory}/shibboleth-identity-provider-${idp-to-be-tested.version}</idp-to-be-tested.directory>
-        <svn.relative.location>java-idp-integration-tests</svn.relative.location>
 
+        <!-- IdP conf artifact ID, different for IdP V5 and later than V4 -->
         <idp-conf.artifactId>idp-conf-impl</idp-conf.artifactId>
 
         <!-- Redirect test output to file target/surefire-reports/testName-output.txt -->
         <redirectTestOutputToFile>true</redirectTestOutputToFile>
-        
-        <aws.java.sdk.version>2.26.4</aws.java.sdk.version>
     </properties>
 
     <dependencyManagement>
@@ -82,8 +91,6 @@
     </dependencyManagement>
 
     <dependencies>
-        <!-- Compile Dependencies -->
-
         <!-- Provided Dependencies -->
         <dependency>
             <groupId>jakarta.servlet</groupId>
@@ -91,19 +98,21 @@
             <scope>provided</scope>
         </dependency>
 
-        <!-- Runtime Dependencies -->
-
         <!-- Test Dependencies -->
         <dependency>
             <groupId>org.testng</groupId>
             <artifactId>testng</artifactId>
             <scope>test</scope>
         </dependency>
+
+        <!-- IdP installer : installs the IdP and plugins to be tested -->
         <dependency>
             <groupId>net.shibboleth.idp</groupId>
             <artifactId>idp-installer</artifactId>
             <scope>test</scope>
         </dependency>
+
+        <!-- Test IdP configuration : certs, flows, metadata, etc -->
         <dependency>
             <groupId>net.shibboleth.idp</groupId>
             <artifactId>idp-conf-impl</artifactId>
@@ -111,31 +120,39 @@
             <scope>test</scope>
             <version>${idp.version}</version>
         </dependency>
+
+        <!-- Selenium : automates browsers -->
         <dependency>
             <groupId>org.seleniumhq.selenium</groupId>
             <artifactId>selenium-java</artifactId>
             <version>${selenium.version}</version>
             <scope>test</scope>
         </dependency>
+
+        <!-- Apache Commons Net : provides telnet client to shut down Tomcat -->
         <dependency>
             <groupId>commons-net</groupId>
             <artifactId>commons-net</artifactId>
-            <version>3.5</version>
+            <version>${commons-net.version}</version>
             <scope>test</scope>
         </dependency>
+
+        <!-- AWS SDK : manage DNS for Sauce Labs browser tests -->
         <dependency>
             <groupId>software.amazon.awssdk</groupId>
             <artifactId>route53</artifactId>
             <scope>test</scope>
         </dependency>
+
+        <!-- Testcontainers : run Docker containers for OIDC tests -->
         <dependency>
             <groupId>org.testcontainers</groupId>
             <artifactId>testcontainers</artifactId>
-            <version>1.19.5</version>
+            <version>${testcontainers.version}</version>
             <scope>test</scope>
         </dependency>
-    </dependencies>
 
+    </dependencies>
 
     <build>
         <plugins>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.