[java-plugin-shibd] branch main updated: Fix javadoc and setter method.

Scott Cantor cantor.2 at osu.edu
Mon Jul 1 22:43:07 UTC 2024


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-plugin-shibd.

View the commit online:
http://git.shibboleth.net/view/?p=java-plugin-shibd.git;a=commit;h=8b173fe1477b5bcc743221ec3eb40ffe9e9ddab8

The following commit(s) were added to refs/heads/main by this push:
     new 8b173fe  Fix javadoc and setter method.
8b173fe is described below

commit 8b173fe1477b5bcc743221ec3eb40ffe9e9ddab8
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Jul 1 18:42:59 2024 -0400

    Fix javadoc and setter method.
---
 .../java/net/shibboleth/sp/profile/impl/DoStorageOperation.java   | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/sp-server-impl/src/main/java/net/shibboleth/sp/profile/impl/DoStorageOperation.java b/sp-server-impl/src/main/java/net/shibboleth/sp/profile/impl/DoStorageOperation.java
index 38794dd..8f3f78f 100644
--- a/sp-server-impl/src/main/java/net/shibboleth/sp/profile/impl/DoStorageOperation.java
+++ b/sp-server-impl/src/main/java/net/shibboleth/sp/profile/impl/DoStorageOperation.java
@@ -17,7 +17,6 @@ package net.shibboleth.sp.profile.impl;
 import java.io.IOException;
 
 import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
 
 import org.opensaml.profile.action.ActionSupport;
 import org.opensaml.profile.action.EventIds;
@@ -31,6 +30,7 @@ import net.shibboleth.shared.annotation.constraint.NonnullAfterInit;
 import net.shibboleth.shared.annotation.constraint.NonnullBeforeExec;
 import net.shibboleth.shared.annotation.constraint.NotEmpty;
 import net.shibboleth.shared.component.ComponentInitializationException;
+import net.shibboleth.shared.logic.Constraint;
 import net.shibboleth.shared.primitive.LoggerFactory;
 import net.shibboleth.sp.Agent;
 import net.shibboleth.sp.ddf.DDF;
@@ -87,14 +87,12 @@ public class DoStorageOperation extends AbstractAgentAction {
     /**
      * Sets the {@link StorageService} to use.
      * 
-     * <p>Primarily for testing, to bypass use of Spring to obtain the service to use.</p>
-     * 
      * @param storage storage service
      */
-    public void setStorageService(@Nullable final StorageService storage) {
+    public void setStorageService(@Nonnull final StorageService storage) {
         checkSetterPreconditions();
         
-        storageService = storage;
+        storageService = Constraint.isNotNull(storage, "StorageService cannot be null");
     }
 
     /** {@inheritDoc} */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list