[java-shib-attribute] branch main updated: JSATTR-21 - Add hyphen to the list of discouraged characters

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-shib-attribute.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-attribute.git;a=commit;h=6b5a58e8b750e535d200f1001d2e5c54785b49d4

The following commit(s) were added to refs/heads/main by this push:
     new 6b5a58e8b JSATTR-21 - Add hyphen to the list of discouraged characters
6b5a58e8b is described below

commit 6b5a58e8b750e535d200f1001d2e5c54785b49d4
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Jan 22 09:21:37 2024 -0500

    JSATTR-21 - Add hyphen to the list of discouraged characters
    
    https://shibboleth.atlassian.net/browse/JSATTR-21
---
 .../src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java     | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/shib-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java b/shib-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java
index 58aa38893..d3698e51f 100644
--- a/shib-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java
+++ b/shib-attribute-api/src/main/java/net/shibboleth/idp/attribute/IdPAttribute.java
@@ -78,7 +78,7 @@ public class IdPAttribute implements Comparable<IdPAttribute>, Cloneable {
             // Issue a deprecation warning once but log more in debug and trace to help fixing
             DeprecationSupport.warnOnce(ObjectType.CONFIGURATION,
                     "IdPAttribute",
-                    "IdPAttribute id with special characters (\'\"%{})", null);
+                    "IdPAttribute id with special characters (\'\"%-{})", null);
             LOG.debug("{} - deprecated character in attribute name", id);
             LOG.trace("Stack", new Exception("Stack Trace, not a thrown exception:"));
         }
@@ -93,7 +93,8 @@ public class IdPAttribute implements Comparable<IdPAttribute>, Cloneable {
         return id.indexOf('\'') >= 0 ||
                 id.indexOf('%') >= 0 ||
                 id.indexOf('{') >= 0 ||
-                id.indexOf('}') >= 0;
+                id.indexOf('}') >= 0 ||
+                id.indexOf('-') >= 0;
     }
     
     /** Centralized method to police invalid Identifiers.

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.