[java-idp-plugin-webauthn] branch main updated: Cleanup 2FA enablement

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=3473eb9988a59a171f8bc696fcffb594cfa780c0

The following commit(s) were added to refs/heads/main by this push:
     new 3473eb9  Cleanup 2FA enablement
3473eb9 is described below

commit 3473eb9988a59a171f8bc696fcffb594cfa780c0
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Jan 19 13:44:39 2024 +0000

    Cleanup 2FA enablement
---
 .../idp/plugin/authn/webauthn/context/logic/IsSecondFactor.java         | 2 +-
 .../META-INF/net/shibboleth/idp/flows/authn/WebAuthn/webauthn-beans.xml | 2 +-
 .../shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/context/logic/IsSecondFactor.java b/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/context/logic/IsSecondFactor.java
index 6cad0c1..1071a70 100644
--- a/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/context/logic/IsSecondFactor.java
+++ b/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/context/logic/IsSecondFactor.java
@@ -39,7 +39,7 @@ import net.shibboleth.shared.primitive.StringSupport;
 
 /** 
  * A predicate that determines if the authentication flow is being used as a second factor of authentication, and not
- * a first (and possibly only) factor. Returns true if second factor use, or false if passwordless/first factor.
+ * a first (and possibly only) factor. Returns true if second factor use, or false if passwordless or first factor.
  */
 //FIXME this class is not clear, but I think I need something like it
 //FIXME enabled and forced2fa is confusing
diff --git a/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/WebAuthn/webauthn-beans.xml b/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/WebAuthn/webauthn-beans.xml
index d755480..66d44e9 100644
--- a/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/WebAuthn/webauthn-beans.xml
+++ b/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/WebAuthn/webauthn-beans.xml
@@ -25,7 +25,7 @@
         p:secondFactorOverride="#{getObject('shibboleth.authn.webauthn.SecondFactorOverride') != null ? 
             getObject('shibboleth.authn.webauthn.SecondFactorOverride') : %{idp.authn.webauthn.2fa.forceSecondFactorFlow:false}}"
         p:allowedPreviousFactors="%{idp.authn.webauthn.2fa.allowedPreviousFactors}"
-        p:denySecondFactor="%{idp.authn.webauthn.2fa.denySecondFactor:false}"/>
+        p:enabled="%{idp.authn.webauthn.2fa.enabled:false}"/>
 
     <bean id="IsDiscoverableCredentialRequired" scope="prototype"
         class="net.shibboleth.idp.plugin.authn.webauthn.context.logic.IsDiscoverableCredentialRequired" />
diff --git a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
index a1c1ce6..6a08a1f 100644
--- a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
+++ b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
@@ -24,4 +24,4 @@ idp.authn.webauthn.2fa.allowedPreviousFactors = authn/Password
 #idp.authn.webauthn.2fa.forceSecondFactorFlow = false
 ### Deny second factor irrespective of the value of forceSecondFactorFlow and if an acceptable previous factor is found
 ### Effectively turning off its ability to act as a second factor only
-#idp.authn.webauthn.2fa.denySecondFactor = false
\ No newline at end of file
+#idp.authn.webauthn.2fa.enabled = false
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.