[java-idp-plugin-duo] branch main updated: JDUO-82 - API to access enrollment information

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-duo.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-duo.git;a=commit;h=bed5a40bf2e9430ee94ed6cde0eaadbdc6dad550

The following commit(s) were added to refs/heads/main by this push:
     new bed5a40b JDUO-82 - API to access enrollment information
bed5a40b is described below

commit bed5a40bf2e9430ee94ed6cde0eaadbdc6dad550
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Tue Jan 16 15:14:03 2024 +0000

    JDUO-82 - API to access enrollment information
    
     - Build canon query string conditionally on non-null request
    parameters.
    
    https://shibboleth.atlassian.net/browse/JDUO-82
---
 .../idp/plugin/authn/duo/impl/DuoSupport.java           |  5 +++--
 .../authn/duo/impl/DefaultDuoAdminClientTest.java       | 17 +++++++++++------
 2 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/DuoSupport.java b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/DuoSupport.java
index 8177375b..8e64c85c 100644
--- a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/DuoSupport.java
+++ b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/DuoSupport.java
@@ -86,8 +86,9 @@ public final class DuoSupport {
         canon += uri.getHost().toLowerCase() + "\n";
         canon += uri.getPath() + "\n";
         final List<NameValuePair> parms = request.getParameters();
-        assert parms != null;
-        canon += createQueryString(parms);
+        if (parms != null) {
+            canon += createQueryString(parms);
+        }
 
         return canon;
     }
diff --git a/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/impl/DefaultDuoAdminClientTest.java b/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/impl/DefaultDuoAdminClientTest.java
index c49875b1..75b7d194 100644
--- a/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/impl/DefaultDuoAdminClientTest.java
+++ b/idp-duo-impl/src/test/java/net/shibboleth/idp/plugin/authn/duo/impl/DefaultDuoAdminClientTest.java
@@ -41,6 +41,7 @@ import net.shibboleth.idp.plugin.authn.duo.DuoAdminListMapResponseWrapper;
 import net.shibboleth.idp.plugin.authn.duo.DuoAdminResponseWrapper;
 import net.shibboleth.idp.plugin.authn.duo.DuoException;
 import net.shibboleth.idp.plugin.authn.duo.model.User;
+import net.shibboleth.shared.collection.CollectionSupport;
 import net.shibboleth.shared.component.ComponentInitializationException;
 
 /**
@@ -512,7 +513,8 @@ public class DefaultDuoAdminClientTest {
         client.initialize();
         
         final DuoAdminResponseWrapper<List<Map<String,Object>>> userWrapper = 
-                client.retrieve(new ProfileRequestContext(),"/admin/v1/users/1/bypass_codes", Map.of("username","jdoe"), 
+                client.retrieve(new ProfileRequestContext(),"/admin/v1/users/1/bypass_codes", 
+                        CollectionSupport.emptyMap(), 
                 new TypeReference<DuoAdminResponseWrapper<List<Map<String,Object>>>>() {});
         
         assertNotNull(userWrapper);
@@ -543,7 +545,8 @@ public class DefaultDuoAdminClientTest {
         client.initialize();
         
         final DuoAdminResponseWrapper<List<Map<String,Object>>> userWrapper = 
-                client.retrieve(new ProfileRequestContext(),"/admin/v1/users/1/bypass_codes",Map.of("username","jdoe"), 
+                client.retrieve(new ProfileRequestContext(),"/admin/v1/users/1/bypass_codes",
+                        CollectionSupport.emptyMap(), 
                 new TypeReference<DuoAdminResponseWrapper<List<Map<String,Object>>>>() {});
         
         assertNotNull(userWrapper);
@@ -569,7 +572,8 @@ public class DefaultDuoAdminClientTest {
         client.initialize();
         
         final DuoAdminListMapResponseWrapper userWrapper = 
-                client.retrieve(new ProfileRequestContext(),"/admin/v1/users/1/bypass_codes",Map.of("username","jdoe"));
+                client.retrieve(new ProfileRequestContext(),"/admin/v1/users/1/bypass_codes",
+                        CollectionSupport.emptyMap());
         
         assertNotNull(userWrapper);
         assertNotNull(userWrapper.getResponse());
@@ -597,7 +601,8 @@ public class DefaultDuoAdminClientTest {
         client.initialize();
         
         final DuoAdminListMapResponseWrapper userWrapper = 
-                client.retrieve(new ProfileRequestContext(),"/admin/v1/users/1/bypass_codes",Map.of("username","jdoe"));
+                client.retrieve(new ProfileRequestContext(),"/admin/v1/users/1/bypass_codes",
+                        CollectionSupport.emptyMap());
 
         assertNotNull(userWrapper);
         assertNotNull(userWrapper.getResponse());
@@ -625,7 +630,7 @@ public class DefaultDuoAdminClientTest {
         
         final DuoAdminListMapResponseWrapper userWrapper = 
                 client.retrieve(new ProfileRequestContext(),
-                        "/admin/v1/users/1/verification_push_response", Map.of("username","jdoe"));
+                        "/admin/v1/users/1/verification_push_response", CollectionSupport.emptyMap());
         
         assertNotNull(userWrapper);
         assertNotNull(userWrapper.getResponse());
@@ -651,7 +656,7 @@ public class DefaultDuoAdminClientTest {
         
         final DuoAdminListMapResponseWrapper userWrapper = 
                 client.retrieve(new ProfileRequestContext(),
-                        "/admin/v1/users/1/verification_push_response", Map.of("username","jdoe"));
+                        "/admin/v1/users/1/verification_push_response",CollectionSupport.emptyMap());
         
         assertNotNull(userWrapper);
         assertNotNull(userWrapper.getResponse());

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.