[java-idp-plugin-duo] branch dev/JDUO-80 updated: Default enrollment check to true for now, and add pluggability.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch dev/JDUO-80
in repository java-idp-plugin-duo.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-duo.git;a=commit;h=47a8dae2e81dfc271d44b04b5d7fea9ad108a6a0

The following commit(s) were added to refs/heads/dev/JDUO-80 by this push:
     new 47a8dae2 Default enrollment check to true for now, and add pluggability.
47a8dae2 is described below

commit 47a8dae2e81dfc271d44b04b5d7fea9ad108a6a0
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Jan 4 09:46:40 2024 -0500

    Default enrollment check to true for now, and add pluggability.
---
 .../idp/plugin/authn/duo/impl/CheckPasswordlessEnrollment.java        | 4 ++--
 .../net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml   | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/CheckPasswordlessEnrollment.java b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/CheckPasswordlessEnrollment.java
index fee80f1b..84ebb0b4 100644
--- a/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/CheckPasswordlessEnrollment.java
+++ b/idp-duo-impl/src/main/java/net/shibboleth/idp/plugin/authn/duo/impl/CheckPasswordlessEnrollment.java
@@ -104,9 +104,9 @@ public class CheckPasswordlessEnrollment extends AbstractExtractionAction {
                 new ChildContextLookup<>(DuoPasswordlessContext.class).compose(
                         new ChildContextLookup<>(AuthenticationContext.class));
         
-        // TODO: BiPredicateSupport.alwaysFalse once API is bumped.
+        // TODO: BiPredicateSupport.alwaysTrue once API is bumped.
         passwordlessCondition = (a,b) -> {
-            return false;
+            return true;
             };
             
         usernameFieldName = "j_username";
diff --git a/idp-duo-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml b/idp-duo-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml
index 8c0586e3..c673bd5e 100644
--- a/idp-duo-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml
+++ b/idp-duo-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/DuoOIDC/duo-oidc-authn-beans.xml
@@ -142,9 +142,12 @@
         p:resultCachingPredicate="#{getObject('shibboleth.authn.DuoOIDC.resultCachingPredicate')}" />
 
     <!-- Passwordless beans  -->
+    <!-- TODO: change to shibboleth.BiConditions.TRUE once API moves to 5.1. -->
+    <bean id="DefaultPasswordlessCondition" parent="shibboleth.BiConditions.Expression" c:_0="true" />
     <bean id="CheckPasswordlessEnrollment"
         class="net.shibboleth.idp.plugin.authn.duo.impl.CheckPasswordlessEnrollment" scope="prototype"
         p:httpServletRequestSupplier-ref="shibboleth.HttpServletRequestSupplier"
+        p:passwordlessCondition="#{getObject('shibboleth.authn.DuoOIDC.Passwordless.Condition') ?: getObject('DefaultPasswordlessCondition')}"
         p:dataSealer="#{'%{idp.authn.usernameCookieName:}'.trim().isEmpty() ? null : getObject('shibboleth.DataSealer')}"
         p:cookieManager="#{'%{idp.authn.usernameCookieName:}'.trim().isEmpty() ? null : getObject('shibboleth.PersistentCookieManager')}"
         p:cookieName="%{idp.authn.usernameCookieName:}"

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.