[java-idp-plugin-webauthn] branch main updated: Cleanup admin flow descriptor

Phil Smart philip.smart at jisc.ac.uk
Wed Feb 14 14:21:22 UTC 2024


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=355ca4229990a611d6d7bc79b4dadedbd7796927

The following commit(s) were added to refs/heads/main by this push:
     new 355ca42  Cleanup admin flow descriptor
355ca42 is described below

commit 355ca4229990a611d6d7bc79b4dadedbd7796927
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Wed Feb 14 14:21:20 2024 +0000

    Cleanup admin flow descriptor
---
 ...bAuthnCredentialRegistrationFlowDescriptor.java | 39 ----------------------
 .../META-INF/net.shibboleth.idp/postconfig.xml     |  4 +--
 .../authn/webauthn/conf/authn/webauthn.properties  |  1 -
 3 files changed, 2 insertions(+), 42 deletions(-)

diff --git a/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/WebAuthnCredentialRegistrationFlowDescriptor.java b/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/WebAuthnCredentialRegistrationFlowDescriptor.java
deleted file mode 100644
index c8ff1f2..0000000
--- a/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/WebAuthnCredentialRegistrationFlowDescriptor.java
+++ /dev/null
@@ -1,39 +0,0 @@
-/*
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package net.shibboleth.idp.plugin.authn.webauthn.admin;
-
-import javax.annotation.Nonnull;
-
-import net.shibboleth.idp.admin.BasicAdministrativeFlowDescriptor;
-import net.shibboleth.shared.annotation.constraint.NotEmpty;
-
-/**
- * And administrative flow descriptor to register user WebAuthn credentials.
- */
-public class WebAuthnCredentialRegistrationFlowDescriptor extends BasicAdministrativeFlowDescriptor {
-    
-    /** Profile ID. */
-    @Nonnull @NotEmpty public static final String PROFILE_ID =
-            "http://shibboleth.net/ns/profiles/webauthn/register-credential";
-
-    /**
-     * Constructor.
-     */
-    public WebAuthnCredentialRegistrationFlowDescriptor() {
-        super(PROFILE_ID);
-        setNonBrowserSupported(false);
-    }
-
-}
diff --git a/webauthn-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml b/webauthn-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
index 1fadaf5..a9ee84a 100644
--- a/webauthn-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
+++ b/webauthn-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
@@ -69,10 +69,10 @@
     
     <!-- Admim flow for WebAuthn credential registration -->
     <bean parent="shibboleth.AdminFlow"
-            class="net.shibboleth.idp.plugin.authn.webauthn.admin.WebAuthnCredentialRegistrationFlowDescriptor"
+            c:id="http://shibboleth.net/ns/profiles/webauthn/register-credential"
             p:loggingId="%{idp.authn.webauthn.admin.registration.logging:WebAuthnCredentialRegistration}"
             p:policyName="%{idp.authn.webauthn.admin.registration.accessPolicy:AccessByIPAddress}"
-            p:nonBrowserSupported="%{idp.authn.webauthn.admin.registration.nonBrowserSupported:false}"
+            p:nonBrowserSupported="false"
             p:authenticated="true">
         <property name="postAuthenticationFlows">
             <bean parent="shibboleth.CommaDelimStringArray"
diff --git a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
index aad2323..3d392a7 100644
--- a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
+++ b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
@@ -12,7 +12,6 @@ idp.authn.webauthn.relyingPartyName = Shibboleth
 
 # Generic flow properties to adjust behavior
 #idp.authn.webauthn.order = 1000
-#idp.authn.webauthn.nonBrowserSupported = false
 #idp.authn.webauthn.forcedAuthenticationSupported = true
 # The list below should be changed to reflect whatever locally- or
 # community-defined values are appropriate to represent WebAuthn. It is

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list