[java-idp-plugin-webauthn] branch main updated: Improve log statements

Phil Smart philip.smart at jisc.ac.uk
Wed Dec 4 10:50:48 UTC 2024


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=99c4f415d817612b7a46a3008959352feea2998a

The following commit(s) were added to refs/heads/main by this push:
     new 99c4f41  Improve log statements
99c4f41 is described below

commit 99c4f415d817612b7a46a3008959352feea2998a
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Wed Dec 4 10:50:45 2024 +0000

    Improve log statements
---
 .../idp/plugin/authn/webauthn/impl/ValidateWebAuthnAssertion.java       | 2 +-
 .../webauthn/policy/impl/SecondFactorOnlyCredentialPolicyRule.java      | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/ValidateWebAuthnAssertion.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/ValidateWebAuthnAssertion.java
index bced460..fa3c404 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/ValidateWebAuthnAssertion.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/ValidateWebAuthnAssertion.java
@@ -215,7 +215,7 @@ public class ValidateWebAuthnAssertion extends AbstractAuditingValidationAction
             
         } catch (final AssertionFailureException e) {
             log.warn("{} Error validating authenticator assertion for '{}'", 
-                    getLogPrefix(),context.getUsername() != null ? context.getUsername() : "unknown username", e);
+                    getLogPrefix(),context.getUsername() != null ? context.getUsername() : "unknown user", e);
             handleError(profileRequestContext, authenticationContext, AuthnEventIds.INVALID_CREDENTIALS, 
                     AuthnEventIds.INVALID_CREDENTIALS);
             recordFailure(profileRequestContext);              
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/policy/impl/SecondFactorOnlyCredentialPolicyRule.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/policy/impl/SecondFactorOnlyCredentialPolicyRule.java
index 538f715..da59e43 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/policy/impl/SecondFactorOnlyCredentialPolicyRule.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/policy/impl/SecondFactorOnlyCredentialPolicyRule.java
@@ -67,7 +67,6 @@ public class SecondFactorOnlyCredentialPolicyRule extends AbstractCredentialPoli
                 if (aaguidBytes != null) {
                     return new AAGUID(aaguidBytes);
                 } else {
-                    log.trace("AAGUID '{}' is not valid", strAAGUID);
                     return null;
                 }                  
             }).filter(Objects::nonNull).collect(CollectionSupport.nonnullCollector(Collectors.toSet())).get();

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list