[java-idp-plugin-webauthn] branch main updated: JWEBAUTHN-21 - IdP does not start with a non-existing fido metadata cache file

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=4d8918da10df03de344b39a7f973dae412181652

The following commit(s) were added to refs/heads/main by this push:
     new 4d8918d  JWEBAUTHN-21 - IdP does not start with a non-existing fido metadata cache file
4d8918d is described below

commit 4d8918da10df03de344b39a7f973dae412181652
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Aug 30 15:30:20 2024 +0100

    JWEBAUTHN-21 - IdP does not start with a non-existing fido metadata
    cache file
    
     - Add file:/ to the default metadata cache file properties to avoid
    confusion
    
    https://shibboleth.atlassian.net/browse/JWEBAUTHN-21
---
 .../webauthn/metadata/FidoMetadataServiceFactory.java      | 14 +++++++-------
 .../plugin/authn/webauthn/conf/authn/webauthn.properties   |  8 ++++----
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/metadata/FidoMetadataServiceFactory.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/metadata/FidoMetadataServiceFactory.java
index 2521a6f..2d548de 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/metadata/FidoMetadataServiceFactory.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/metadata/FidoMetadataServiceFactory.java
@@ -101,13 +101,13 @@ public class FidoMetadataServiceFactory extends AbstractIdentifiableInitializabl
         } else if (localMetadataBlobUrl != null && localMetadataCacheFile != null){
             log.debug("{}: Loading FIDO metadata blob from '{}'", getId(), metadataBlobUrl);
             downloader = FidoMetadataDownloader.builder()
-            .expectLegalHeader(getExpectedLegalHeaders())
-            .useTrustRoot(X509Support.decodeCertificate(getTrustRootFile().getFile()))
-            .downloadBlob(localMetadataBlobUrl.getURL())
-            .useBlobCacheFile(localMetadataCacheFile.getFile())
-            .useCrls(loadCrls())
-            .verifyDownloadsOnly(true)
-            .build();
+                .expectLegalHeader(getExpectedLegalHeaders())
+                .useTrustRoot(X509Support.decodeCertificate(getTrustRootFile().getFile()))
+                .downloadBlob(localMetadataBlobUrl.getURL())
+                .useBlobCacheFile(localMetadataCacheFile.getFile())
+                .useCrls(loadCrls())
+                .verifyDownloadsOnly(true)
+                .build();
         } else {
             throw new FatalBeanException("Local FIDO metadata blob file not specified or the metadata blob URL and "
                     + "local cache file not specified. Please use either a local file or a known URL");
diff --git a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
index 5d2ac0f..83866f9 100644
--- a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
+++ b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
@@ -94,17 +94,17 @@ idp.authn.webauthn.supportedPrincipals = \
 
 # Enable FIDO Alliance metadata? If you want to use the metadata service, you *must* download and set the trust root and the legal blob file headers
 #idp.authn.webauthn.metadata.enabled = false
-#idp.authn.webauthn.metadata.trustRootFile =
+#idp.authn.webauthn.metadata.trustRootFile = file:/
 #idp.authn.webauthn.metadata.expectedLegalHeaders = Retrieval and use of this BLOB indicates acceptance of the appropriate agreement located at https://fidoalliance.org/metadata/metadata-legal-terms/
 # Downloaded CRLs to check metadata signature revocation status.
-#idp.authn.webauthn.metadata.crls = file://
+#idp.authn.webauthn.metadata.crls = file:/
 
 ## If you want to download the metadata from a URL when the IdP starts, you must specify a cache file (.bin) and the URL to fetch the metadata
-#idp.authn.webauthn.metadata.cacheFile = 
+#idp.authn.webauthn.metadata.cacheFile = file:/
 #idp.authn.webauthn.metadata.metadataBlobUrl = https://mds3.fidoalliance.org
 
 ## If you want to load the metadata from a file *only*, set the metadata blob file location. This will override the metadataBlobUrl property
-#idp.authn.webauthn.metadata.metadataBlobFile = 
+#idp.authn.webauthn.metadata.metadataBlobFile = file:/
 
 #### Authentication properties
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.