[java-idp-plugin-webauthn] branch main updated: Improve log level or log statement

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=04ff4cab11c6b25376efbeac73b4150623bd081f

The following commit(s) were added to refs/heads/main by this push:
     new 04ff4ca  Improve log level or log statement
04ff4ca is described below

commit 04ff4cab11c6b25376efbeac73b4150623bd081f
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Aug 16 10:05:37 2024 +0100

    Improve log level or log statement
---
 .../webauthn/context/navigate/UsernameLookupFromSubjectContext.java   | 2 +-
 .../webauthn/admin/impl/ValidateAuthenticatorAttestationResponse.java | 4 ++--
 .../plugin/authn/webauthn/impl/AbstractWebAuthnExtractionAction.java  | 2 +-
 .../plugin/authn/webauthn/impl/AddUserVerificationRequirement.java    | 2 +-
 .../authn/webauthn/impl/PopulateWebAuthnAuthenticationContext.java    | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/context/navigate/UsernameLookupFromSubjectContext.java b/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/context/navigate/UsernameLookupFromSubjectContext.java
index 113ceab..15735df 100644
--- a/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/context/navigate/UsernameLookupFromSubjectContext.java
+++ b/webauthn-api/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/context/navigate/UsernameLookupFromSubjectContext.java
@@ -48,7 +48,7 @@ public class UsernameLookupFromSubjectContext implements Function<ProfileRequest
             return null;
         }    
         final String username = subjectContext.getPrincipalName();
-        log.debug("Found existing username '{}' from subject", username);
+        log.trace("Found existing username '{}' from subject", username);
         return username;
     }
 
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/impl/ValidateAuthenticatorAttestationResponse.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/impl/ValidateAuthenticatorAttestationResponse.java
index d78dbce..e73c836 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/impl/ValidateAuthenticatorAttestationResponse.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/impl/ValidateAuthenticatorAttestationResponse.java
@@ -109,9 +109,9 @@ public class ValidateAuthenticatorAttestationResponse extends AbstractWebAuthnAc
                     athenticator, credentialPublicKey.isAttestationTrusted() ? "Yes" : "No");
             // If valid. Add back to context
             context.setRegistrationResult(credentialPublicKey);
-            log.info("{} Public key registration was valid", getLogPrefix());
+            log.info("{} Public key registration was valid for '{}'", getLogPrefix(), context.getUsername());
         } catch (final RegistrationFailureException e) {
-            log.warn("{} Public key registration failed", getLogPrefix(), e);
+            log.warn("{} Public key registration failed for '{}'", getLogPrefix(), context.getUsername(), e);
             ActionSupport.buildEvent(profileRequestContext, WebAuthnRegistrationEventIds.INVALID_REGISTRATION);
             context.ensureSubcontext(WebAuthnRegistrationErrorContext.class)
                 .addClassifiedError(WebAuthnRegistrationEventIds.INVALID_REGISTRATION);
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AbstractWebAuthnExtractionAction.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AbstractWebAuthnExtractionAction.java
index f74607b..f3c1629 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AbstractWebAuthnExtractionAction.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AbstractWebAuthnExtractionAction.java
@@ -35,7 +35,7 @@ import net.shibboleth.shared.primitive.LoggerFactory;
 import net.shibboleth.shared.primitive.StringSupport;
 
 /**
- * A base class for WebAuthn actions that extracts a username for subsequent use.
+ * A base class for WebAuthn actions that extract a username for subsequent use.
  * 
  * <p>The base class adds a common mechanism for applying regular expression transforms to
  * the username prior to being added to the context tree.</p>
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AddUserVerificationRequirement.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AddUserVerificationRequirement.java
index 731d212..ca1cd3c 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AddUserVerificationRequirement.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AddUserVerificationRequirement.java
@@ -77,7 +77,7 @@ public class AddUserVerificationRequirement extends AbstractWebAuthnAction<BaseW
     protected void doExecute(@Nonnull final ProfileRequestContext profileRequestContext,
             @Nonnull final BaseWebAuthnContext context) {
 
-        log.debug("{} UserVerification is '{}'",getLogPrefix(), userVerificationRequirement);
+        log.trace("{} UserVerification is '{}'",getLogPrefix(), userVerificationRequirement);
         context.setUserVerificationRequirement(userVerificationRequirement);
         
     }
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/PopulateWebAuthnAuthenticationContext.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/PopulateWebAuthnAuthenticationContext.java
index 83fae89..11952ce 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/PopulateWebAuthnAuthenticationContext.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/PopulateWebAuthnAuthenticationContext.java
@@ -144,7 +144,7 @@ public class PopulateWebAuthnAuthenticationContext extends AbstractAuthenticatio
         }
         contextUpdateConsumer.accept(profileRequestContext);        
 
-        log.debug("Created WebAuthn authentication context {}", username != null ? "for user '"+username+"'" : 
+        log.trace("Created WebAuthn authentication context {}", username != null ? "for user '"+username+"'" : 
             "without existing username");
         
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.