[java-idp-plugin-webauthn] branch main updated: Update flow state ID and add comments

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=cb9228c7207b99a22a43b717d146200b66b3fd55

The following commit(s) were added to refs/heads/main by this push:
     new cb9228c  Update flow state ID and add comments
cb9228c is described below

commit cb9228c7207b99a22a43b717d146200b66b3fd55
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Wed Aug 7 10:01:50 2024 +0100

    Update flow state ID and add comments
---
 webauthn-impl/pom.xml                                             | 2 +-
 .../webauthn/storage/impl/CredentialRegistrationSerializer.java   | 1 +
 .../net/shibboleth/idp/flows/authn/WebAuthn/webauthn-flow.xml     | 8 ++++----
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/webauthn-impl/pom.xml b/webauthn-impl/pom.xml
index 0988b4f..a0b5703 100644
--- a/webauthn-impl/pom.xml
+++ b/webauthn-impl/pom.xml
@@ -36,7 +36,7 @@
             <artifactId>webauthn-server-attestation</artifactId>
             <scope>compile</scope>
         </dependency>
-        <dependency><!-- TODO check the IdP provides this -->
+        <dependency>
             <groupId>com.fasterxml.jackson.datatype</groupId>
             <artifactId>jackson-datatype-jdk8</artifactId>
             <scope>compile</scope>
diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/storage/impl/CredentialRegistrationSerializer.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/storage/impl/CredentialRegistrationSerializer.java
index bb8f0c8..1584ae7 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/storage/impl/CredentialRegistrationSerializer.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/storage/impl/CredentialRegistrationSerializer.java
@@ -46,6 +46,7 @@ public class CredentialRegistrationSerializer extends AbstractInitializableCompo
     /** The CBOR friendly json mapper.*/
     protected ObjectMapper jsonMapper;
     
+    /** Constructor.*/
     public CredentialRegistrationSerializer() {
         jsonMapper = JsonMapper.builder()
                 .configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, true)
diff --git a/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/WebAuthn/webauthn-flow.xml b/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/WebAuthn/webauthn-flow.xml
index 0469bc6..c9cbbce 100644
--- a/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/WebAuthn/webauthn-flow.xml
+++ b/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/WebAuthn/webauthn-flow.xml
@@ -2,14 +2,14 @@
 	xsi:schemaLocation="http://www.springframework.org/schema/webflow http://www.springframework.org/schema/webflow/spring-webflow.xsd"
     parent="authn.abstract, authn/conditions">
     
-     <!-- Test if we are operating as 2FA -->
+     <!-- Test if we are operating as a second-factor -->
      <decision-state id="DetermineSecondFactorLogin">
         <if test="IsSecondFactor.test(opensamlProfileRequestContext)"
             then="SecondFactorLogin" 
             else="DetermineUsernamelessFlow" />        
     </decision-state>
     
-    <!-- if usernameless flow, assume username input is not required. Otherwise prompt for username -->
+    <!-- if usernameless flow assume username input is not required. Otherwise prompt for username -->
     <decision-state id="DetermineUsernamelessFlow">
         <if test="IsUsernamelessFlow.test(opensamlProfileRequestContext)"
             then="UsernamelessLogin" 
@@ -112,11 +112,11 @@
             <evaluate expression="flowRequestContext.getExternalContext().getNativeRequest()" result="viewScope.request" />
             <evaluate expression="flowRequestContext.getExternalContext().getNativeResponse()" result="viewScope.response" />
         </on-render>
-       <transition on="proceed" to="AuthenticatePublicKeyCredential" />
+       <transition on="proceed" to="ValidatePublicKeyCredential" />
        
     </view-state>
      
-    <action-state id="AuthenticatePublicKeyCredential">
+    <action-state id="ValidatePublicKeyCredential">
         <evaluate expression="ExtractPublicKeyCredentialAssertionFromFormRequest"/>
         <!-- lookup credentials here so we can exit the process before validation if no registered credentials exist and
         the authentication plugin has been configured to trigger a custom event. Useful for the usernameless flow. -->

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.