[java-idp-plugin-webauthn] branch main updated: Add logging statement to lookup credentials from userHandle

Phil Smart philip.smart at jisc.ac.uk
Fri Aug 2 16:26:11 UTC 2024


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=0b80da068aa5141beefb7088f55a60027e746f69

The following commit(s) were added to refs/heads/main by this push:
     new 0b80da0  Add logging statement to lookup credentials from userHandle
0b80da0 is described below

commit 0b80da068aa5141beefb7088f55a60027e746f69
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Aug 2 17:26:07 2024 +0100

    Add logging statement to lookup credentials from userHandle
---
 .../webauthn/impl/LookupRegisteredCredentialsFromUserHandle.java   | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/LookupRegisteredCredentialsFromUserHandle.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/LookupRegisteredCredentialsFromUserHandle.java
index 7448c84..41e9311 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/LookupRegisteredCredentialsFromUserHandle.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/LookupRegisteredCredentialsFromUserHandle.java
@@ -48,6 +48,9 @@ import net.shibboleth.shared.primitive.LoggerFactory;
  * An action that lookups existing registered credentials from the userHandle supplied in the authenticators assertion
  * response. If no credentials exist and the trigger condition is set, an error event will be produced.
  * 
+ * <p>Does not actually set the found credentials back onto the context. This is a sanity check credentials exist, and
+ * allows flow branching if none are found.</p>
+ * 
  * <p>Also ensures the username found from the userHandle matches that in the authentication context if supplied e.g.
  * for a passwordless authentication.</p>
  * 
@@ -160,9 +163,9 @@ public class LookupRegisteredCredentialsFromUserHandle extends AbstractWebAuthnA
                             userHandle.get().getBase64());
                 } else {
                     credentialsFound = true;
+                    log.debug("{} Found registered credentials for userHandle '{}' (determined username as '{}')", 
+                            getLogPrefix(), userHandle.get().getBase64(), potentialUsername.get());
                 }
-                
-                
             }
         }
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list