[java-idp-plugin-webauthn] branch main updated: Turn on attribute resolution for the admin/registration flow.

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=f96951cbffd22da35b4cb7c69a593e6ed7238786

The following commit(s) were added to refs/heads/main by this push:
     new f96951c  Turn on attribute resolution for the admin/registration flow.
f96951c is described below

commit f96951cbffd22da35b4cb7c69a593e6ed7238786
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri Apr 19 14:41:47 2024 +0100

    Turn on attribute resolution for the admin/registration flow.
---
 .../net/shibboleth/idp/plugin/authn/webauthn/admin/impl/AddUserId.java | 2 ++
 .../src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml      | 3 ++-
 .../idp/plugin/authn/webauthn/conf/authn/webauthn.properties           | 3 +++
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/impl/AddUserId.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/impl/AddUserId.java
index 4ed89c7..7886376 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/impl/AddUserId.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/admin/impl/AddUserId.java
@@ -44,6 +44,8 @@ import net.shibboleth.shared.primitive.LoggerFactory;
  * 
  * <p>Note, the same user should use the same UserHandle.</p>
  * 
+ * TODO: Support a generated unique to username approach, as well as one from the resolver.
+ * 
  * @event {@link WebAuthnRegistrationEventIds#INVALID_REGISTRATION}
  * @pre <pre>ProfileRequestContext.getSubcontext(WebAuthnRegistrationContext.class) != null</pre>
  * @post a UserHandle is added to the registration context
diff --git a/webauthn-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml b/webauthn-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
index 0cbae45..8e42bb9 100644
--- a/webauthn-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
+++ b/webauthn-impl/src/main/resources/META-INF/net.shibboleth.idp/postconfig.xml
@@ -49,7 +49,8 @@
             p:loggingId="%{idp.authn.webauthn.admin.registration.logging:WebAuthnCredentialRegistration}"
             p:policyName="%{idp.authn.webauthn.admin.registration.accessPolicy:AccessByIPAddress}"
             p:nonBrowserSupported="false"
-            p:authenticated="true">
+            p:authenticated="true"
+            p:resolveAttributes="%{idp.authn.webauthn.admin.registration.resolveIdentityAttributes:true}">
         <property name="authenticationFlows">
            <bean parent="shibboleth.CommaDelimStringArray"
              c:_0="#{'%{idp.authn.webauthn.admin.registration.authenticationFlows:}'.trim()}" />
diff --git a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
index 923c694..1d010fb 100644
--- a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
+++ b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
@@ -41,6 +41,9 @@ idp.authn.webauthn.supportedPrincipals = \
 # Restrict the usable authentication flows
 #idp.authn.webauthn.admin.registration.authenticationFlows = 
 
+# Should user.id and display name be resolve from the attribute resolver? else the user.id will be generated by the plugin
+#idp.authn.webauthn.admin.registration.resolveIdentityAttributes = true;
+
 # Enable FIDO Alliance metadata? If you want to use the metadata service, you *must* download and set the trust root and the legal blob file headers
 #idp.authn.webauthn.metadata.enabled = false
 #idp.authn.webauthn.metadata.trustRootFile =

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.