[java-idp-plugin-webauthn] branch main updated: Improve property naming

Phil Smart philip.smart at jisc.ac.uk
Thu Apr 18 15:40:17 UTC 2024


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-webauthn.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-webauthn.git;a=commit;h=6df52463bd6ccfd35c214ff97ac41838dbb11477

The following commit(s) were added to refs/heads/main by this push:
     new 6df5246  Improve property naming
6df5246 is described below

commit 6df52463bd6ccfd35c214ff97ac41838dbb11477
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Thu Apr 18 16:40:15 2024 +0100

    Improve property naming
---
 .../plugin/authn/webauthn/impl/AddUserVerificationRequirement.java  | 3 ++-
 .../net/shibboleth/idp/flows/authn/WebAuthn/webauthn-beans.xml      | 6 +++---
 .../idp/plugin/authn/webauthn/conf/authn/webauthn.properties        | 6 +++---
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AddUserVerificationRequirement.java b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AddUserVerificationRequirement.java
index 4538d9e..2e485e9 100644
--- a/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AddUserVerificationRequirement.java
+++ b/webauthn-impl/src/main/java/net/shibboleth/idp/plugin/authn/webauthn/impl/AddUserVerificationRequirement.java
@@ -62,7 +62,8 @@ public class AddUserVerificationRequirement extends AbstractWebAuthnBaseAction {
                 Stream.of(UserVerificationRequirement.values())
                 .filter(uv -> uv.getValue().equals(requirement))
                 .findAny()
-                .orElseThrow(() -> new ConstraintViolationException("UserVerification requirement "+requirement+" unknown"));
+                .orElseThrow(() -> 
+                    new ConstraintViolationException("UserVerification requirement "+requirement+" unknown"));
         assert uvRequirement != null;
         userVerificationRequirement = uvRequirement;
     }
diff --git a/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/WebAuthn/webauthn-beans.xml b/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/WebAuthn/webauthn-beans.xml
index b93762f..1cc5b33 100644
--- a/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/WebAuthn/webauthn-beans.xml
+++ b/webauthn-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/WebAuthn/webauthn-beans.xml
@@ -78,8 +78,8 @@
 
     <bean id="LookupRegisteredCredentials" scope="prototype" parent="AbstractWebAuthnBaseAction"
         class="net.shibboleth.idp.plugin.authn.webauthn.impl.LookupRegisteredCredentials"
-        p:triggerEventOnNoCredentials="%{idp.authn.webauthn.triggerEventOnNoCredentials:false}"
-        p:noCredentialsEventId="%{idp.authn.webauthn.noCredentialsEventId:NoRegisteredWebAuthnCredentials}"
+        p:triggerEventOnNoCredentials="%{idp.authn.webauthn.passwordless.signalEventOnNoCredentials:false}"
+        p:noCredentialsEventId="%{idp.authn.webauthn.passwordless.noCredentialsEventId:NoRegisteredWebAuthnCredentials}"
         p:webAuthnBaseContextLookupStrategy-ref="shibboleth.ChildLookup.WebAuthnAuthenticationContextFromAuthenticationContext" />
 
     <bean id="GenerateServerChallenge" scope="prototype" parent="AbstractWebAuthnBaseAction"
@@ -97,7 +97,7 @@
     <bean id="LookupRegisteredCredentialsFromUserHandle" scope="prototype" parent="AbstractWebAuthnAuthenticationAction"
         class="net.shibboleth.idp.plugin.authn.webauthn.impl.LookupRegisteredCredentialsFromUserHandle"
         p:credentialRepository-ref="shibboleth.authn.webauthn.DefaultCredentialRepository"
-        p:triggerEventOnNoCredentials="%{idp.authn.webauthn.triggerEventOnNoCredentialsRegisteredForUserHandle:false}"
+        p:triggerEventOnNoCredentials="%{idp.authn.webauthn.signalEventOnNoCredentialsRegisteredForUserHandle:false}"
         p:noCredentialsEventId="%{idp.authn.webauthn.userHandleNoRegisteredCredentialsEventId:NoCredentialsRegisteredForUserHandle}"/>        
 
     <bean id="ValidateWebAuthnAssertion" scope="prototype"
diff --git a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
index 078288f..896ff94 100644
--- a/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
+++ b/webauthn-impl/src/main/resources/net/shibboleth/idp/plugin/authn/webauthn/conf/authn/webauthn.properties
@@ -92,10 +92,10 @@ idp.authn.webauthn.metadata.crls = classpath:/net/shibboleth/idp/plugin/authn/we
 #idp.authn.webauthn.ui.debug = false
 
 # Should an event be built if there are no credentials found? Only applicable to passwordless authentication.
-#idp.authn.webauthn.triggerEventOnNoCredentials = false
-#idp.authn.webauthn.noCredentialsEventId = NoRegisteredWebAuthnCredentials
+#idp.authn.webauthn.passwordless.signalEventOnNoCredentials = false
+#idp.authn.webauthn.passwordless.noCredentialsEventId = NoRegisteredWebAuthnCredentials
 
 # Should a custom event be built of the userHandle supplied by the authenticator during authentication does not related
 # to any registered credentials? 
-#idp.authn.webauthn.triggerEventOnNoCredentialsRegisteredForUserHandle = false
+#idp.authn.webauthn.signalEventOnNoCredentialsRegisteredForUserHandle = false
 #idp.authn.webauthn.userHandleNoRegisteredCredentialsEventId = NoCredentialsRegisteredForUserHandle

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list