[java-idp-plugin-oidc-rp] branch main updated: Fix possible NPE

Phil Smart philip.smart at jisc.ac.uk
Mon Apr 8 14:45:11 UTC 2024


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=a8eb8f96d669953a2101edcde2a2b5e022d8870c

The following commit(s) were added to refs/heads/main by this push:
     new a8eb8f9  Fix possible NPE
a8eb8f9 is described below

commit a8eb8f96d669953a2101edcde2a2b5e022d8870c
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Mon Apr 8 15:45:09 2024 +0100

    Fix possible NPE
---
 .../rp/impl/InitializeOAuth2ClientAuthenticationMethodHandler.java     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeOAuth2ClientAuthenticationMethodHandler.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeOAuth2ClientAuthenticationMethodHandler.java
index 66e68b0..4ad13a0 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeOAuth2ClientAuthenticationMethodHandler.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeOAuth2ClientAuthenticationMethodHandler.java
@@ -247,7 +247,8 @@ public class InitializeOAuth2ClientAuthenticationMethodHandler extends AbstractM
         }
         
         clientAuthMethod = profileConfiguration.getTokenEndpointAuthMethod(PRC_LOOKUP.apply(messageContext));
-        if (clientAuthMethod.isEmpty()) {
+        final String localClientAuthMethod = clientAuthMethod;
+        if (localClientAuthMethod == null || localClientAuthMethod.isEmpty()) {
             throw new MessageHandlerException("No client authentication method found from profile configuration");
         }
        

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list