[java-idp-oidc] branch main updated: JavaDoc fixes.

Henri Mikkonen henri.mikkonen at iki.fi
Tue Apr 2 05:27:41 UTC 2024


This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch main
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=1ba2fbe1f740e266df64418230ccd902a6b96a7f

The following commit(s) were added to refs/heads/main by this push:
     new 1ba2fbe1 JavaDoc fixes.
1ba2fbe1 is described below

commit 1ba2fbe1f740e266df64418230ccd902a6b96a7f
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Tue Apr 2 08:27:33 2024 +0300

    JavaDoc fixes.
---
 .../oidc/op/authn/impl/ValidateClientAuthenticationType.java       | 6 ++++++
 .../oidc/op/oauth2/profile/impl/AbstractProcessTokenAction.java    | 1 +
 .../InitializeOutboundAuthenticationResponseMessageContext.java    | 7 +++++++
 .../oidc/op/profile/impl/SetRefreshTokenToResponseContext.java     | 2 +-
 .../profile/logic/DefaultJwtRefreshTokenSerializationFunction.java | 2 ++
 5 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/authn/impl/ValidateClientAuthenticationType.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/authn/impl/ValidateClientAuthenticationType.java
index b100a1ed..b9539ffd 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/authn/impl/ValidateClientAuthenticationType.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/authn/impl/ValidateClientAuthenticationType.java
@@ -196,6 +196,12 @@ public class ValidateClientAuthenticationType extends AbstractAuthenticationActi
         return null;
     }
 
+    /**
+     * Get the client ID value as string if the object is non-null.
+     *     
+     * @param clientId client ID, may be null.
+     * @return the client ID value.
+     */
     @Nullable private String getClientIDValue(@Nullable final ClientID clientId) {
         return clientId == null ? null : clientId.getValue();
     }
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oauth2/profile/impl/AbstractProcessTokenAction.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oauth2/profile/impl/AbstractProcessTokenAction.java
index 48ffba49..e3cd8ebf 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oauth2/profile/impl/AbstractProcessTokenAction.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/oauth2/profile/impl/AbstractProcessTokenAction.java
@@ -289,6 +289,7 @@ public abstract class AbstractProcessTokenAction<T> extends AbstractOIDCRequestA
     /**
      * Attempt to parse refresh token.
      * 
+     * @param profileRequestContext the profile request context
      * @param token the token
      * 
      * @return parsed claim set or null
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/InitializeOutboundAuthenticationResponseMessageContext.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/InitializeOutboundAuthenticationResponseMessageContext.java
index bde440db..c6f02dc7 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/InitializeOutboundAuthenticationResponseMessageContext.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/InitializeOutboundAuthenticationResponseMessageContext.java
@@ -291,6 +291,13 @@ public class InitializeOutboundAuthenticationResponseMessageContext
 
     // Checkstyle: CyclomaticComplexity OFF
 
+    /**
+     * Populates the corresponding elements at the given descriptors from the data from the given client information.
+     * 
+     * @param entityDescriptor The entity descriptor whose contact persons are populated.
+     * @param spDescriptor The SP descriptor whose UI info is populated.
+     * @param clientInformation The client information used as the source data.
+     */
     protected void populateEntityDescriptor(final EntityDescriptor entityDescriptor,
             final SPSSODescriptor spDescriptor, @Nonnull final OIDCClientInformation clientInformation) {
         final OIDCClientMetadata oidcMetadata = clientInformation.getOIDCMetadata();
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/SetRefreshTokenToResponseContext.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/SetRefreshTokenToResponseContext.java
index 92628d16..a571a20d 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/SetRefreshTokenToResponseContext.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/impl/SetRefreshTokenToResponseContext.java
@@ -426,7 +426,7 @@ public class SetRefreshTokenToResponseContext extends AbstractOIDCResponseAction
     /**
      * Get the possibly existing chain expiration instant from the claims set.
      * 
-     * @param claimsSet the claims set input
+     * @param tokenClaimsSet the claims set input
      * @return the existing value if exists, null otherwise
      */
     protected Instant getExistingChainExp(@Nonnull final TokenClaimsSet tokenClaimsSet) {
diff --git a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/logic/DefaultJwtRefreshTokenSerializationFunction.java b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/logic/DefaultJwtRefreshTokenSerializationFunction.java
index b90b8039..4a297fa1 100644
--- a/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/logic/DefaultJwtRefreshTokenSerializationFunction.java
+++ b/idp-oidc-extension-impl/src/main/java/net/shibboleth/idp/plugin/oidc/op/profile/logic/DefaultJwtRefreshTokenSerializationFunction.java
@@ -206,7 +206,9 @@ public class DefaultJwtRefreshTokenSerializationFunction extends AbstractInitial
     /**
      * Construct a {@link SignedJWT} with the given input claims and signing parameters.
      * @param claimsSet The input for payload
+     * @param audience The audience for the JWT
      * @param signingParameters The signing parameters
+     * @param typeHeader The type header value for the JWT
      * @return A signed JWT, or null
      */
     @Nullable protected SignedJWT constructJWT(@Nonnull final RefreshTokenClaimsSet claimsSet,

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list