[java-mvn-enforcer] 01/03: JMVN-57 Clean up logging & logging levels
Rod Widdowson
rdw at steadingsoftware.com
Sun Nov 5 14:49:58 UTC 2023
This is an automated email from the git hooks/post-receive script.
rdw pushed a commit to branch main
in repository java-mvn-enforcer.
View the commit online:
http://git.shibboleth.net/view/?p=java-mvn-enforcer.git;a=commit;h=c41895b2c10133d7fc674e40af737a23cbb38247
commit c41895b2c10133d7fc674e40af737a23cbb38247
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Sun Nov 5 13:33:30 2023 +0000
JMVN-57 Clean up logging & logging levels
https://shibboleth.atlassian.net/browse/JMVN-57
Only issue an ERROR if we are about to stop processing.
---
.../shibboleth/mvn/enforcer/impl/DependencyChecker.java | 2 +-
.../java/net/shibboleth/mvn/enforcer/impl/ParsedPom.java | 10 +++++-----
.../shibboleth/mvn/enforcer/impl/ProjectPomContext.java | 14 +++++++-------
3 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/src/main/java/net/shibboleth/mvn/enforcer/impl/DependencyChecker.java b/src/main/java/net/shibboleth/mvn/enforcer/impl/DependencyChecker.java
index 83d7667..f828098 100644
--- a/src/main/java/net/shibboleth/mvn/enforcer/impl/DependencyChecker.java
+++ b/src/main/java/net/shibboleth/mvn/enforcer/impl/DependencyChecker.java
@@ -269,7 +269,7 @@ public class DependencyChecker {
}
}
if (noSource > 0) {
- log.error("{} orphaned Artifacts", noSource);
+ log.warn("{} orphaned Artifacts", noSource);
}
report.format("%d Orphaned artifact(s)\n", noSource);
}
diff --git a/src/main/java/net/shibboleth/mvn/enforcer/impl/ParsedPom.java b/src/main/java/net/shibboleth/mvn/enforcer/impl/ParsedPom.java
index 705d37a..0ba07b0 100644
--- a/src/main/java/net/shibboleth/mvn/enforcer/impl/ParsedPom.java
+++ b/src/main/java/net/shibboleth/mvn/enforcer/impl/ParsedPom.java
@@ -421,13 +421,13 @@ public class ParsedPom {
} else if (parentArtifact != null) {
groupId = parentArtifact.getGroupId();
} else {
- log.error("{}: <groupId> should exist in dependency", sourcePomInfo);
+ log.warn("{}: <groupId> should exist in dependency", sourcePomInfo);
groupId = UNSPECIFIED_GROUP;
}
final List<Element> arts = ElementSupport.getChildElementsByTagName(item, "artifactId");
if (arts.size() == 0) {
- log.error("{}: <artifactId> should exist in dependency", sourcePomInfo);
+ log.warn("{}: <artifactId> should exist in dependency", sourcePomInfo);
}
artifactId = getElementContent(arts.get(0));
@@ -447,7 +447,7 @@ public class ParsedPom {
final List<Element> clssfrs = ElementSupport.getChildElementsByTagName(item, "classifier");
if (clssfrs.size() > 1) {
- log.error("{} 0 or 1 <classifier> elements should exist in dependency", sourcePomInfo);
+ log.warn("{} 0 or 1 <classifier> elements should exist in dependency", sourcePomInfo);
}
List<Element> excls = ElementSupport.getChildElementsByTagName(item, "exclusions");
@@ -458,7 +458,7 @@ public class ParsedPom {
final String grp;
if (els.size() == 0) {
grp = "";
- log.error("{}: <groupId> should exist in exclusion\"", sourcePomInfo);
+ log.warn("{}: <groupId> should exist in exclusion\"", sourcePomInfo);
} else {
grp = getElementContent(els.get(0));
}
@@ -466,7 +466,7 @@ public class ParsedPom {
els = ElementSupport.getChildElementsByTagName(e, "artifactId");
if (els.size() == 0) {
art = "";
- log.error("{}: <artifactId> should exist in exclusion\"", sourcePomInfo);
+ log.warn("{}: <artifactId> should exist in exclusion\"", sourcePomInfo);
} else {
art = getElementContent(els.get(0));
}
diff --git a/src/main/java/net/shibboleth/mvn/enforcer/impl/ProjectPomContext.java b/src/main/java/net/shibboleth/mvn/enforcer/impl/ProjectPomContext.java
index f324696..8bba4e1 100644
--- a/src/main/java/net/shibboleth/mvn/enforcer/impl/ProjectPomContext.java
+++ b/src/main/java/net/shibboleth/mvn/enforcer/impl/ProjectPomContext.java
@@ -171,22 +171,22 @@ public final class ProjectPomContext implements AutoCloseable {
null,
Collections.emptyMap());
} catch (final Exception e) {
- log.error("Could not load pom", e);
+ log.warn("Could not load pom", e);
return false;
}
if (parentPom.getParent() == null) {
- log.error("Provided pom {} had no parent", pomPath);
+ log.warn("Provided pom {} had no parent", pomPath);
return false;
}
final Path parentPath;
try {
parentPath = mavenLoader.downloadArtifact(parentPom.getParent(), "pom");
} catch (final Exception e) {
- log.error("Could not download {}:", parentPom.getParent(), e);
+ log.warn("Could not download {}:", parentPom.getParent(), e);
return false;
}
if (parentPath == null) {
- log.error("Could not download {}:", parentPom.getParent());
+ log.warn("Could not download {}:", parentPom.getParent());
return false;
}
try {
@@ -194,7 +194,7 @@ public final class ProjectPomContext implements AutoCloseable {
parentPath, "parent pom.", log,
new Properties(), Collections.emptyMap());
} catch (final Exception e) {
- log.error("Could not parse {}", parentPom.getParent(), e);
+ log.warn("Could not parse {}", parentPom.getParent(), e);
return false;
}
try {
@@ -202,7 +202,7 @@ public final class ProjectPomContext implements AutoCloseable {
"provided pom", log, projectParent.getProperties(),
projectParent.getManagedDependencies());
} catch (final Exception e) {
- log.error("Could not load pom", e);
+ log.warn("Could not load pom", e);
return false;
}
if (!projectParent.getCompileDependencies().isEmpty()) {
@@ -338,7 +338,7 @@ public final class ProjectPomContext implements AutoCloseable {
}
String group = artifactToGroup.get(base);
if (group == null) {
- log.error("Could not determine group for {} consider amending artifactMap.properties", inName);
+ log.warn("Could not determine group for {} consider amending artifactMap.properties", inName);
group = ParsedPom.UNSPECIFIED_GROUP;
}
final String versionExtension = name.substring(last+1);
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list