[JIRA] (MDA-265) Fix site generation for new repository structure
Ian Young (Jira)
jira at shibboleth.atlassian.net
Tue May 30 10:40:50 UTC 2023
Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on MDA-265 ( https://shibboleth.atlassian.net/browse/MDA-265?atlOrigin=eyJpIjoiMzc5OGRmZDJlNmY0NGY3YWFhMmY1NjVhNTVlNDhlOTQiLCJwIjoiaiJ9 )
Re: Fix site generation for new repository structure ( https://shibboleth.atlassian.net/browse/MDA-265?atlOrigin=eyJpIjoiMzc5OGRmZDJlNmY0NGY3YWFhMmY1NjVhNTVlNDhlOTQiLCJwIjoiaiJ9 )
With the fixes from last week, the snapshot site is much improved. It’s far from perfect, but I’m going to declare it as good enough and meeting the intent of this issue.
The most obvious departure from what you’d expect is that the parent link on the main module claims to point to the Shibboleth parent project but is actually a relative link leading nowhere. I found a ticket complaining about this kind of behaviour many years ago with more than 700 “me too”s and I have not been able to find a simple solution. It’s actually less broken than the snapshot site for the IdP, but that in turn is probably because of the parent-as-sibling structure there.
If we needed to fix this properly, I can’t see an alternative that involves a single inherited site.xml file. Instead, you need a site.xml in every module as well (although they could be symbolic links to a resource in the mda-parent ). Given that I'm minded to drop the site entirely, that seems like more work than we need to put in.
Closing as “good enough”.
( https://shibboleth.atlassian.net/browse/MDA-265#add-comment?atlOrigin=eyJpIjoiMzc5OGRmZDJlNmY0NGY3YWFhMmY1NjVhNTVlNDhlOTQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-265#add-comment?atlOrigin=eyJpIjoiMzc5OGRmZDJlNmY0NGY3YWFhMmY1NjVhNTVlNDhlOTQiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:d82e018 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230530/8b6af7b3/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-f1eea1a7-ad63-4707-9319-e35baec47d36
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230530/8b6af7b3/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e18f8aba-e595-4f9d-833c-be9c35a89808
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230530/8b6af7b3/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-d105fcb2-a7b4-4a2c-9e1c-01cf393dc4df
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230530/8b6af7b3/attachment-0005.png>
More information about the commits
mailing list