[java-identity-provider] 01/04: IDP-2119 Plugin Installer should allow spring files to be supplied

Rod Widdowson rdw at steadingsoftware.com
Sun May 28 15:05:03 UTC 2023


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=3188d822b41c7b3378ffc4ee84416a937190bc5d

commit 3188d822b41c7b3378ffc4ee84416a937190bc5d
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Fri May 26 13:56:52 2023 +0100

    IDP-2119 Plugin Installer should allow spring files to be supplied
    
    https://shibboleth.atlassian.net/browse/IDP-2119
---
 .../idp/installer/impl/InstallerProperties.java           |  2 +-
 .../installer/plugin/impl/PluginInstallerArguments.java   | 15 ---------------
 2 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/idp-installer/src/main/java/net/shibboleth/idp/installer/impl/InstallerProperties.java b/idp-installer/src/main/java/net/shibboleth/idp/installer/impl/InstallerProperties.java
index 50a635789..4c91e13aa 100644
--- a/idp-installer/src/main/java/net/shibboleth/idp/installer/impl/InstallerProperties.java
+++ b/idp-installer/src/main/java/net/shibboleth/idp/installer/impl/InstallerProperties.java
@@ -92,7 +92,7 @@ public class InstallerProperties  {
     /** The sealer alias to use.  */
     public static final String SEALER_ALIAS = "idp.sealer.alias";
 
-    /** The sealer alias to use.  */
+    /** The keysize for the sealer.  */
     public static final String SEALER_KEYSIZE = "idp.sealer.keysize";
 
     /** The the key size to generate.  */
diff --git a/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstallerArguments.java b/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstallerArguments.java
index 1cc55c5e5..665d7e1d4 100644
--- a/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstallerArguments.java
+++ b/idp-installer/src/main/java/net/shibboleth/idp/installer/plugin/impl/PluginInstallerArguments.java
@@ -22,7 +22,6 @@ import java.io.PrintStream;
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.nio.file.Path;
-import java.util.List;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
@@ -292,20 +291,6 @@ public class PluginInstallerArguments extends AbstractIdPHomeAwareCommandLineArg
     public void validate() throws IllegalArgumentException {
         super.validate();
 
-        final List<String> otherArgs = getOtherArgs();
-        if (otherArgs.size() > 1) {
-            final StringBuffer output = new StringBuffer().append('"');
-            for (int i = 2; i <= otherArgs.size() ; i++ ) {
-                output.append(otherArgs.get(i-1));
-                if (i == otherArgs.size()) {
-                    output.append('"');
-                } else {
-                    output.append(' ');
-                }
-            }
-            getLog().error("Unexpected extra arguments {}", output);
-            throw new IllegalArgumentException("Unexpected extra arguments");
-        }
         if (list || fullList || listAvailable) {
             operation = OperationType.LIST;
             if (input !=  null || uninstallId != null) {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list