[java-identity-provider] branch maint-4 updated: IDP-2122 PluginVersion.equals is incorrectly implemented

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch maint-4
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=8a26ee0a696ac043e61f0f374e4579f661806b2e

The following commit(s) were added to refs/heads/maint-4 by this push:
     new 8a26ee0a6 IDP-2122 PluginVersion.equals is incorrectly implemented
8a26ee0a6 is described below

commit 8a26ee0a696ac043e61f0f374e4579f661806b2e
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Sun May 28 13:48:51 2023 +0100

    IDP-2122 PluginVersion.equals is incorrectly implemented
    
    https://shibboleth.atlassian.net/browse/IDP-2122
---
 .../src/main/java/net/shibboleth/idp/plugin/PluginVersion.java          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/idp-admin-api/src/main/java/net/shibboleth/idp/plugin/PluginVersion.java b/idp-admin-api/src/main/java/net/shibboleth/idp/plugin/PluginVersion.java
index 1d35dd4c7..b1237f993 100644
--- a/idp-admin-api/src/main/java/net/shibboleth/idp/plugin/PluginVersion.java
+++ b/idp-admin-api/src/main/java/net/shibboleth/idp/plugin/PluginVersion.java
@@ -144,7 +144,7 @@ public final class PluginVersion implements Comparable<PluginVersion>{
     public boolean equals(final Object obj) {
         if (obj instanceof PluginVersion) {
             final PluginVersion other= (PluginVersion)obj;
-            return other.major == major && other.minor == minor && other.patch == other.patch;
+            return other.major == major && other.minor == minor && other.patch == patch;
         }
         return false;
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.