[JIRA] (IDP-2002) Migrate all unmanaged config files into core module

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2002 ( https://shibboleth.atlassian.net/browse/IDP-2002?atlOrigin=eyJpIjoiZGU5ODZmNmFmNzI4NDFjOGEzNmVhMWYyZTdhNjhiZTEiLCJwIjoiaiJ9 )

Re: Migrate all unmanaged config files into core module ( https://shibboleth.atlassian.net/browse/IDP-2002?atlOrigin=eyJpIjoiZGU5ODZmNmFmNzI4NDFjOGEzNmVhMWYyZTdhNjhiZTEiLCJwIjoiaiJ9 )

Something odd going on here.

I just upgraded a pre-this-change idp installation (on Debian) to the latest (with all the module changes). This means we are getting the V4->V5 behavior.

After the upgrade I see:

rdw at DELL10:~/idp/bin$ ls *5*
build.sh.idpnew-500-SNAPSHOT  runclass.sh.idpnew-500-SNAPSHOT
rdw at DELL10:~/idp/bin$ diff build.sh build.sh.idpnew-500-SNAPSHOT
7c7,8
< $LOCATION/ant.sh "$@" build-war
---
> $LOCATION/runclass.sh net.shibboleth.idp.installer.impl.IdPBuildWar --ansi --home "$LOCATION/.." "$@"
>
rdw at DELL10:~/idp/bin$ diff runclass.sh runclass.sh.idpnew-500-SNAPSHOT
45c45
< LOCALCLASSPATH="$LOCATION/lib/*":$LOCALCLASSPATH
---
> LOCALCLASSPATH="$LOCATION/../dist/binlib/*":$LOCALCLASSPATH
rdw at DELL10:~/idp/bin$

It looks like when it [re-] enabled the cli module it preserved the old version, which it should do. But not in this particular situation.

I’m guessing that this will be true going onwards: any changes to bin will not be reflected after an upgrade. We kinda don’t want this to happen. Do we?

I for one, don’t have a clue what to do about this.

( https://shibboleth.atlassian.net/browse/IDP-2002#add-comment?atlOrigin=eyJpIjoiZGU5ODZmNmFmNzI4NDFjOGEzNmVhMWYyZTdhNjhiZTEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2002#add-comment?atlOrigin=eyJpIjoiZGU5ODZmNmFmNzI4NDFjOGEzNmVhMWYyZTdhNjhiZTEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:0428b75 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230525/ffc45a4b/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-2aca2352-7922-4e57-833e-055fed966817
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230525/ffc45a4b/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-26d1e787-22cb-44b6-a6c8-998ada0afcf4
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230525/ffc45a4b/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-8dc978cc-f8e2-4b75-b509-f6795b276c4b
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230525/ffc45a4b/attachment-0005.png>