[JIRA] (JSMD-4) Adjust unnecessary lazy-init declarations in parsers
Scott Cantor (Jira)
jira at shibboleth.atlassian.net
Wed May 24 12:32:00 UTC 2023
Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JSMD-4 ( https://shibboleth.atlassian.net/browse/JSMD-4?atlOrigin=eyJpIjoiMGU3ZWVmYzVkOWZmNGIyOTg1ZjUyNzA2MzViNzZjOTAiLCJwIjoiaiJ9 )
Re: Adjust unnecessary lazy-init declarations in parsers ( https://shibboleth.atlassian.net/browse/JSMD-4?atlOrigin=eyJpIjoiMGU3ZWVmYzVkOWZmNGIyOTg1ZjUyNzA2MzViNzZjOTAiLCJwIjoiaiJ9 )
Notably, we also have SpringSupport.parseCustomElement methods that in various ways do lazy-init, and I actually changed the resolver parsing to do that so that the dual uses of the resolver schema in two different services was optimized. The registry doesn’t need AttributeDefinitions or DataConnectors, so they don’t get created.
There’s clearly a reason to do this, but it’s unclear why we did it for metadata. I suspect the TrustEngine and Credential case was because of the original relying-party schema from V2 having those defined.
( https://shibboleth.atlassian.net/browse/JSMD-4#add-comment?atlOrigin=eyJpIjoiMGU3ZWVmYzVkOWZmNGIyOTg1ZjUyNzA2MzViNzZjOTAiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSMD-4#add-comment?atlOrigin=eyJpIjoiMGU3ZWVmYzVkOWZmNGIyOTg1ZjUyNzA2MzViNzZjOTAiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230524/6f0e12b4/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-a3b6b674-35e8-4a92-8d65-e8870fa229cd
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230524/6f0e12b4/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e0ee28af-3683-4b11-8bc4-098b95573780
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230524/6f0e12b4/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-951b1662-2e30-404c-b1e9-a75b69077ea2
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230524/6f0e12b4/attachment-0005.png>
More information about the commits
mailing list